[GitHub] [spark] AmplabJenkins commented on issue #25458: [SPARK-27931][SQL] Accept 'on' and 'off' as input and trim input for the boolean data type.

2019-08-15 Thread GitBox
AmplabJenkins commented on issue #25458: [SPARK-27931][SQL] Accept 'on' and 'off' as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#issuecomment-521856072 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #25456: [SPARK-28739][SQL] Add a simple cost check for Adaptive Query Execution

2019-08-15 Thread GitBox
AmplabJenkins commented on issue #25456: [SPARK-28739][SQL] Add a simple cost check for Adaptive Query Execution URL: https://github.com/apache/spark/pull/25456#issuecomment-521856063 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-15 Thread GitBox
AmplabJenkins commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-521856006 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-15 Thread GitBox
AmplabJenkins commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-521855997 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-15 Thread GitBox
AmplabJenkins commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-521856024 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25463: [SPARK-28744][SQL][TEST] rename SharedSQLContext to SharedSparkSession

2019-08-15 Thread GitBox
AmplabJenkins commented on issue #25463: [SPARK-28744][SQL][TEST] rename SharedSQLContext to SharedSparkSession URL: https://github.com/apache/spark/pull/25463#issuecomment-521855972 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-15 Thread GitBox
AmplabJenkins commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-521856022 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available

2019-08-15 Thread GitBox
AmplabJenkins commented on issue #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available URL: https://github.com/apache/spark/pull/25460#issuecomment-521856023 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #25467: [SPARK-28634][yarn] Ignore kerberos login config in client mode AM.

2019-08-15 Thread GitBox
AmplabJenkins commented on issue #25467: [SPARK-28634][yarn] Ignore kerberos login config in client mode AM. URL: https://github.com/apache/spark/pull/25467#issuecomment-521856005 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25463: [SPARK-28744][SQL][TEST] rename SharedSQLContext to SharedSparkSession

2019-08-15 Thread GitBox
AmplabJenkins commented on issue #25463: [SPARK-28744][SQL][TEST] rename SharedSQLContext to SharedSparkSession URL: https://github.com/apache/spark/pull/25463#issuecomment-521855968 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #25467: [SPARK-28634][yarn] Ignore kerberos login config in client mode AM.

2019-08-15 Thread GitBox
AmplabJenkins commented on issue #25467: [SPARK-28634][yarn] Ignore kerberos login config in client mode AM. URL: https://github.com/apache/spark/pull/25467#issuecomment-521855998 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins commented on issue #25455: [SPARK-28737][CORE] Update Jersey to 2.29

2019-08-15 Thread GitBox
AmplabJenkins commented on issue #25455: [SPARK-28737][CORE] Update Jersey to 2.29 URL: https://github.com/apache/spark/pull/25455#issuecomment-521856052 Merged build finished. Test PASSed. This is an automated message from

[GitHub] [spark] AmplabJenkins commented on issue #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available

2019-08-15 Thread GitBox
AmplabJenkins commented on issue #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available URL: https://github.com/apache/spark/pull/25460#issuecomment-521856021 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-08-15 Thread GitBox
AmplabJenkins commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-521855920 Can one of the admins verify this patch? This is an

[GitHub] [spark] shaneknapp commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds

2019-08-15 Thread GitBox
shaneknapp commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-521855845 test this please This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-08-15 Thread GitBox
AmplabJenkins commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-521855487 Can one of the admins verify this patch? This is an

[GitHub] [spark] maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-08-15 Thread GitBox
maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-521852813 @gatorsmile @maryannxue We need this? This is an automated

[GitHub] [spark] cloud-fan commented on issue #25463: [SPARK-28744][SQL][TEST] rename SharedSQLContext to SharedSparkSession

2019-08-15 Thread GitBox
cloud-fan commented on issue #25463: [SPARK-28744][SQL][TEST] rename SharedSQLContext to SharedSparkSession URL: https://github.com/apache/spark/pull/25463#issuecomment-521851980 ok to test This is an automated message from

[GitHub] [spark] HyukjinKwon commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds

2019-08-15 Thread GitBox
HyukjinKwon commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-521850418 Given

[GitHub] [spark] maropu commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-15 Thread GitBox
maropu commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-521849330 Jenkins is sleeping now?

[GitHub] [spark] maropu commented on issue #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available

2019-08-15 Thread GitBox
maropu commented on issue #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available URL: https://github.com/apache/spark/pull/25460#issuecomment-521847778 I feel ok to do so (I think we should fix the existing issue on master/2.4/2.3...)

[GitHub] [spark] maropu commented on a change in pull request #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available

2019-08-15 Thread GitBox
maropu commented on a change in pull request #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available URL: https://github.com/apache/spark/pull/25460#discussion_r314552291 ## File path:

[GitHub] [spark] wangyum commented on a change in pull request #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available

2019-08-15 Thread GitBox
wangyum commented on a change in pull request #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available URL: https://github.com/apache/spark/pull/25460#discussion_r314552128 ## File path:

[GitHub] [spark] HyukjinKwon closed pull request #25310: [SPARK-28578][INFRA] Improve Github pull request template

2019-08-15 Thread GitBox
HyukjinKwon closed pull request #25310: [SPARK-28578][INFRA] Improve Github pull request template URL: https://github.com/apache/spark/pull/25310 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] HyukjinKwon commented on issue #25310: [SPARK-28578][INFRA] Improve Github pull request template

2019-08-15 Thread GitBox
HyukjinKwon commented on issue #25310: [SPARK-28578][INFRA] Improve Github pull request template URL: https://github.com/apache/spark/pull/25310#issuecomment-521845038 Let's see how it goes. thanks guys! This is an automated

[GitHub] [spark] William1104 commented on issue #24912: [WIP][SPARK-28103][SQL] Fix constraints of a Union Logical Plan

2019-08-15 Thread GitBox
William1104 commented on issue #24912: [WIP][SPARK-28103][SQL] Fix constraints of a Union Logical Plan URL: https://github.com/apache/spark/pull/24912#issuecomment-521844926 > @William1104 Is this still work in progress? Hi @venkata91, I am sorry that I have to put this work on hold

[GitHub] [spark] HyukjinKwon commented on issue #25310: [SPARK-28578][INFRA] Improve Github pull request template

2019-08-15 Thread GitBox
HyukjinKwon commented on issue #25310: [SPARK-28578][INFRA] Improve Github pull request template URL: https://github.com/apache/spark/pull/25310#issuecomment-521844986 Merged to master. This is an automated message from the

[GitHub] [spark] HyukjinKwon commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-15 Thread GitBox
HyukjinKwon commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-521844423 retest this please This is an

[GitHub] [spark] younggyuchun commented on issue #25458: [SPARK-27931][SQL] Accept 'on' and 'off' as input and trim input for the boolean data type.

2019-08-15 Thread GitBox
younggyuchun commented on issue #25458: [SPARK-27931][SQL] Accept 'on' and 'off' as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#issuecomment-521840725 @HyukjinKwon, @srowen Could you please review this PR?

[GitHub] [spark] younggyuchun commented on issue #25458: [SPARK-27931][SQL] Accept 'on' and 'off' as input and trim input for the boolean data type.

2019-08-15 Thread GitBox
younggyuchun commented on issue #25458: [SPARK-27931][SQL] Accept 'on' and 'off' as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#issuecomment-521839948 Unique prefixes of strings, for example, "true", "tre", "tr" and "t" also accepted.

[GitHub] [spark] dongjoon-hyun commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds

2019-08-15 Thread GitBox
dongjoon-hyun commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-521834973 Thanks. I filed https://issues.apache.org/jira/browse/SPARK-28750 . Please use that

[GitHub] [spark] srowen commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds

2019-08-15 Thread GitBox
srowen commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-521834088 Oh, really, scalac supports it? that is much more feasible then. I suppose we'd have to check that the

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds

2019-08-15 Thread GitBox
dongjoon-hyun edited a comment on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-521833255 @srowen . If that is the goal, can we consider `-release 8` as our feasible option? > If

[GitHub] [spark] dongjoon-hyun commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds

2019-08-15 Thread GitBox
dongjoon-hyun commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-521833255 @srowen . If that is the goal, can we consider `-release 8` as our feasible option? > If that's

[GitHub] [spark] viirya commented on issue #24525: [SPARK-27633][SQL] Remove redundant aliases in NestedColumnAliasing

2019-08-15 Thread GitBox
viirya commented on issue #24525: [SPARK-27633][SQL] Remove redundant aliases in NestedColumnAliasing URL: https://github.com/apache/spark/pull/24525#issuecomment-521833174 cc @cloud-fan Do you have more thoughts on this change?

[GitHub] [spark] dongjoon-hyun commented on issue #25451: [SPARK-28728][BUILD] Bump Jackson Databind to 2.9.9.3

2019-08-15 Thread GitBox
dongjoon-hyun commented on issue #25451: [SPARK-28728][BUILD] Bump Jackson Databind to 2.9.9.3 URL: https://github.com/apache/spark/pull/25451#issuecomment-521828456 Ya. Our Jenkins environment didn't come back after the scheduled maintenance.

[GitHub] [spark] dbtsai closed pull request #25468: [SPARK-28719][BUILD][FOLLOWUP] Make Github Actions log quieter

2019-08-15 Thread GitBox
dbtsai closed pull request #25468: [SPARK-28719][BUILD][FOLLOWUP] Make Github Actions log quieter URL: https://github.com/apache/spark/pull/25468 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dbtsai opened a new pull request #25468: [SPARK-28719][BUILD][FOLLOWUP] Make Github Actions log quieter

2019-08-15 Thread GitBox
dbtsai opened a new pull request #25468: [SPARK-28719][BUILD][FOLLOWUP] Make Github Actions log quieter URL: https://github.com/apache/spark/pull/25468 ## What changes were proposed in this pull request? Make Github Actions log quieter

[GitHub] [spark] dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command

2019-08-15 Thread GitBox
dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#issuecomment-521813753 @cloud-fan > Maybe it's time to introduce a new framework for printing a query plan, which is decoupled from the query plan

[GitHub] [spark] wangyum commented on issue #25451: [SPARK-28728][BUILD] Bump Jackson Databind to 2.9.9.3

2019-08-15 Thread GitBox
wangyum commented on issue #25451: [SPARK-28728][BUILD] Bump Jackson Databind to 2.9.9.3 URL: https://github.com/apache/spark/pull/25451#issuecomment-521810612 retest this please This is an automated message from the Apache

[GitHub] [spark] wangyum commented on issue #25451: [SPARK-28728][BUILD] Bump Jackson Databind to 2.9.9.3

2019-08-15 Thread GitBox
wangyum commented on issue #25451: [SPARK-28728][BUILD] Bump Jackson Databind to 2.9.9.3 URL: https://github.com/apache/spark/pull/25451#issuecomment-521810580 ![image](https://user-images.githubusercontent.com/5399861/63129354-e2828300-bfe9-11e9-8d21-710236971f81.png)

[GitHub] [spark] wangyum commented on a change in pull request #25443: [WIP][SPARK-28723][test-hadoop3.2][test-maven] Test JDK 11 with Hadoop-3.2/Hive 2.3.6 on jenkins

2019-08-15 Thread GitBox
wangyum commented on a change in pull request #25443: [WIP][SPARK-28723][test-hadoop3.2][test-maven] Test JDK 11 with Hadoop-3.2/Hive 2.3.6 on jenkins URL: https://github.com/apache/spark/pull/25443#discussion_r314512365 ## File path: dev/run-tests-jenkins.py ## @@

[GitHub] [spark] gatorsmile commented on issue #25456: [SPARK-28739][SQL] Add a simple cost check for Adaptive Query Execution

2019-08-15 Thread GitBox
gatorsmile commented on issue #25456: [SPARK-28739][SQL] Add a simple cost check for Adaptive Query Execution URL: https://github.com/apache/spark/pull/25456#issuecomment-521808023 retest this please This is an automated

[GitHub] [spark] dilipbiswal commented on issue #25459: [SPARK-28734[DOC] Initial table of content in the left hand side bar for SQL doc

2019-08-15 Thread GitBox
dilipbiswal commented on issue #25459: [SPARK-28734[DOC] Initial table of content in the left hand side bar for SQL doc URL: https://github.com/apache/spark/pull/25459#issuecomment-521807831 @gatorsmile This is before ..

[GitHub] [spark] dilipbiswal commented on issue #25459: [SPARK-28734[DOC] Initial table of content in the left hand side bar for SQL doc

2019-08-15 Thread GitBox
dilipbiswal commented on issue #25459: [SPARK-28734[DOC] Initial table of content in the left hand side bar for SQL doc URL: https://github.com/apache/spark/pull/25459#issuecomment-521807472 @gatorsmile This is after change.. I have not captured all the screen shots..

[GitHub] [spark] vanzin opened a new pull request #25467: [SPARK-28634][yarn] Ignore kerberos login config in client mode AM.

2019-08-15 Thread GitBox
vanzin opened a new pull request #25467: [SPARK-28634][yarn] Ignore kerberos login config in client mode AM. URL: https://github.com/apache/spark/pull/25467 This change makes the client mode AM ignore any login configuration, which is now always handled by the driver. The previous code

[GitHub] [spark] srowen commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds

2019-08-15 Thread GitBox
srowen commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-521777821 Oh yes certainly. I can't see cross-publishing for 2 scala versions and 2 java versions, in addition to

[GitHub] [spark] zsxwing commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer

2019-08-15 Thread GitBox
zsxwing commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer URL: https://github.com/apache/spark/pull/24382#discussion_r314471440 ## File path:

[GitHub] [spark] zsxwing commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer

2019-08-15 Thread GitBox
zsxwing commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer URL: https://github.com/apache/spark/pull/24382#discussion_r314471377 ## File path:

[GitHub] [spark] zsxwing commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer

2019-08-15 Thread GitBox
zsxwing commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer URL: https://github.com/apache/spark/pull/24382#discussion_r314471177 ## File path:

[GitHub] [spark] zsxwing commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer

2019-08-15 Thread GitBox
zsxwing commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer URL: https://github.com/apache/spark/pull/24382#discussion_r314470645 ## File path:

[GitHub] [spark] gatorsmile commented on issue #25459: [SPARK-28734[DOC] Initial table of content in the left hand side bar for SQL doc

2019-08-15 Thread GitBox
gatorsmile commented on issue #25459: [SPARK-28734[DOC] Initial table of content in the left hand side bar for SQL doc URL: https://github.com/apache/spark/pull/25459#issuecomment-521773170 @dilipbiswal Could you copy and paste the WebUI pages [before and after your changes]

[GitHub] [spark] dongjoon-hyun commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds

2019-08-15 Thread GitBox
dongjoon-hyun commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-521773028 So, the goal is to have a single binary Apache Spark 3.0.0 for JDK8 and JDK11, @srowen ?

[GitHub] [spark] dongjoon-hyun closed pull request #25462: [SPARK-28745][SQL][TEST] Add benchmarks for `extract()`

2019-08-15 Thread GitBox
dongjoon-hyun closed pull request #25462: [SPARK-28745][SQL][TEST] Add benchmarks for `extract()` URL: https://github.com/apache/spark/pull/25462 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] shaneknapp edited a comment on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds

2019-08-15 Thread GitBox
shaneknapp edited a comment on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-521761223 > I meant both Maven and SBT need the same treatment, to use Java 11 for tests (only). The

[GitHub] [spark] shaneknapp edited a comment on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds

2019-08-15 Thread GitBox
shaneknapp edited a comment on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-521761223 > I meant both Maven and SBT need the same treatment, to use Java 11 for tests (only). The

[GitHub] [spark] shaneknapp commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds

2019-08-15 Thread GitBox
shaneknapp commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-521761223 > I meant both Maven and SBT need the same treatment, to use Java 11 for tests (only). The

[GitHub] [spark] huaxingao commented on issue #25371: [SPARK-28393][SQL][PYTHON][TESTS] Convert and port 'pgSQL/join.sql' into UDF test base

2019-08-15 Thread GitBox
huaxingao commented on issue #25371: [SPARK-28393][SQL][PYTHON][TESTS] Convert and port 'pgSQL/join.sql' into UDF test base URL: https://github.com/apache/spark/pull/25371#issuecomment-521759948 retest this please This is an

[GitHub] [spark] srowen commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds

2019-08-15 Thread GitBox
srowen commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-521754374 The issue is the bootclasspath. If you build with Java 11's bootclasspath, it won't work on 8 anymore even

[GitHub] [spark] shaneknapp commented on a change in pull request #25443: [WIP][SPARK-28723][test-hadoop3.2][test-maven] Test JDK 11 with Hadoop-3.2/Hive 2.3.6 on jenkins

2019-08-15 Thread GitBox
shaneknapp commented on a change in pull request #25443: [WIP][SPARK-28723][test-hadoop3.2][test-maven] Test JDK 11 with Hadoop-3.2/Hive 2.3.6 on jenkins URL: https://github.com/apache/spark/pull/25443#discussion_r314445985 ## File path: dev/run-tests-jenkins.py ## @@

[GitHub] [spark] shivsood commented on a change in pull request #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect

2019-08-15 Thread GitBox
shivsood commented on a change in pull request #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect URL: https://github.com/apache/spark/pull/25344#discussion_r314445675 ## File path:

[GitHub] [spark] attilapiros commented on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host

2019-08-15 Thread GitBox
attilapiros commented on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host URL: https://github.com/apache/spark/pull/25299#issuecomment-521748111 retest this please.

[GitHub] [spark] dongjoon-hyun commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds

2019-08-15 Thread GitBox
dongjoon-hyun commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-521747754 @srowen I know that rule and I thought the following was due to our limitation. > I meant both

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds

2019-08-15 Thread GitBox
dongjoon-hyun edited a comment on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-521747754 @srowen I know that rule and I thought the rule was due to our limitation. > I meant both

[GitHub] [spark] dongjoon-hyun closed pull request #25466: [MINOR][DOC] Use `Java 8` instead of `Java 8+` as a running environment

2019-08-15 Thread GitBox
dongjoon-hyun closed pull request #25466: [MINOR][DOC] Use `Java 8` instead of `Java 8+` as a running environment URL: https://github.com/apache/spark/pull/25466 This is an automated message from the Apache Git Service. To

[GitHub] [spark] srowen commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds

2019-08-15 Thread GitBox
srowen commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-521745919 I meant both Maven and SBT need the same treatment, to use Java 11 for tests (only). The commented-out

[GitHub] [spark] dongjoon-hyun commented on issue #25466: [MINOR][DOC] Use `Java 8` instead of `Java 8+` as a running environment

2019-08-15 Thread GitBox
dongjoon-hyun commented on issue #25466: [MINOR][DOC] Use `Java 8` instead of `Java 8+` as a running environment URL: https://github.com/apache/spark/pull/25466#issuecomment-521744281 Thank you for review and approval, @srowen . I tested the doc generation and attached the screenshot.

[GitHub] [spark] shaneknapp edited a comment on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds

2019-08-15 Thread GitBox
shaneknapp edited a comment on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-521738315 > Many things going on here. So, we build with Java 8 and test with 11. This should be true for

[GitHub] [spark] shaneknapp commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds

2019-08-15 Thread GitBox
shaneknapp commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-521738315 > Many things going on here. So, we build with Java 8 and test with 11. This should be true for Maven

[GitHub] [spark] srowen commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds

2019-08-15 Thread GitBox
srowen commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-521733832 Many things going on here. So, we build with Java 8 and test with 11. This should be true for Maven and

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25466: [MINOR][DOC] Use `Java 8` instead of `Java 8+` as a running environment

2019-08-15 Thread GitBox
dongjoon-hyun edited a comment on issue #25466: [MINOR][DOC] Use `Java 8` instead of `Java 8+` as a running environment URL: https://github.com/apache/spark/pull/25466#issuecomment-521732815 cc @srowen , @kiszk , @dbtsai , @HyukjinKwon , @gatorsmile , @felixcheung

[GitHub] [spark] dongjoon-hyun commented on issue #25466: [MINOR][DOC] Use `Java 8` instead of `Java 8+` as a running environment

2019-08-15 Thread GitBox
dongjoon-hyun commented on issue #25466: [MINOR][DOC] Use `Java 8` instead of `Java 8+` as a running environment URL: https://github.com/apache/spark/pull/25466#issuecomment-521732815 cc @srowen , @kiszk , @dbtsai , @gatorsmile

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available

2019-08-15 Thread GitBox
dongjoon-hyun edited a comment on issue #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available URL: https://github.com/apache/spark/pull/25460#issuecomment-521731966 Thank you for update, @shahidki31 . Hi, @cloud-fan , @maropu , @wangyum ,

[GitHub] [spark] dongjoon-hyun commented on issue #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available

2019-08-15 Thread GitBox
dongjoon-hyun commented on issue #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available URL: https://github.com/apache/spark/pull/25460#issuecomment-521731966 Thank you for update, @shahidki31 . Hi, @cloud-fan , @maropu , @wangyum , @srowen

[GitHub] [spark] dongjoon-hyun commented on issue #25462: [SPARK-28745][SQL][TEST] Add benchmarks for `extract()`

2019-08-15 Thread GitBox
dongjoon-hyun commented on issue #25462: [SPARK-28745][SQL][TEST] Add benchmarks for `extract()` URL: https://github.com/apache/spark/pull/25462#issuecomment-521729821 Hi, @MaxGekk . I regenerated the result on EC2 and made a PR to you. Could you review and merge that? -

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25462: [SPARK-28745][SQL][TEST] Add benchmarks for `extract()`

2019-08-15 Thread GitBox
dongjoon-hyun commented on a change in pull request #25462: [SPARK-28745][SQL][TEST] Add benchmarks for `extract()` URL: https://github.com/apache/spark/pull/25462#discussion_r314417211 ## File path: sql/core/benchmarks/ExtractBenchmark-results.txt ## @@ -0,0 +1,145 @@

[GitHub] [spark] shahidki31 commented on a change in pull request #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available

2019-08-15 Thread GitBox
shahidki31 commented on a change in pull request #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available URL: https://github.com/apache/spark/pull/25460#discussion_r314416215 ## File path:

[GitHub] [spark] srowen commented on issue #25451: [SPARK-28728][BUILD] Bump Jackson Databind to 2.9.9.3

2019-08-15 Thread GitBox
srowen commented on issue #25451: [SPARK-28728][BUILD] Bump Jackson Databind to 2.9.9.3 URL: https://github.com/apache/spark/pull/25451#issuecomment-521724613 Hm.. that failure looks unrelated, but I don't see it in master, and I see it failed twice the same way. I don't see any

[GitHub] [spark] dongjoon-hyun commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds

2019-08-15 Thread GitBox
dongjoon-hyun commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-521723310 Hi, @shaneknapp . We need to have `\` at the end of `java.version=11`. -

[GitHub] [spark] vanzin closed pull request #24970: [SPARK-23977][SQL] Support High Performance S3A committers [test-hadoop3.2]

2019-08-15 Thread GitBox
vanzin closed pull request #24970: [SPARK-23977][SQL] Support High Performance S3A committers [test-hadoop3.2] URL: https://github.com/apache/spark/pull/24970 This is an automated message from the Apache Git Service. To

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available

2019-08-15 Thread GitBox
dongjoon-hyun commented on a change in pull request #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available URL: https://github.com/apache/spark/pull/25460#discussion_r314407842 ## File path:

[GitHub] [spark] dongjoon-hyun opened a new pull request #25466: [MINOR][DOC] Use `Java 8` instead of `Java 8+` as a running environment

2019-08-15 Thread GitBox
dongjoon-hyun opened a new pull request #25466: [MINOR][DOC] Use `Java 8` instead of `Java 8+` as a running environment URL: https://github.com/apache/spark/pull/25466 ## What changes were proposed in this pull request? This PR aims to remove `+` from `Java 8+` in the documentation

[GitHub] [spark] SparkQA removed a comment on issue #25451: [SPARK-28728][BUILD] Bump Jackson Databind to 2.9.9.3

2019-08-15 Thread GitBox
SparkQA removed a comment on issue #25451: [SPARK-28728][BUILD] Bump Jackson Databind to 2.9.9.3 URL: https://github.com/apache/spark/pull/25451#issuecomment-521687136 **[Test build #4832 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4832/testReport)**

[GitHub] [spark] SparkQA commented on issue #25451: [SPARK-28728][BUILD] Bump Jackson Databind to 2.9.9.3

2019-08-15 Thread GitBox
SparkQA commented on issue #25451: [SPARK-28728][BUILD] Bump Jackson Databind to 2.9.9.3 URL: https://github.com/apache/spark/pull/25451#issuecomment-521717583 **[Test build #4832 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4832/testReport)** for

[GitHub] [spark] shahidki31 commented on a change in pull request #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available

2019-08-15 Thread GitBox
shahidki31 commented on a change in pull request #25460: [SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not available URL: https://github.com/apache/spark/pull/25460#discussion_r314404815 ## File path:

[GitHub] [spark] dongjoon-hyun commented on issue #25229: [SPARK-27900][K8s] Add jvm oom flag

2019-08-15 Thread GitBox
dongjoon-hyun commented on issue #25229: [SPARK-27900][K8s] Add jvm oom flag URL: https://github.com/apache/spark/pull/25229#issuecomment-521714839 Although there was a request, but this is a kind of nice-to-have. I mean this is not a blocker because this is not a regression from 2.4.3. We

[GitHub] [spark] abellina commented on issue #25403: [SPARK-28679][YARN] changes to setResourceInformation to handle empty resources and reflection error handling

2019-08-15 Thread GitBox
abellina commented on issue #25403: [SPARK-28679][YARN] changes to setResourceInformation to handle empty resources and reflection error handling URL: https://github.com/apache/spark/pull/25403#issuecomment-521714176 test this please

[GitHub] [spark] cloud-fan commented on a change in pull request #25348: [SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths

2019-08-15 Thread GitBox
cloud-fan commented on a change in pull request #25348: [SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#discussion_r314397529 ## File path:

[GitHub] [spark] vanzin commented on a change in pull request #25342: [SPARK-28571][CORE][SHUFFLE] Use the shuffle writer plugin for the SortShuffleWriter

2019-08-15 Thread GitBox
vanzin commented on a change in pull request #25342: [SPARK-28571][CORE][SHUFFLE] Use the shuffle writer plugin for the SortShuffleWriter URL: https://github.com/apache/spark/pull/25342#discussion_r314393643 ## File path:

[GitHub] [spark] dongjoon-hyun commented on issue #25462: [SPARK-28745][SQL] Add benchmarks for `extract()`

2019-08-15 Thread GitBox
dongjoon-hyun commented on issue #25462: [SPARK-28745][SQL] Add benchmarks for `extract()` URL: https://github.com/apache/spark/pull/25462#issuecomment-521710204 Thank you for pinging me, @MaxGekk . Sure! This is an

[GitHub] [spark] BestOreo commented on a change in pull request #25342: [SPARK-28571][CORE][SHUFFLE] Use the shuffle writer plugin for the SortShuffleWriter

2019-08-15 Thread GitBox
BestOreo commented on a change in pull request #25342: [SPARK-28571][CORE][SHUFFLE] Use the shuffle writer plugin for the SortShuffleWriter URL: https://github.com/apache/spark/pull/25342#discussion_r314396389 ## File path:

[GitHub] [spark] SparkQA removed a comment on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host

2019-08-15 Thread GitBox
SparkQA removed a comment on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host URL: https://github.com/apache/spark/pull/25299#issuecomment-521674863 **[Test build #4831 has

[GitHub] [spark] BestOreo commented on a change in pull request #25342: [SPARK-28571][CORE][SHUFFLE] Use the shuffle writer plugin for the SortShuffleWriter

2019-08-15 Thread GitBox
BestOreo commented on a change in pull request #25342: [SPARK-28571][CORE][SHUFFLE] Use the shuffle writer plugin for the SortShuffleWriter URL: https://github.com/apache/spark/pull/25342#discussion_r314396389 ## File path:

[GitHub] [spark] SparkQA commented on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host

2019-08-15 Thread GitBox
SparkQA commented on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host URL: https://github.com/apache/spark/pull/25299#issuecomment-521709690 **[Test build #4831 has

[GitHub] [spark] attilapiros commented on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host

2019-08-15 Thread GitBox
attilapiros commented on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host URL: https://github.com/apache/spark/pull/25299#issuecomment-521709371 ok to test This is an

[GitHub] [spark] vanzin commented on issue #24970: [SPARK-23977][SQL] Support High Performance S3A committers [test-hadoop3.2]

2019-08-15 Thread GitBox
vanzin commented on issue #24970: [SPARK-23977][SQL] Support High Performance S3A committers [test-hadoop3.2] URL: https://github.com/apache/spark/pull/24970#issuecomment-521709157 Merging to master. This is an automated

[GitHub] [spark] cloud-fan commented on issue #25368: [SPARK-28635][SQL] create CatalogManager to track registered v2 catalogs

2019-08-15 Thread GitBox
cloud-fan commented on issue #25368: [SPARK-28635][SQL] create CatalogManager to track registered v2 catalogs URL: https://github.com/apache/spark/pull/25368#issuecomment-521708305 retest this please This is an automated

[GitHub] [spark] vanzin commented on a change in pull request #25342: [SPARK-28571][CORE][SHUFFLE] Use the shuffle writer plugin for the SortShuffleWriter

2019-08-15 Thread GitBox
vanzin commented on a change in pull request #25342: [SPARK-28571][CORE][SHUFFLE] Use the shuffle writer plugin for the SortShuffleWriter URL: https://github.com/apache/spark/pull/25342#discussion_r314393643 ## File path:

[GitHub] [spark] gengliangwang commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-15 Thread GitBox
gengliangwang commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-521706706 retest this please. This is an

[GitHub] [spark] cloud-fan commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-15 Thread GitBox
cloud-fan commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-521706641 cc @brkyvz @rdblue @gengliangwang This is an

<    1   2   3   4   5   6   7   8   >