[GitHub] [spark] cloud-fan commented on a change in pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-04-27 Thread GitBox


cloud-fan commented on a change in pull request #28375:
URL: https://github.com/apache/spark/pull/28375#discussion_r416344437



##
File path: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
##
@@ -193,18 +193,16 @@ class HiveCommandSuite extends QueryTest with 
SQLTestUtils with TestHiveSingleto
 checkAnswer(sql("SHOW TBLPROPERTIES parquet_tab2('`prop2Key`')"), 
Row("prop2Val"))
   }
 
-  test("show tblproperties for spark temporary table - AnalysisException is 
thrown") {
+  test("show tblproperties for spark temporary table - empty row") {

Review comment:
   can we move this test to `show-tblproperties.sql` as well?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #28365:
URL: https://github.com/apache/spark/pull/28365#issuecomment-620394587







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on a change in pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-04-27 Thread GitBox


cloud-fan commented on a change in pull request #28375:
URL: https://github.com/apache/spark/pull/28375#discussion_r416343587



##
File path: docs/sql-migration-guide.md
##
@@ -59,7 +59,7 @@ license: |
  
   - In Spark 3.0, you can use `ADD FILE` to add file directories as well. 
Earlier you could add only single files using this command. To restore the 
behavior of earlier versions, set `spark.sql.legacy.addSingleFileInAddFile` to 
`true`.
 
-  - In Spark 3.0, `SHOW TBLPROPERTIES` throws `AnalysisException` if the table 
does not exist. In Spark version 2.4 and below, this scenario caused 
`NoSuchTableException`. Also, `SHOW TBLPROPERTIES` on a temporary view causes 
`AnalysisException`. In Spark version 2.4 and below, it returned an empty 
result.
+  - In Spark 3.0, `SHOW TBLPROPERTIES` throws `AnalysisException` if the table 
does not exist. In Spark version 2.4 and below, this scenario caused 
`NoSuchTableException`.

Review comment:
   maybe we can remove it. Exception class change doesn't worth a migration 
guide item.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-27 Thread GitBox


SparkQA removed a comment on pull request #28365:
URL: https://github.com/apache/spark/pull/28365#issuecomment-620376774


   **[Test build #121956 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121956/testReport)**
 for PR 28365 at commit 
[`06fac7d`](https://github.com/apache/spark/commit/06fac7d8d86de146bbcab3c9c09e5e1256824f97).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-27 Thread GitBox


AmplabJenkins commented on pull request #28365:
URL: https://github.com/apache/spark/pull/28365#issuecomment-620394587







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-27 Thread GitBox


SparkQA commented on pull request #28365:
URL: https://github.com/apache/spark/pull/28365#issuecomment-620394336


   **[Test build #121956 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121956/testReport)**
 for PR 28365 at commit 
[`06fac7d`](https://github.com/apache/spark/commit/06fac7d8d86de146bbcab3c9c09e5e1256824f97).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative t

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #26339:
URL: https://github.com/apache/spark/pull/26339#issuecomment-620391106







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-27 Thread GitBox


AmplabJenkins commented on pull request #26339:
URL: https://github.com/apache/spark/pull/26339#issuecomment-620391106







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-27 Thread GitBox


SparkQA commented on pull request #26339:
URL: https://github.com/apache/spark/pull/26339#issuecomment-620390795


   **[Test build #121959 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121959/testReport)**
 for PR 26339 at commit 
[`4e162c5`](https://github.com/apache/spark/commit/4e162c52def51c712e9c6719cc1582a86bded775).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28380: [SPARK-31587][R][INFRA] Uses R 4.0.0 in Github Actions

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #28380:
URL: https://github.com/apache/spark/pull/28380#issuecomment-620389748


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121943/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28380: [SPARK-31587][R][INFRA] Uses R 4.0.0 in Github Actions

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #28380:
URL: https://github.com/apache/spark/pull/28380#issuecomment-620389743


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28380: [SPARK-31587][R][INFRA] Uses R 4.0.0 in Github Actions

2020-04-27 Thread GitBox


AmplabJenkins commented on pull request #28380:
URL: https://github.com/apache/spark/pull/28380#issuecomment-620389743







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] sarutak commented on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox


sarutak commented on pull request #28359:
URL: https://github.com/apache/spark/pull/28359#issuecomment-620389486


   Ah, I see. Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28380: [SPARK-31587][R][INFRA] Uses R 4.0.0 in Github Actions

2020-04-27 Thread GitBox


SparkQA commented on pull request #28380:
URL: https://github.com/apache/spark/pull/28380#issuecomment-620389349


   **[Test build #121943 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121943/testReport)**
 for PR 28380 at commit 
[`5dc15cd`](https://github.com/apache/spark/commit/5dc15cd08c6ba0acb9b3c486fbc437e8893e18a6).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28380: [SPARK-31587][R][INFRA] Uses R 4.0.0 in Github Actions

2020-04-27 Thread GitBox


SparkQA removed a comment on pull request #28380:
URL: https://github.com/apache/spark/pull/28380#issuecomment-620340283


   **[Test build #121943 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121943/testReport)**
 for PR 28380 at commit 
[`5dc15cd`](https://github.com/apache/spark/commit/5dc15cd08c6ba0acb9b3c486fbc437e8893e18a6).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28367: [SPARK-31573][R] Apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox


AmplabJenkins commented on pull request #28367:
URL: https://github.com/apache/spark/pull/28367#issuecomment-620389185







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28367: [SPARK-31573][R] Apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #28367:
URL: https://github.com/apache/spark/pull/28367#issuecomment-620389185







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox


dongjoon-hyun edited a comment on pull request #28359:
URL: https://github.com/apache/spark/pull/28359#issuecomment-620389265


   Maybe, we need to re-trigger this once more because this will be terminated 
at PST midnight.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28367: [SPARK-31573][R] Apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox


SparkQA removed a comment on pull request #28367:
URL: https://github.com/apache/spark/pull/28367#issuecomment-620376433


   **[Test build #121955 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121955/testReport)**
 for PR 28367 at commit 
[`cb6d263`](https://github.com/apache/spark/commit/cb6d2639805b9ff94a8246fa8f045f4476b4689b).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox


dongjoon-hyun commented on pull request #28359:
URL: https://github.com/apache/spark/pull/28359#issuecomment-620389265


   Maybe, we need to retriever this once more because this will be terminated 
at PST midnight.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28367: [SPARK-31573][R] Apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox


SparkQA commented on pull request #28367:
URL: https://github.com/apache/spark/pull/28367#issuecomment-620388994


   **[Test build #121955 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121955/testReport)**
 for PR 28367 at commit 
[`cb6d263`](https://github.com/apache/spark/commit/cb6d2639805b9ff94a8246fa8f045f4476b4689b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative t

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #26339:
URL: https://github.com/apache/spark/pull/26339#issuecomment-620388306


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121958/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-27 Thread GitBox


AmplabJenkins commented on pull request #26339:
URL: https://github.com/apache/spark/pull/26339#issuecomment-620388303







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative t

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #26339:
URL: https://github.com/apache/spark/pull/26339#issuecomment-620388303


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-27 Thread GitBox


SparkQA removed a comment on pull request #26339:
URL: https://github.com/apache/spark/pull/26339#issuecomment-620386758


   **[Test build #121958 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121958/testReport)**
 for PR 26339 at commit 
[`9c4532e`](https://github.com/apache/spark/commit/9c4532e3c8e81e485435a2f1db8c27c7560d6456).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-27 Thread GitBox


SparkQA commented on pull request #26339:
URL: https://github.com/apache/spark/pull/26339#issuecomment-620388294


   **[Test build #121958 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121958/testReport)**
 for PR 26339 at commit 
[`9c4532e`](https://github.com/apache/spark/commit/9c4532e3c8e81e485435a2f1db8c27c7560d6456).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-27 Thread GitBox


HyukjinKwon commented on pull request #28328:
URL: https://github.com/apache/spark/pull/28328#issuecomment-620387797


   Okay, the more I look, the more it makes me to think we should revert #25754 
rather than adding bandaid fixes. Shall we revert?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27803: [SPARK-31049][SQL] Support nested adjacent generators, e.g., explode(explode(v))

2020-04-27 Thread GitBox


dongjoon-hyun commented on a change in pull request #27803:
URL: https://github.com/apache/spark/pull/27803#discussion_r416334410



##
File path: 
sql/core/src/test/scala/org/apache/spark/sql/GeneratorFunctionSuite.scala
##
@@ -344,12 +345,73 @@ class GeneratorFunctionSuite extends QueryTest with 
SharedSparkSession {
 }
   }
 
+  test("Supported nested inner generators") {

Review comment:
   If you don't mind, `SPARK-31049: ` prefix?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on a change in pull request #28343: [SPARK-31563][SQL] Fix failure of InSet.sql for collections of Catalyst's internal types

2020-04-27 Thread GitBox


cloud-fan commented on a change in pull request #28343:
URL: https://github.com/apache/spark/pull/28343#discussion_r416334206



##
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##
@@ -519,7 +520,9 @@ case class InSet(child: Expression, hset: Set[Any]) extends 
UnaryExpression with
 
   override def sql: String = {
 val valueSQL = child.sql
-val listSQL = hset.toSeq.map(Literal(_).sql).mkString(", ")
+val listSQL = hset.toSeq
+  .map(elem => Literal(convertToScala(elem, child.dataType)).sql)

Review comment:
   this converts the internal value to external value, and then 
`Literal.apply` converts external value to internal value.
   
   Can we just do `Literal(elem, child.dataType).sql`?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-27 Thread GitBox


AmplabJenkins commented on pull request #26339:
URL: https://github.com/apache/spark/pull/26339#issuecomment-620387046







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox


AmplabJenkins commented on pull request #28359:
URL: https://github.com/apache/spark/pull/28359#issuecomment-620386990







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #28359:
URL: https://github.com/apache/spark/pull/28359#issuecomment-620386990







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative t

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #26339:
URL: https://github.com/apache/spark/pull/26339#issuecomment-620387046







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] MichaelChirico commented on pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-27 Thread GitBox


MichaelChirico commented on pull request #28365:
URL: https://github.com/apache/spark/pull/28365#issuecomment-620386789


   Not sure why the Documents task failed, looks like the `roxygen2` part 
succeeded



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox


SparkQA commented on pull request #28359:
URL: https://github.com/apache/spark/pull/28359#issuecomment-620386738


   **[Test build #121957 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121957/testReport)**
 for PR 28359 at commit 
[`90d3dbf`](https://github.com/apache/spark/commit/90d3dbf3aa671280b494a82ee25c0a13a5f532f1).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-27 Thread GitBox


SparkQA commented on pull request #26339:
URL: https://github.com/apache/spark/pull/26339#issuecomment-620386758


   **[Test build #121958 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121958/testReport)**
 for PR 26339 at commit 
[`9c4532e`](https://github.com/apache/spark/commit/9c4532e3c8e81e485435a2f1db8c27c7560d6456).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27803: [SPARK-31049][SQL] Support nested adjacent generators, e.g., explode(explode(v))

2020-04-27 Thread GitBox


dongjoon-hyun commented on a change in pull request #27803:
URL: https://github.com/apache/spark/pull/27803#discussion_r416333033



##
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -2203,13 +2220,41 @@ class Analyzer(
   }.nonEmpty)
 }
 
-private def trimAlias(expr: NamedExpression): Expression = expr match {
+private def trimAlias(expr: Expression): Expression = expr match {
   case UnresolvedAlias(child, _) => child
   case Alias(child, _) => child
   case MultiAlias(child, _) => child
   case _ => expr
 }
 
+private def createGenerate(
+generator: Generator,
+outer: Boolean,
+names: Seq[String],
+child: LogicalPlan): Generate = {
+  Generate(
+generator,
+unrequiredChildIndex = Nil,
+outer = outer,
+qualifier = None,
+generatorOutput = ResolveGenerate.makeGeneratorOutput(generator, 
names),
+child)
+}
+
+private def collectAdjacentGenerators(children: Seq[Expression]): 
Seq[(Generator, Boolean)] = {

Review comment:
   Could you describe the output as a function description, please? For 
example, the purpose of the second boolean in the result pair?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HeartSaVioR edited a comment on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox


HeartSaVioR edited a comment on pull request #28326:
URL: https://github.com/apache/spark/pull/28326#issuecomment-620310834


   Sorry for maybe out-of-topic, but I'm seeing that column metadata may have 
more issues due to not properly defined its usage and how it should be handled.
   
   I'm actually a bit surprised that both Spark and end users co-use metadata 
and can overwrite/hide each other. I thought that's only used internally from 
Spark, and wasn't aware that Spark exposes a public API to modify metadata.
   
   I'm not sure this is really needed to be provided on end users side (or even 
3rd party), because end users (+ 3rd party) would have no way to retrieve 
metadata from only public API. Retrieving metadata in end user's perspective 
requires pattern matching `col.expr` with `NamedExpression` and call `metadata` 
which is already in catalyst area (not a public API), or package hack to call 
`named` method (not a public API). That means, they may just blindly overwrite 
the one and hide the metadata of the underlying attribute. Do we have actual 
usage on it?
   
   Also, as @cloud-fan commented earlier  
https://github.com/apache/spark/pull/28326#issuecomment-619769222, metadata 
propagation doesn't seem to be clearly defined. Alias keeps the metadata being 
propagated, but I'm not sure which other operations consider the metadata 
propagation while considering output of the operation.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] sarutak commented on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox


sarutak commented on pull request #28359:
URL: https://github.com/apache/spark/pull/28359#issuecomment-620385316


   retest this please.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] turboFei commented on a change in pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative ta

2020-04-27 Thread GitBox


turboFei commented on a change in pull request #26339:
URL: https://github.com/apache/spark/pull/26339#discussion_r416331191



##
File path: 
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
##
@@ -236,13 +272,33 @@ class HadoopMapReduceCommitProtocol(
 committer.setupTask(taskContext)
 addedAbsPathFiles = mutable.Map[String, String]()
 partitionPaths = mutable.Set[String]()
+dynamicStagingTaskFiles = mutable.Set[Path]()
   }
 
   override def commitTask(taskContext: TaskAttemptContext): TaskCommitMessage 
= {
 val attemptId = taskContext.getTaskAttemptID
 logTrace(s"Commit task ${attemptId}")
 SparkHadoopMapRedUtil.commitTask(
   committer, taskContext, attemptId.getJobID.getId, 
attemptId.getTaskID.getId)
+if (dynamicPartitionOverwrite) {
+  val fs = stagingDir.getFileSystem(taskContext.getConfiguration)
+  dynamicStagingTaskFiles.foreach { stagingTaskFile =>
+val fileName = stagingTaskFile.getName
+val partitionPath = getDynamicPartitionPath(fs, stagingTaskFile, 
taskContext)
+val finalFile = new Path(partitionPath, fileName)
+if (!fs.exists(finalFile) && !fs.rename(stagingTaskFile, finalFile)) {
+  if (fs.exists(finalFile)) {
+logWarning(
+  s"""
+| Some other task had renamed a staging dynamic file to 
$finalFile.
+| See details in SPARK-29302.
+  """.stripMargin)
+  } else {
+throw new IOException(s"Failed to rename $stagingTaskFile to 
$finalFile")

Review comment:
   I have double checked whether this finalFile exists





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27803: [SPARK-31049][SQL] Support nested adjacent generators, e.g., explode(explode(v))

2020-04-27 Thread GitBox


dongjoon-hyun commented on a change in pull request #27803:
URL: https://github.com/apache/spark/pull/27803#discussion_r416330704



##
File path: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala
##
@@ -425,38 +425,35 @@ class AnalysisErrorSuite extends AnalysisTest {
   TimeWindow(Literal("2016-01-01 01:01:01"), "1 second", "0 second", "0 
second").as("window")),
   "The slide duration" :: " must be greater than 0." :: Nil
   )
-
+"Nested generators are supported only when inner generators " +
+  "are unary and adjacent with single output, but got: "

Review comment:
   Ur, maybe, mistake?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative t

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #26339:
URL: https://github.com/apache/spark/pull/26339#issuecomment-620382242


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121939/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative t

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #26339:
URL: https://github.com/apache/spark/pull/26339#issuecomment-620382236


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-27 Thread GitBox


AmplabJenkins commented on pull request #26339:
URL: https://github.com/apache/spark/pull/26339#issuecomment-620382236







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-27 Thread GitBox


SparkQA commented on pull request #26339:
URL: https://github.com/apache/spark/pull/26339#issuecomment-620381371


   **[Test build #121939 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121939/testReport)**
 for PR 26339 at commit 
[`187e596`](https://github.com/apache/spark/commit/187e5968ab61c2382bdb77cc033bdebc9e30a6b7).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-27 Thread GitBox


SparkQA removed a comment on pull request #26339:
URL: https://github.com/apache/spark/pull/26339#issuecomment-620327086


   **[Test build #121939 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121939/testReport)**
 for PR 26339 at commit 
[`187e596`](https://github.com/apache/spark/commit/187e5968ab61c2382bdb77cc033bdebc9e30a6b7).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on pull request #28384: [SPARK-31589][INFRA][2.4] Use `r-lib/actions/setup-r` in GitHub Action

2020-04-27 Thread GitBox


dongjoon-hyun commented on pull request #28384:
URL: https://github.com/apache/spark/pull/28384#issuecomment-620381258


   cc @holdenk since she is the release manager of 2.4.6.
   (This is just for GitHub Action infra which is irrelevant to our code.)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on pull request #28384: [SPARK-31589][INFRA][2.4] Use `r-lib/actions/setup-r` in GitHub Action

2020-04-27 Thread GitBox


dongjoon-hyun commented on pull request #28384:
URL: https://github.com/apache/spark/pull/28384#issuecomment-620381028


   Merged to branch-2.4 because GitHub Action passed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on pull request #28384: [SPARK-31589][INFRA][2.4] Use `r-lib/actions/setup-r` in GitHub Action

2020-04-27 Thread GitBox


dongjoon-hyun commented on pull request #28384:
URL: https://github.com/apache/spark/pull/28384#issuecomment-620380235


   Thank you, @HyukjinKwon .



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28367: [SPARK-31573][R] Apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #28367:
URL: https://github.com/apache/spark/pull/28367#issuecomment-620376846







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #28365:
URL: https://github.com/apache/spark/pull/28365#issuecomment-620376792







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28384: [SPARK-31589][INFRA][2.4] Use `r-lib/actions/setup-r` in GitHub Action

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #28384:
URL: https://github.com/apache/spark/pull/28384#issuecomment-620376758







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28367: [SPARK-31573][R] Apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox


AmplabJenkins commented on pull request #28367:
URL: https://github.com/apache/spark/pull/28367#issuecomment-620376846







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #28379:
URL: https://github.com/apache/spark/pull/28379#issuecomment-620376811







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-27 Thread GitBox


AmplabJenkins commented on pull request #28379:
URL: https://github.com/apache/spark/pull/28379#issuecomment-620376811







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28384: [SPARK-31589][INFRA][2.4] Use `r-lib/actions/setup-r` in GitHub Action

2020-04-27 Thread GitBox


AmplabJenkins commented on pull request #28384:
URL: https://github.com/apache/spark/pull/28384#issuecomment-620376758







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-27 Thread GitBox


AmplabJenkins commented on pull request #28365:
URL: https://github.com/apache/spark/pull/28365#issuecomment-620376792







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-27 Thread GitBox


SparkQA commented on pull request #28365:
URL: https://github.com/apache/spark/pull/28365#issuecomment-620376774


   **[Test build #121956 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121956/testReport)**
 for PR 28365 at commit 
[`06fac7d`](https://github.com/apache/spark/commit/06fac7d8d86de146bbcab3c9c09e5e1256824f97).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28367: [SPARK-31573][R] Apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox


SparkQA commented on pull request #28367:
URL: https://github.com/apache/spark/pull/28367#issuecomment-620376433


   **[Test build #121955 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121955/testReport)**
 for PR 28367 at commit 
[`cb6d263`](https://github.com/apache/spark/commit/cb6d2639805b9ff94a8246fa8f045f4476b4689b).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-27 Thread GitBox


SparkQA commented on pull request #28379:
URL: https://github.com/apache/spark/pull/28379#issuecomment-620376468


   **[Test build #121954 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121954/testReport)**
 for PR 28379 at commit 
[`9a1ac4f`](https://github.com/apache/spark/commit/9a1ac4ff82f3e15134af40c65bad5f8242f6d7ed).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28384: [SPARK-31589][INFRA][2.4] Use `r-lib/actions/setup-r` in GitHub Action

2020-04-27 Thread GitBox


SparkQA commented on pull request #28384:
URL: https://github.com/apache/spark/pull/28384#issuecomment-620376440


   **[Test build #121953 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121953/testReport)**
 for PR 28384 at commit 
[`67d3423`](https://github.com/apache/spark/commit/67d3423b16b5acc2e8c7875ec2e5641726ec2ea5).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun opened a new pull request #28384: [SPARK-31589][INFRA][2.4] Use `r-lib/actions/setup-r` in GitHub Action

2020-04-27 Thread GitBox


dongjoon-hyun opened a new pull request #28384:
URL: https://github.com/apache/spark/pull/28384


   #27872 # What changes were proposed in this pull request?
   
   This PR aims to use `r-lib/actions/setup-r` because it's more stable and 
maintained by 3rd party.
   
   ### Why are the changes needed?
   
   This will recover the current outage. In addition, this will be more robust 
in the future.
   As of now, this is tested via https://github.com/dongjoon-hyun/spark/pull/17 
.
   
   ### Does this PR introduce any user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Pass the GitHub Actions, especially `Linter R` and `Generate Documents`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on pull request #28382: [SPARK-31589][INFRA] Use `r-lib/actions/setup-r` in GitHub Action

2020-04-27 Thread GitBox


dongjoon-hyun commented on pull request #28382:
URL: https://github.com/apache/spark/pull/28382#issuecomment-620374136


   Thank you. Sure!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28383: [SPARK-31590][SQL] The filter used by Metadata-only queries should not have Unevaluable

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #28383:
URL: https://github.com/apache/spark/pull/28383#issuecomment-620372657


   Can one of the admins verify this patch?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28383: [SPARK-31590][SQL] The filter used by Metadata-only queries should not have Unevaluable

2020-04-27 Thread GitBox


AmplabJenkins commented on pull request #28383:
URL: https://github.com/apache/spark/pull/28383#issuecomment-620372971


   Can one of the admins verify this patch?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #28382: [SPARK-31589][INFRA] Use `r-lib/actions/setup-r` in GitHub Action

2020-04-27 Thread GitBox


HyukjinKwon commented on pull request #28382:
URL: https://github.com/apache/spark/pull/28382#issuecomment-620372660


   It has a conflict against branch-2.4. Can you backport this too 
@dongjoon-hyun?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28383: [SPARK-31590][SQL] The filter used by Metadata-only queries should not have Unevaluable

2020-04-27 Thread GitBox


AmplabJenkins commented on pull request #28383:
URL: https://github.com/apache/spark/pull/28383#issuecomment-620372657


   Can one of the admins verify this patch?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon edited a comment on pull request #28382: [SPARK-31589][INFRA] Use `r-lib/actions/setup-r` in GitHub Action

2020-04-27 Thread GitBox


HyukjinKwon edited a comment on pull request #28382:
URL: https://github.com/apache/spark/pull/28382#issuecomment-620372195


   Merged to master and branch-3.0. Seems we're all good.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #28382: [SPARK-31589][INFRA] Use `r-lib/actions/setup-r` in GitHub Action

2020-04-27 Thread GitBox


HyukjinKwon commented on pull request #28382:
URL: https://github.com/apache/spark/pull/28382#issuecomment-620372195


   Merged to master, branch-3.0, and branch-2.4. Seems we're all good.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cxzl25 opened a new pull request #28383: [SPARK-31590][SQL] The filter used by Metadata-only queries should not have Unevaluable

2020-04-27 Thread GitBox


cxzl25 opened a new pull request #28383:
URL: https://github.com/apache/spark/pull/28383


   ### What changes were proposed in this pull request?
   When the filter used by OptimizeMetadataOnlyQuery is Unevaluable, this rule 
should not be used.
   
   
   ### Why are the changes needed?
   Applying `OptimizeMetadataOnlyQuery` rule will generate `scalar-subquery`.
   Apply the `OptimizeMetadataOnlyQuery` rule again, will get the exception 
`Cannot evaluate expression: scalar-subquery`.
   
   
   ### Does this PR introduce any user-facing change?
   No
   
   ### How was this patch tested?
   add UT



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28382: [SPARK-31589][INFRA] Use `r-lib/actions/setup-r` in GitHub Action

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #28382:
URL: https://github.com/apache/spark/pull/28382#issuecomment-620369428







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #28380: [SPARK-31587][R][INFRA] Uses R 4.0.0 in Github Actions

2020-04-27 Thread GitBox


HyukjinKwon commented on pull request #28380:
URL: https://github.com/apache/spark/pull/28380#issuecomment-620369463


   Closing in favour of https://github.com/apache/spark/pull/28382. We might 
still have to upgrade but the main issue it targets to fix is the build.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28382: [SPARK-31589][INFRA] Use `r-lib/actions/setup-r` in GitHub Action

2020-04-27 Thread GitBox


AmplabJenkins commented on pull request #28382:
URL: https://github.com/apache/spark/pull/28382#issuecomment-620369428







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28382: [SPARK-31589][INFRA] Use `r-lib/actions/setup-r` in GitHub Action

2020-04-27 Thread GitBox


SparkQA commented on pull request #28382:
URL: https://github.com/apache/spark/pull/28382#issuecomment-620369096


   **[Test build #121952 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121952/testReport)**
 for PR 28382 at commit 
[`c6a8b12`](https://github.com/apache/spark/commit/c6a8b12fc3ba58ea95bdca64732fa8934e884f2d).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on pull request #28382: [SPARK-31589][INFRA] Use `r-lib/actions/setup-r` in GitHub Action

2020-04-27 Thread GitBox


dongjoon-hyun commented on pull request #28382:
URL: https://github.com/apache/spark/pull/28382#issuecomment-620368844


   Thank you! I optimized a little by removing `pandoc` from `Linter (R)`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #28382: [SPARK-31589][INFRA] Use `r-lib/actions/setup-r` in GitHub Action

2020-04-27 Thread GitBox


HyukjinKwon commented on pull request #28382:
URL: https://github.com/apache/spark/pull/28382#issuecomment-620368926


   no problem. still lgtm as long as it fixes the build.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28382: [SPARK-31589][INFRA] Use `r-lib/actions/setup-r` in GitHub Action

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #28382:
URL: https://github.com/apache/spark/pull/28382#issuecomment-620367524







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28382: [SPARK-31589][INFRA] Use `r-lib/actions/setup-r` in GitHub Action

2020-04-27 Thread GitBox


AmplabJenkins commented on pull request #28382:
URL: https://github.com/apache/spark/pull/28382#issuecomment-620367524







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28382: [SPARK-31589][INFRA] Use `r-lib/actions/setup-r` in GitHub Action

2020-04-27 Thread GitBox


SparkQA commented on pull request #28382:
URL: https://github.com/apache/spark/pull/28382#issuecomment-620367276


   **[Test build #121951 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121951/testReport)**
 for PR 28382 at commit 
[`88ce87d`](https://github.com/apache/spark/commit/88ce87d1464fb894cfb2fe2e03741d8a8869b392).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun opened a new pull request #28382: [SPARK-31589][INFRA] Use `r-lib/actions/setup-r` in GitHub Action

2020-04-27 Thread GitBox


dongjoon-hyun opened a new pull request #28382:
URL: https://github.com/apache/spark/pull/28382


   
   
   ### What changes were proposed in this pull request?
   
   
   
   ### Why are the changes needed?
   
   
   
   ### Does this PR introduce any user-facing change?
   
   
   
   ### How was this patch tested?
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] turboFei edited a comment on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-27 Thread GitBox


turboFei edited a comment on pull request #26339:
URL: https://github.com/apache/spark/pull/26339#issuecomment-620364051


   also cc @gatorsmile @HyukjinKwon 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] turboFei commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-27 Thread GitBox


turboFei commented on pull request #26339:
URL: https://github.com/apache/spark/pull/26339#issuecomment-620364051


   cc @gatorsmile @HyukjinKwon 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28349: [SPARK-30642][ML][PYSPARK] LinearSVC blockify input vectors

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #28349:
URL: https://github.com/apache/spark/pull/28349#issuecomment-620361494







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28349: [SPARK-30642][ML][PYSPARK] LinearSVC blockify input vectors

2020-04-27 Thread GitBox


AmplabJenkins commented on pull request #28349:
URL: https://github.com/apache/spark/pull/28349#issuecomment-620361494







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28349: [SPARK-30642][ML][PYSPARK] LinearSVC blockify input vectors

2020-04-27 Thread GitBox


SparkQA commented on pull request #28349:
URL: https://github.com/apache/spark/pull/28349#issuecomment-620361153


   **[Test build #121950 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121950/testReport)**
 for PR 28349 at commit 
[`0772834`](https://github.com/apache/spark/commit/0772834b0998df374c2ed9bde487f56b44acb50f).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] zhengruifeng commented on pull request #27947: [SPARK-31182][CORE][ML] PairRDD support aggregateByKeyWithinPartitions

2020-04-27 Thread GitBox


zhengruifeng commented on pull request #27947:
URL: https://github.com/apache/spark/pull/27947#issuecomment-620361131


   I tend to close it, since I can always workaround it. Maybe it is not 
necessary.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #28106: [SPARK-31335][SQL] Add try function support

2020-04-27 Thread GitBox


HyukjinKwon commented on pull request #28106:
URL: https://github.com/apache/spark/pull/28106#issuecomment-620359601


   cc @cloud-fan too



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #28379:
URL: https://github.com/apache/spark/pull/28379#issuecomment-620359085







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #28106: [SPARK-31335][SQL] Add try function support

2020-04-27 Thread GitBox


HyukjinKwon commented on pull request #28106:
URL: https://github.com/apache/spark/pull/28106#issuecomment-620359343


   I'm positive on this function.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-27 Thread GitBox


AmplabJenkins commented on pull request #28379:
URL: https://github.com/apache/spark/pull/28379#issuecomment-620359085







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #26624:
URL: https://github.com/apache/spark/pull/26624#issuecomment-620356578


   Can one of the admins verify this patch?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-27 Thread GitBox


SparkQA commented on pull request #26624:
URL: https://github.com/apache/spark/pull/26624#issuecomment-620358782


   **[Test build #121949 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121949/testReport)**
 for PR 26624 at commit 
[`6c2d27d`](https://github.com/apache/spark/commit/6c2d27d35f70d8705ba359ff6cb68ead2fbad32d).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-27 Thread GitBox


SparkQA commented on pull request #28379:
URL: https://github.com/apache/spark/pull/28379#issuecomment-620358732


   **[Test build #121948 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121948/testReport)**
 for PR 28379 at commit 
[`38aa3e9`](https://github.com/apache/spark/commit/38aa3e9809c6653b0cd5676dd7e49f65ce21c042).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-27 Thread GitBox


AmplabJenkins commented on pull request #26624:
URL: https://github.com/apache/spark/pull/26624#issuecomment-620356578


   Can one of the admins verify this patch?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #26624:
URL: https://github.com/apache/spark/pull/26624#issuecomment-557013179







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] gatorsmile commented on pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-27 Thread GitBox


gatorsmile commented on pull request #26624:
URL: https://github.com/apache/spark/pull/26624#issuecomment-620356250


   ok to test



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-27 Thread GitBox


AmplabJenkins commented on pull request #26624:
URL: https://github.com/apache/spark/pull/26624#issuecomment-620356168


   Can one of the admins verify this patch?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-27 Thread GitBox


AmplabJenkins removed a comment on pull request #28365:
URL: https://github.com/apache/spark/pull/28365#issuecomment-620354920







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-27 Thread GitBox


SparkQA removed a comment on pull request #28365:
URL: https://github.com/apache/spark/pull/28365#issuecomment-620335594


   **[Test build #121941 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121941/testReport)**
 for PR 28365 at commit 
[`b0cf844`](https://github.com/apache/spark/commit/b0cf8447ba38972f19aee7bb5c67c4d4d895c899).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-27 Thread GitBox


AmplabJenkins commented on pull request #28365:
URL: https://github.com/apache/spark/pull/28365#issuecomment-620354920







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



  1   2   3   4   5   6   7   8   9   10   >