[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28373: [SPARK-31580][BUILD] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
dongjoon-hyun commented on a change in pull request #28373: URL: https://github.com/apache/spark/pull/28373#discussion_r416219047 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala ## @@ -320,4 +320,11 @@ class HiveOrcSourceSuite

[GitHub] [spark] SparkQA removed a comment on pull request #28376: [SPARK-31582] [Yarn] Being able to not populate Hadoop classpath

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28376: URL: https://github.com/apache/spark/pull/28376#issuecomment-620281151 **[Test build #121929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121929/testReport)** for PR 28376 at commit

[GitHub] [spark] holdenk commented on pull request #28377: [SPARK-27340][SS][2.4] Alias on TimeWindow expression may cause watermark metadata lost

2020-04-27 Thread GitBox
holdenk commented on pull request #28377: URL: https://github.com/apache/spark/pull/28377#issuecomment-620288941 From a backporting perspective it seems like this is maybe a bug given that `name` doesn't appear to be copying the metadata even without an explicit metadata set. Do I have

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28376: [SPARK-31582] [Yarn] Being able to not populate Hadoop classpath

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28376: URL: https://github.com/apache/spark/pull/28376#issuecomment-620288648 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28376: [SPARK-31582] [Yarn] Being able to not populate Hadoop classpath

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28376: URL: https://github.com/apache/spark/pull/28376#issuecomment-620288648 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28376: [SPARK-31582] [Yarn] Being able to not populate Hadoop classpath

2020-04-27 Thread GitBox
SparkQA commented on pull request #28376: URL: https://github.com/apache/spark/pull/28376#issuecomment-620288495 **[Test build #121929 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121929/testReport)** for PR 28376 at commit

[GitHub] [spark] maropu commented on a change in pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-27 Thread GitBox
maropu commented on a change in pull request #28330: URL: https://github.com/apache/spark/pull/28330#discussion_r416217721 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala ## @@ -394,6 +420,21 @@ class SQLMetricsSuite extends

[GitHub] [spark] maropu commented on a change in pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-27 Thread GitBox
maropu commented on a change in pull request #28330: URL: https://github.com/apache/spark/pull/28330#discussion_r416217018 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala ## @@ -325,34 +325,57 @@ class SQLMetricsSuite extends

[GitHub] [spark] maropu commented on a change in pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-27 Thread GitBox
maropu commented on a change in pull request #28330: URL: https://github.com/apache/spark/pull/28330#discussion_r416216579 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala ## @@ -325,34 +325,57 @@ class SQLMetricsSuite extends

[GitHub] [spark] holdenk commented on a change in pull request #28373: [SPARK-31580][BUILD] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
holdenk commented on a change in pull request #28373: URL: https://github.com/apache/spark/pull/28373#discussion_r416215339 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala ## @@ -320,4 +320,11 @@ class HiveOrcSourceSuite extends

[GitHub] [spark] maropu commented on a change in pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-27 Thread GitBox
maropu commented on a change in pull request #28330: URL: https://github.com/apache/spark/pull/28330#discussion_r416216164 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala ## @@ -325,34 +325,57 @@ class SQLMetricsSuite extends

[GitHub] [spark] maropu commented on a change in pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-27 Thread GitBox
maropu commented on a change in pull request #28330: URL: https://github.com/apache/spark/pull/28330#discussion_r416215945 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala ## @@ -325,34 +325,57 @@ class SQLMetricsSuite extends

[GitHub] [spark] SparkQA commented on pull request #27978: [SPARK-31127][ML] Implement abstract Selector

2020-04-27 Thread GitBox
SparkQA commented on pull request #27978: URL: https://github.com/apache/spark/pull/27978#issuecomment-620286082 **[Test build #121931 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121931/testReport)** for PR 27978 at commit

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28373: [SPARK-31580][BUILD] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
dongjoon-hyun edited a comment on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620285665 Hi, @dbtsai and @holdenk . Could you review this PR? This is an automated message from the

[GitHub] [spark] dongjoon-hyun commented on pull request #28373: [SPARK-31580][BUILD] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
dongjoon-hyun commented on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620285665 Hi, @dbtsai . Could you review this PR? This is an automated message from the Apache Git Service. To

[GitHub] [spark] dongjoon-hyun commented on pull request #28376: [SPARK-31582] [Yarn] Being able to not populate Hadoop classpath

2020-04-27 Thread GitBox
dongjoon-hyun commented on pull request #28376: URL: https://github.com/apache/spark/pull/28376#issuecomment-620284493 Thank you for pinging me, @dbtsai . This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27978: [SPARK-31127][ML] Implement abstract Selector

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #27978: URL: https://github.com/apache/spark/pull/27978#issuecomment-620284142 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #27978: [SPARK-31127][ML] Implement abstract Selector

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #27978: URL: https://github.com/apache/spark/pull/27978#issuecomment-620284142 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28377: [SPARK-27340][SS][2.4] Alias on TimeWindow expression may cause watermark metadata lost

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28377: URL: https://github.com/apache/spark/pull/28377#issuecomment-620284076 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28377: [SPARK-27340][SS][2.4] Alias on TimeWindow expression may cause watermark metadata lost

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28377: URL: https://github.com/apache/spark/pull/28377#issuecomment-620284076 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28377: [SPARK-27340][SS][2.4] Alias on TimeWindow expression may cause watermark metadata lost

2020-04-27 Thread GitBox
dongjoon-hyun edited a comment on pull request #28377: URL: https://github.com/apache/spark/pull/28377#issuecomment-620283666 cc @holdenk since she is the release manager of 2.4.6. Also, cc @dbtsai Without this, we cannot run long running Structure Streaming with State queries

[GitHub] [spark] dongjoon-hyun commented on pull request #28377: [SPARK-27340][SS][2.4] Alias on TimeWindow expression may cause watermark metadata lost

2020-04-27 Thread GitBox
dongjoon-hyun commented on pull request #28377: URL: https://github.com/apache/spark/pull/28377#issuecomment-620283666 cc @holdenk since she is the release manager of 2.4.6. Without this, we cannot run long running Structure Streaming with State queries due to the lack of watermark.

[GitHub] [spark] SparkQA commented on pull request #28377: [SPARK-27340][SS][2.4] Alias on TimeWindow expression may cause watermark metadata lost

2020-04-27 Thread GitBox
SparkQA commented on pull request #28377: URL: https://github.com/apache/spark/pull/28377#issuecomment-620283680 **[Test build #121930 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121930/testReport)** for PR 28377 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
dongjoon-hyun commented on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-620282819 I made a PR and pinged you guys. - https://github.com/apache/spark/pull/28377 This is an automated

[GitHub] [spark] dongjoon-hyun opened a new pull request #28377: [SPARK-27340][SS][2.4] Alias on TimeWindow expression may cause watermark metadata lost

2020-04-27 Thread GitBox
dongjoon-hyun opened a new pull request #28377: URL: https://github.com/apache/spark/pull/28377 Credit to @LiangchangZ and @xuanyuanking , this PR reuses the UT as well as integrate test in #24457. Thanks Liangchang for your solid work. ### What changes were proposed in this pull

[GitHub] [spark] dongjoon-hyun commented on pull request #28377: [SPARK-27340][SS][2.4] Alias on TimeWindow expression may cause watermark metadata lost

2020-04-27 Thread GitBox
dongjoon-hyun commented on pull request #28377: URL: https://github.com/apache/spark/pull/28377#issuecomment-620282622 cc @cloud-fan , @zsxwing , @LiangchangZ , @xuanyuanking , @HeartSaVioR . This is an automated message

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28376: [SPARK-31582] [Yarn] Being able to not populate Hadoop classpath

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28376: URL: https://github.com/apache/spark/pull/28376#issuecomment-620281603 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28371: [SPARK-31577][SQL] Fix case-sensitivity and forward name conflict problems when check name conflicts of CTE relations

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28371: URL: https://github.com/apache/spark/pull/28371#issuecomment-620281505 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #28376: [SPARK-31582] [Yarn] Able to not populate Hadoop classpath

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28376: URL: https://github.com/apache/spark/pull/28376#issuecomment-620281603 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28371: [SPARK-31577][SQL] Fix case-sensitivity and forward name conflict problems when check name conflicts of CTE relations

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28371: URL: https://github.com/apache/spark/pull/28371#issuecomment-620281499 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28371: [SPARK-31577][SQL] Fix case-sensitivity and forward name conflict problems when check name conflicts of CTE relations

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28371: URL: https://github.com/apache/spark/pull/28371#issuecomment-620281499 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28371: [SPARK-31577][SQL] Fix case-sensitivity and forward name conflict problems when check name conflicts of CTE relations

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28371: URL: https://github.com/apache/spark/pull/28371#issuecomment-620091239 **[Test build #121920 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121920/testReport)** for PR 28371 at commit

[GitHub] [spark] SparkQA commented on pull request #28376: [SPARK-31582] [Yarn] Able to not populate Hadoop classpath

2020-04-27 Thread GitBox
SparkQA commented on pull request #28376: URL: https://github.com/apache/spark/pull/28376#issuecomment-620281151 **[Test build #121929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121929/testReport)** for PR 28376 at commit

[GitHub] [spark] SparkQA commented on pull request #28371: [SPARK-31577][SQL] Fix case-sensitivity and forward name conflict problems when check name conflicts of CTE relations

2020-04-27 Thread GitBox
SparkQA commented on pull request #28371: URL: https://github.com/apache/spark/pull/28371#issuecomment-620280857 **[Test build #121920 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121920/testReport)** for PR 28371 at commit

[GitHub] [spark] dbtsai commented on pull request #28376: [SPARK-31582] [Yarn] Able to not populate Hadoop classpath

2020-04-27 Thread GitBox
dbtsai commented on pull request #28376: URL: https://github.com/apache/spark/pull/28376#issuecomment-620280527 cc @vanzin @srowen @dongjoon-hyun This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dbtsai opened a new pull request #28376: [SPARK-31582] [Yarn] Able to not populate Hadoop classpath

2020-04-27 Thread GitBox
dbtsai opened a new pull request #28376: URL: https://github.com/apache/spark/pull/28376 ### What changes were proposed in this pull request? We are adding a new Yarn configuration to not populate hadoop classpath from `yarn.application.classpath` and ``mapreduce.application.classpath`.

[GitHub] [spark] dongjoon-hyun commented on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
dongjoon-hyun commented on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-620278204 Okay. I'll make a PR to save the contributor's time because I was the requestor. This is an automated

[GitHub] [spark] zsxwing edited a comment on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
zsxwing edited a comment on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-620276434 > For `branch-2.4`, shall we talk on the backporting PR? IMO, it's better to discuss here because submitting a backporting PR is not a zero work. It's better to

[GitHub] [spark] zsxwing commented on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
zsxwing commented on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-620276434 > For `branch-2.4`, shall we talk on the backporting PR? IMO, it's better to discuss here because submitting a backporting PR is not a zero work. It's better to make a

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620274163 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
dongjoon-hyun edited a comment on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-620274907 @zsxwing . For `branch-2.4`, shall we talk on the backporting PR? I didn't backport it directly because we need a further discussion about critical bug fix and the

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
dongjoon-hyun edited a comment on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-620274907 @zsxwing . For `branch-2.4`, shall we talk on the backporting PR? I didn't backport it directly because we need a further discussion about critical bug fix and the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620274146 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] dongjoon-hyun commented on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
dongjoon-hyun commented on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-620274907 @zsxwing . For `branch-2.4`, shall we talk on the PR? I didn't backport it directly because we need a further discussion about critical bug fix and the behavior change.

[GitHub] [spark] AmplabJenkins commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620274146 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-27 Thread GitBox
SparkQA commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620273375 **[Test build #121917 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121917/testReport)** for PR 28370 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620078395 **[Test build #121917 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121917/testReport)** for PR 28370 at commit

[GitHub] [spark] HeartSaVioR commented on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
HeartSaVioR commented on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-620272637 Just FYI, looks like the merged commit doesn't reflect the credit properly (not showing as 2 authors) - maybe because of the authorship of the first commit. author and

[GitHub] [spark] zsxwing commented on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
zsxwing commented on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-620270939 Is it safe for a maintenance branch? This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28373: [SPARK-31580][BUILD] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620266159 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28373: [SPARK-31580][BUILD] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620266159 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28373: [SPARK-31580][BUILD] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620162279 **[Test build #121923 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121923/testReport)** for PR 28373 at commit

[GitHub] [spark] SparkQA commented on pull request #28373: [SPARK-31580][BUILD] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
SparkQA commented on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620265114 **[Test build #121923 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121923/testReport)** for PR 28373 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
dongjoon-hyun commented on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-620262595 Also, could you make a backporting PR to branch-2.4 please, @xuanyuanking ? cc @holdenk since she is the release manager for 2.4.6.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28373: [SPARK-31580][BUILD] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620260919 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] dongjoon-hyun commented on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
dongjoon-hyun commented on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-620261253 Thank you, @xuanyuanking , @cloud-fan , @HeartSaVioR . The test passed almost and was time-outed `6 hr 42 min` during the end of Python Tests. In these days, this

[GitHub] [spark] AmplabJenkins commented on pull request #28373: [SPARK-31580][BUILD] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620260919 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28373: [SPARK-31580][BUILD] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
SparkQA commented on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620260494 **[Test build #121928 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121928/testReport)** for PR 28373 at commit

[GitHub] [spark] HeartSaVioR commented on pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-04-27 Thread GitBox
HeartSaVioR commented on pull request #28258: URL: https://github.com/apache/spark/pull/28258#issuecomment-620259362 I'm not that familiar with standalone mode, so assume we would like to make it behave similar with yarn-cluster. How it behaves if supervise option is specified? In

[GitHub] [spark] dongjoon-hyun commented on pull request #28373: [SPARK-31580][BUILD] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
dongjoon-hyun commented on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620258789 Retest this please. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28373: [SPARK-31580][BUILD][test-hive1.2] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620258096 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28373: [SPARK-31580][BUILD][test-hive1.2] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620258096 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28373: [SPARK-31580][BUILD][test-hive1.2] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
SparkQA commented on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620257651 **[Test build #121927 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121927/testReport)** for PR 28373 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28373: [SPARK-31580][BUILD][test-hive1.2] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620255042 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28373: [SPARK-31580][BUILD][test-hive1.2] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620255042 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28373: [SPARK-31580][BUILD][test-hive1.2] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620248626 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28373: [SPARK-31580][BUILD][test-hive1.2] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620248616 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28373: [SPARK-31580][BUILD][test-hive1.2] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620248616 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28373: [SPARK-31580][BUILD][test-hive1.2] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620170277 **[Test build #121924 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121924/testReport)** for PR 28373 at commit

[GitHub] [spark] SparkQA commented on pull request #28373: [SPARK-31580][BUILD][test-hive1.2] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
SparkQA commented on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620248096 **[Test build #121924 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121924/testReport)** for PR 28373 at commit

[GitHub] [spark] HeartSaVioR edited a comment on pull request #28026: [SPARK-31257][SQL] Unify create table syntax

2020-04-27 Thread GitBox
HeartSaVioR edited a comment on pull request #28026: URL: https://github.com/apache/spark/pull/28026#issuecomment-620244166 Simply thinking as user perspective, if we still support `EXTERNAL` keyword on creating table syntax then end users will try to execute the same query they do with

[GitHub] [spark] HeartSaVioR commented on pull request #28026: [SPARK-31257][SQL] Unify create table syntax

2020-04-27 Thread GitBox
HeartSaVioR commented on pull request #28026: URL: https://github.com/apache/spark/pull/28026#issuecomment-620244166 Simply thinking as user perspective, if we still support `EXTERNAL` keyword on creating table syntax then end users will try to execute the same query they do with Hive,

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
HeartSaVioR commented on a change in pull request #28326: URL: https://github.com/apache/spark/pull/28326#discussion_r416137750 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala ## @@ -593,6 +593,17 @@ class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-620223464 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-620223460 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28359: URL: https://github.com/apache/spark/pull/28359#issuecomment-620223720 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28359: URL: https://github.com/apache/spark/pull/28359#issuecomment-620223720 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28359: URL: https://github.com/apache/spark/pull/28359#issuecomment-620220204 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-620223460 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox
SparkQA commented on pull request #28359: URL: https://github.com/apache/spark/pull/28359#issuecomment-620223140 **[Test build #121926 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121926/testReport)** for PR 28359 at commit

[GitHub] [spark] SparkQA commented on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
SparkQA commented on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-620222318 **[Test build #121905 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121905/testReport)** for PR 28326 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-620005507 **[Test build #121905 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121905/testReport)** for PR 28326 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28359: URL: https://github.com/apache/spark/pull/28359#issuecomment-620220080 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28359: URL: https://github.com/apache/spark/pull/28359#issuecomment-620220192 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] dongjoon-hyun commented on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox
dongjoon-hyun commented on pull request #28359: URL: https://github.com/apache/spark/pull/28359#issuecomment-620219816 Retest this please. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins commented on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28359: URL: https://github.com/apache/spark/pull/28359#issuecomment-620220080 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28359: URL: https://github.com/apache/spark/pull/28359#issuecomment-620131504 **[Test build #121922 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121922/testReport)** for PR 28359 at commit

[GitHub] [spark] SparkQA commented on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox
SparkQA commented on pull request #28359: URL: https://github.com/apache/spark/pull/28359#issuecomment-620219430 **[Test build #121922 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121922/testReport)** for PR 28359 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-620216723 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-620216723 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-620037823 **[Test build #121910 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121910/testReport)** for PR 28330 at commit

[GitHub] [spark] SparkQA commented on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-27 Thread GitBox
SparkQA commented on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-620215580 **[Test build #121910 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121910/testReport)** for PR 28330 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28375: URL: https://github.com/apache/spark/pull/28375#issuecomment-620212480 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28375: URL: https://github.com/apache/spark/pull/28375#issuecomment-620212480 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-04-27 Thread GitBox
SparkQA commented on pull request #28375: URL: https://github.com/apache/spark/pull/28375#issuecomment-620211719 **[Test build #121925 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121925/testReport)** for PR 28375 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28355: [SPARK-31565][WEBUI][FOLLOWUP] Add font color setting of DAG-viz for query plan.

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28355: URL: https://github.com/apache/spark/pull/28355#issuecomment-620209505 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] imback82 commented on pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-04-27 Thread GitBox
imback82 commented on pull request #28375: URL: https://github.com/apache/spark/pull/28375#issuecomment-620209520 cc: @cloud-fan @gatorsmile This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins commented on pull request #28355: [SPARK-31565][WEBUI][FOLLOWUP] Add font color setting of DAG-viz for query plan.

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28355: URL: https://github.com/apache/spark/pull/28355#issuecomment-620209505 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28355: [SPARK-31565][WEBUI][FOLLOWUP] Add font color setting of DAG-viz for query plan.

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28355: URL: https://github.com/apache/spark/pull/28355#issuecomment-620020043 **[Test build #121908 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121908/testReport)** for PR 28355 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28371: [SPARK-31577][SQL] Fix case-sensitivity and forward name conflict problems when check name conflicts of CTE relations

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28371: URL: https://github.com/apache/spark/pull/28371#issuecomment-620208929 This is an automated message from the Apache Git Service. To respond to the message, please log on

<    1   2   3   4   5   6   7   8   9   10   >