[GitHub] [spark] AmplabJenkins removed a comment on pull request #28373: [SPARK-31580][BUILD] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620087843 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28371: [SPARK-31577][SQL] Fix various problems when check name conflicts of CTE relations

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28371: URL: https://github.com/apache/spark/pull/28371#issuecomment-620087834 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28373: [SPARK-31580][BUILD] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620087843 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28373: [SPARK-31580][BUILD] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
SparkQA commented on pull request #28373: URL: https://github.com/apache/spark/pull/28373#issuecomment-620087096 **[Test build #121919 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121919/testReport)** for PR 28373 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28371: [SPARK-31577][SQL] Fix various problems when check name conflicts of CTE relations

2020-04-27 Thread GitBox
cloud-fan commented on a change in pull request #28371: URL: https://github.com/apache/spark/pull/28371#discussion_r415953305 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala ## @@ -41,34 +43,45 @@ object CTESubstitution

[GitHub] [spark] dongjoon-hyun opened a new pull request #28373: [SPARK-31580][BUILD] Upgrade Apache ORC to 1.5.10

2020-04-27 Thread GitBox
dongjoon-hyun opened a new pull request #28373: URL: https://github.com/apache/spark/pull/28373 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce any user-facing change? ###

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28371: [SPARK-31577][SQL] Fix various problems when check name conflicts of CTE relations

2020-04-27 Thread GitBox
dongjoon-hyun commented on a change in pull request #28371: URL: https://github.com/apache/spark/pull/28371#discussion_r415948760 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala ## @@ -41,34 +43,45 @@ object

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28372: URL: https://github.com/apache/spark/pull/28372#issuecomment-620083477 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28372: URL: https://github.com/apache/spark/pull/28372#issuecomment-620083477 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28367: [SPARK-31573][R] Apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28367: URL: https://github.com/apache/spark/pull/28367#issuecomment-620046527 **[Test build #121912 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121912/testReport)** for PR 28367 at commit

[GitHub] [spark] SparkQA commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

2020-04-27 Thread GitBox
SparkQA commented on pull request #28372: URL: https://github.com/apache/spark/pull/28372#issuecomment-620082803 **[Test build #121918 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121918/testReport)** for PR 28372 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28367: [SPARK-31573][R] Apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28367: URL: https://github.com/apache/spark/pull/28367#issuecomment-620082213 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28367: [SPARK-31573][R] Apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28367: URL: https://github.com/apache/spark/pull/28367#issuecomment-620082213 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28367: [SPARK-31573][R] Apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox
SparkQA commented on pull request #28367: URL: https://github.com/apache/spark/pull/28367#issuecomment-620081914 **[Test build #121912 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121912/testReport)** for PR 28367 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620079338 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28371: [SPARK-31577][SQL] Fix various problems when check name conflicts of CTE relations

2020-04-27 Thread GitBox
dongjoon-hyun commented on a change in pull request #28371: URL: https://github.com/apache/spark/pull/28371#discussion_r415944837 ## File path: sql/core/src/test/resources/sql-tests/results/cte-nested.sql.out ## @@ -64,10 +64,9 @@ WITH ) SELECT * FROM t2 -- !query schema

[GitHub] [spark] AmplabJenkins commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620079338 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-27 Thread GitBox
SparkQA commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620078395 **[Test build #121917 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121917/testReport)** for PR 28370 at commit

[GitHub] [spark] holdenk removed a comment on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-27 Thread GitBox
holdenk removed a comment on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620077765 Jenkins ok time test This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] holdenk commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-27 Thread GitBox
holdenk commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620077765 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28215: [SPARK-31272][SQL] Support DB2 Kerberos login in JDBC connector

2020-04-27 Thread GitBox
dongjoon-hyun edited a comment on pull request #28215: URL: https://github.com/apache/spark/pull/28215#issuecomment-620077438 Thank you, @gaborgsomogyi . This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] dongjoon-hyun commented on pull request #28215: [SPARK-31272][SQL] Support DB2 Kerberos login in JDBC connector

2020-04-27 Thread GitBox
dongjoon-hyun commented on pull request #28215: URL: https://github.com/apache/spark/pull/28215#issuecomment-620077438 Thank you, @gaborgsomogyi . I'll try to lower my DockerDesktop version. This is an automated message from

[GitHub] [spark] dongjoon-hyun commented on pull request #28215: [SPARK-31272][SQL] Support DB2 Kerberos login in JDBC connector

2020-04-27 Thread GitBox
dongjoon-hyun commented on pull request #28215: URL: https://github.com/apache/spark/pull/28215#issuecomment-620077120 Thank you, @maropu ! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dongjoon-hyun commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-27 Thread GitBox
dongjoon-hyun commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620076140 ok to test This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-619996941 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] peter-toth commented on pull request #28371: [SPARK-31577][SQL] Fix various problems when check name conflicts of CTE relations

2020-04-27 Thread GitBox
peter-toth commented on pull request #28371: URL: https://github.com/apache/spark/pull/28371#issuecomment-620074663 That flag is a nice trick so LGTM, I just left a minor note. The other 2 fixes also look good. This

[GitHub] [spark] peter-toth commented on a change in pull request #28371: [SPARK-31577][SQL] Fix various problems when check name conflicts of CTE relations

2020-04-27 Thread GitBox
peter-toth commented on a change in pull request #28371: URL: https://github.com/apache/spark/pull/28371#discussion_r415932806 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala ## @@ -41,34 +43,45 @@ object CTESubstitution

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28372: URL: https://github.com/apache/spark/pull/28372#issuecomment-620068253 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28372: URL: https://github.com/apache/spark/pull/28372#issuecomment-620068244 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28372: URL: https://github.com/apache/spark/pull/28372#issuecomment-620060135 **[Test build #121915 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121915/testReport)** for PR 28372 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28372: URL: https://github.com/apache/spark/pull/28372#issuecomment-620068244 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

2020-04-27 Thread GitBox
SparkQA commented on pull request #28372: URL: https://github.com/apache/spark/pull/28372#issuecomment-620068202 **[Test build #121915 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121915/testReport)** for PR 28372 at commit

[GitHub] [spark] akshatb1 commented on pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-04-27 Thread GitBox
akshatb1 commented on pull request #28258: URL: https://github.com/apache/spark/pull/28258#issuecomment-620066867 Could someone kindly review these changes? CC: @cloud-fan @srowen @Ngone51 @HeartSaVioR This is an

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28372: URL: https://github.com/apache/spark/pull/28372#issuecomment-620060954 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28194: URL: https://github.com/apache/spark/pull/28194#issuecomment-620060887 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28372: URL: https://github.com/apache/spark/pull/28372#issuecomment-620060954 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28194: URL: https://github.com/apache/spark/pull/28194#issuecomment-620060887 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #28368: [SPARK-31575][SQL] Synchronise global JVM security configuration modification

2020-04-27 Thread GitBox
gaborgsomogyi commented on a change in pull request #28368: URL: https://github.com/apache/spark/pull/28368#discussion_r415916202 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/DB2ConnectionProvider.scala ## @@ -48,7 +48,7 @@

[GitHub] [spark] SparkQA commented on pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-27 Thread GitBox
SparkQA commented on pull request #28194: URL: https://github.com/apache/spark/pull/28194#issuecomment-620060152 **[Test build #121916 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121916/testReport)** for PR 28194 at commit

[GitHub] [spark] SparkQA commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

2020-04-27 Thread GitBox
SparkQA commented on pull request #28372: URL: https://github.com/apache/spark/pull/28372#issuecomment-620060135 **[Test build #121915 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121915/testReport)** for PR 28372 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-620058835 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-620058835 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-619863720 **[Test build #121898 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121898/testReport)** for PR 28109 at commit

[GitHub] [spark] SparkQA commented on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-27 Thread GitBox
SparkQA commented on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-620057253 **[Test build #121898 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121898/testReport)** for PR 28109 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28372: URL: https://github.com/apache/spark/pull/28372#issuecomment-620055599 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28372: URL: https://github.com/apache/spark/pull/28372#issuecomment-620056207 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28372: URL: https://github.com/apache/spark/pull/28372#issuecomment-620055491 **[Test build #121913 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121913/testReport)** for PR 28372 at commit

[GitHub] [spark] beliefer commented on a change in pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-27 Thread GitBox
beliefer commented on a change in pull request #28194: URL: https://github.com/apache/spark/pull/28194#discussion_r415909194 ## File path: sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28372: URL: https://github.com/apache/spark/pull/28372#issuecomment-620055589 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

2020-04-27 Thread GitBox
SparkQA commented on pull request #28372: URL: https://github.com/apache/spark/pull/28372#issuecomment-620055491 **[Test build #121913 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121913/testReport)** for PR 28372 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28372: URL: https://github.com/apache/spark/pull/28372#issuecomment-620055589 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-27 Thread GitBox
SparkQA commented on pull request #28194: URL: https://github.com/apache/spark/pull/28194#issuecomment-620055515 **[Test build #121914 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121914/testReport)** for PR 28194 at commit

[GitHub] [spark] SparkQA commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

2020-04-27 Thread GitBox
SparkQA commented on pull request #28372: URL: https://github.com/apache/spark/pull/28372#issuecomment-620055571 **[Test build #121913 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121913/testReport)** for PR 28372 at commit

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #28368: [SPARK-31575][SQL] Synchronise global JVM security configuration modification

2020-04-27 Thread GitBox
gaborgsomogyi commented on a change in pull request #28368: URL: https://github.com/apache/spark/pull/28368#discussion_r415908662 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/DB2ConnectionProvider.scala ## @@ -48,7 +48,7 @@

[GitHub] [spark] MichaelChirico opened a new pull request #28372: [R] vectorize schema validation for arrow in types.R

2020-04-27 Thread GitBox
MichaelChirico opened a new pull request #28372: URL: https://github.com/apache/spark/pull/28372 ### What changes were proposed in this pull request? Repeated `sapply` avoided in internal `checkSchemaInArrow` ### Why are the changes needed? Current

[GitHub] [spark] AmplabJenkins commented on pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28194: URL: https://github.com/apache/spark/pull/28194#issuecomment-620051756 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28194: URL: https://github.com/apache/spark/pull/28194#issuecomment-620051756 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28367: [SPARK-31573][R] Apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28367: URL: https://github.com/apache/spark/pull/28367#issuecomment-620047275 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28367: [SPARK-31573][R] Apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28367: URL: https://github.com/apache/spark/pull/28367#issuecomment-620047275 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] beliefer commented on a change in pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-27 Thread GitBox
beliefer commented on a change in pull request #28194: URL: https://github.com/apache/spark/pull/28194#discussion_r415883779 ## File path: sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] SparkQA commented on pull request #28367: [SPARK-31573][R] Apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox
SparkQA commented on pull request #28367: URL: https://github.com/apache/spark/pull/28367#issuecomment-620046527 **[Test build #121912 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121912/testReport)** for PR 28367 at commit

[GitHub] [spark] MichaelChirico commented on a change in pull request #28367: [SPARK-31573][R] Apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox
MichaelChirico commented on a change in pull request #28367: URL: https://github.com/apache/spark/pull/28367#discussion_r415894560 ## File path: R/pkg/R/SQLContext.R ## @@ -110,10 +110,11 @@ sparkR.conf <- function(key, defaultValue) { value <- if (missing(defaultValue))

[GitHub] [spark] MichaelChirico commented on a change in pull request #28367: [SPARK-31573][R] Apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox
MichaelChirico commented on a change in pull request #28367: URL: https://github.com/apache/spark/pull/28367#discussion_r415894560 ## File path: R/pkg/R/SQLContext.R ## @@ -110,10 +110,11 @@ sparkR.conf <- function(key, defaultValue) { value <- if (missing(defaultValue))

[GitHub] [spark] MichaelChirico commented on a change in pull request #28367: [SPARK-31573][R] Apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox
MichaelChirico commented on a change in pull request #28367: URL: https://github.com/apache/spark/pull/28367#discussion_r415892363 ## File path: R/pkg/R/SQLContext.R ## @@ -110,10 +110,11 @@ sparkR.conf <- function(key, defaultValue) { value <- if (missing(defaultValue))

[GitHub] [spark] MichaelChirico commented on a change in pull request #28367: [SPARK-31573][R] Apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox
MichaelChirico commented on a change in pull request #28367: URL: https://github.com/apache/spark/pull/28367#discussion_r415892363 ## File path: R/pkg/R/SQLContext.R ## @@ -110,10 +110,11 @@ sparkR.conf <- function(key, defaultValue) { value <- if (missing(defaultValue))

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28194: URL: https://github.com/apache/spark/pull/28194#issuecomment-620043059 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28194: URL: https://github.com/apache/spark/pull/28194#issuecomment-620043059 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-27 Thread GitBox
SparkQA commented on pull request #28194: URL: https://github.com/apache/spark/pull/28194#issuecomment-620042232 **[Test build #121911 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121911/testReport)** for PR 28194 at commit

[GitHub] [spark] huaxingao commented on pull request #28360: [SPARK-31569][SQL][DOCS] Add links to subsections in SQL Reference main page

2020-04-27 Thread GitBox
huaxingao commented on pull request #28360: URL: https://github.com/apache/spark/pull/28360#issuecomment-620039845 Thanks! @srowen @maropu This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] beliefer commented on a change in pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-27 Thread GitBox
beliefer commented on a change in pull request #28194: URL: https://github.com/apache/spark/pull/28194#discussion_r415885719 ## File path: sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-620038549 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] beliefer commented on a change in pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-27 Thread GitBox
beliefer commented on a change in pull request #28194: URL: https://github.com/apache/spark/pull/28194#discussion_r415884258 ## File path: sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] AmplabJenkins commented on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-620038549 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] beliefer commented on a change in pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-27 Thread GitBox
beliefer commented on a change in pull request #28194: URL: https://github.com/apache/spark/pull/28194#discussion_r415883779 ## File path: sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] sririshindra commented on a change in pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-27 Thread GitBox
sririshindra commented on a change in pull request #28330: URL: https://github.com/apache/spark/pull/28330#discussion_r415882589 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala ## @@ -341,6 +341,62 @@ class SQLMetricsSuite

[GitHub] [spark] SparkQA commented on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-27 Thread GitBox
SparkQA commented on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-620037823 **[Test build #121910 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121910/testReport)** for PR 28330 at commit

[GitHub] [spark] srowen commented on pull request #28360: [SPARK-31569][SQL][DOCS] Add links to subsections in SQL Reference main page

2020-04-27 Thread GitBox
srowen commented on pull request #28360: URL: https://github.com/apache/spark/pull/28360#issuecomment-620032748 Merged to master/3.0 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-620025123 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-620025123 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-620024198 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-27 Thread GitBox
SparkQA commented on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-620024217 **[Test build #121909 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121909/testReport)** for PR 28330 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-620024198 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] sririshindra commented on a change in pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-27 Thread GitBox
sririshindra commented on a change in pull request #28330: URL: https://github.com/apache/spark/pull/28330#discussion_r415861439 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala ## @@ -547,9 +590,9 @@ class SQLMetricsSuite

[GitHub] [spark] SparkQA removed a comment on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-619846231 **[Test build #121893 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121893/testReport)** for PR 28109 at commit

[GitHub] [spark] SparkQA commented on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-27 Thread GitBox
SparkQA commented on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-620022321 **[Test build #121893 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121893/testReport)** for PR 28109 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
cloud-fan commented on a change in pull request #28326: URL: https://github.com/apache/spark/pull/28326#discussion_r415859659 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ## @@ -1040,17 +1034,11 @@ class Column(val expr: Expression) extends Logging {

[GitHub] [spark] SparkQA commented on pull request #28355: [SPARK-31565][WEBUI][FOLLOWUP] Add font color setting of DAG-viz for query plan.

2020-04-27 Thread GitBox
SparkQA commented on pull request #28355: URL: https://github.com/apache/spark/pull/28355#issuecomment-620020043 **[Test build #121908 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121908/testReport)** for PR 28355 at commit

[GitHub] [spark] SparkQA commented on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox
SparkQA commented on pull request #28359: URL: https://github.com/apache/spark/pull/28359#issuecomment-620019970 **[Test build #121907 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121907/testReport)** for PR 28359 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28359: URL: https://github.com/apache/spark/pull/28359#issuecomment-620016355 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28355: [SPARK-31565][WEBUI][FOLLOWUP] Add font color setting of DAG-viz for query plan.

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28355: URL: https://github.com/apache/spark/pull/28355#issuecomment-620016309 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28359: URL: https://github.com/apache/spark/pull/28359#issuecomment-620016355 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28355: [SPARK-31565][WEBUI][FOLLOWUP] Add font color setting of DAG-viz for query plan.

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28355: URL: https://github.com/apache/spark/pull/28355#issuecomment-620016298 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28355: [SPARK-31565][WEBUI][FOLLOWUP] Add font color setting of DAG-viz for query plan.

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28355: URL: https://github.com/apache/spark/pull/28355#issuecomment-620016298 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] sarutak commented on pull request #28355: [SPARK-31565][WEBUI][FOLLOWUP] Add font color setting of DAG-viz for query plan.

2020-04-27 Thread GitBox
sarutak commented on pull request #28355: URL: https://github.com/apache/spark/pull/28355#issuecomment-620015779 retest this please. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] sarutak commented on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox
sarutak commented on pull request #28359: URL: https://github.com/apache/spark/pull/28359#issuecomment-620015543 retest this please. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] xuanyuanking commented on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
xuanyuanking commented on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-620013841 Change the approach to delete the metadata propagating logic in Column in 05ed338. At first, I just followed the `name` API meaning and do the fix in analyzer rule.

[GitHub] [spark] AmplabJenkins commented on pull request #28371: [SPARK-31577][SQL] Fix various problems when check name conflicts of CTE relations

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28371: URL: https://github.com/apache/spark/pull/28371#issuecomment-620011435 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28371: [SPARK-31577][SQL] Fix various problems when check name conflicts of CTE relations

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28371: URL: https://github.com/apache/spark/pull/28371#issuecomment-620011435 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28371: [SPARK-31577][SQL] Fix various problems when check name conflicts of CTE relations

2020-04-27 Thread GitBox
SparkQA commented on pull request #28371: URL: https://github.com/apache/spark/pull/28371#issuecomment-620010568 **[Test build #121906 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121906/testReport)** for PR 28371 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-620006474 This is an automated message from the Apache Git Service. To respond to the message, please log on

<    1   2   3   4   5   6   7   8   9   10   >