[GitHub] [spark] SparkQA commented on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-27 Thread GitBox
SparkQA commented on pull request #28359: URL: https://github.com/apache/spark/pull/28359#issuecomment-619775334 **[Test build #121871 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121871/testReport)** for PR 28359 at commit

[GitHub] [spark] SparkQA commented on pull request #28361: [SPARK-31572][SQL][CORE] Improve task logs at executor side

2020-04-27 Thread GitBox
SparkQA commented on pull request #28361: URL: https://github.com/apache/spark/pull/28361#issuecomment-619775337 **[Test build #121879 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121879/testReport)** for PR 28361 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-619772432 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-619772432 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

2020-04-27 Thread GitBox
SparkQA commented on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-619771694 **[Test build #121880 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121880/testReport)** for PR 28294 at commit

[GitHub] [spark] cloud-fan commented on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

2020-04-27 Thread GitBox
cloud-fan commented on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-619770032 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-27 Thread GitBox
SparkQA commented on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619768706 **[Test build #121877 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121877/testReport)** for PR 28350 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619768933 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] Ngone51 commented on pull request #28357: [SPARK-31485][CORE][2.4] Avoid application hang if only partial barrier tasks launched

2020-04-27 Thread GitBox
Ngone51 commented on pull request #28357: URL: https://github.com/apache/spark/pull/28357#issuecomment-619769082 thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619749330 **[Test build #121877 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121877/testReport)** for PR 28350 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619768933 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
cloud-fan commented on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-619769222 Seems we don't have any rule for column metadata propagation. Each `Attribute`/`Alias` has its own metadata and can easily be hidden by the outer-most `Alias`. The

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28361: [SPARK-31572][SQL][CORE] Improve task logs at executor side

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28361: URL: https://github.com/apache/spark/pull/28361#issuecomment-619768274 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28361: [SPARK-31572][SQL][CORE] Improve task logs at executor side

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28361: URL: https://github.com/apache/spark/pull/28361#issuecomment-619768274 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] yaooqinn commented on pull request #28055: [SPARK-31289][TEST][test-hive1.2] Eliminate org.apache.spark.sql.hive.thriftserver.CliSuite flakiness

2020-04-27 Thread GitBox
yaooqinn commented on pull request #28055: URL: https://github.com/apache/spark/pull/28055#issuecomment-619768035 The bellow test failed naturally on my local machine without manual intervention. So, the flakiness is still there in the master branch with a lower opportunity. ```scala

[GitHub] [spark] SparkQA commented on pull request #28361: [SPARK-31572][SQL][CORE] Improve task logs at executor side

2020-04-27 Thread GitBox
SparkQA commented on pull request #28361: URL: https://github.com/apache/spark/pull/28361#issuecomment-619767826 **[Test build #121879 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121879/testReport)** for PR 28361 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-619765889 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-619765879 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-619687180 **[Test build #121864 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121864/testReport)** for PR 28294 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-619765879 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] yaooqinn commented on pull request #28055: [SPARK-31289][TEST][test-hive1.2] Eliminate org.apache.spark.sql.hive.thriftserver.CliSuite flakiness

2020-04-27 Thread GitBox
yaooqinn commented on pull request #28055: URL: https://github.com/apache/spark/pull/28055#issuecomment-619765532 I set the metastore to temporarily unwritable(But I don't know whether this is the exact error happened on the Jenkins), the tests can be delayed for a long period ``` -

[GitHub] [spark] SparkQA commented on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

2020-04-27 Thread GitBox
SparkQA commented on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-619765510 **[Test build #121864 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121864/testReport)** for PR 28294 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #27617: URL: https://github.com/apache/spark/pull/27617#issuecomment-619764455 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] Ngone51 opened a new pull request #28361: [SPARK-31572][SQL][CORE] Improve task logs at executor side

2020-04-27 Thread GitBox
Ngone51 opened a new pull request #28361: URL: https://github.com/apache/spark/pull/28361 ### What changes were proposed in this pull request? - Make the task name in executor be consistent with dirver - add more logs, especially for spill. ### Why are

[GitHub] [spark] AmplabJenkins commented on pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #27617: URL: https://github.com/apache/spark/pull/27617#issuecomment-619764455 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils

2020-04-27 Thread GitBox
SparkQA commented on pull request #27617: URL: https://github.com/apache/spark/pull/27617#issuecomment-619763635 **[Test build #121878 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121878/testReport)** for PR 27617 at commit

[GitHub] [spark] sarutak edited a comment on pull request #28355: [SPARK-31565][WEBUI][FOLLOWUP] Add font color setting of DAG-viz for query plan.

2020-04-27 Thread GitBox
sarutak edited a comment on pull request #28355: URL: https://github.com/apache/spark/pull/28355#issuecomment-619759908 @dongjoon-hyun Thanks for checking. The appearance you mention is intentional so I've updated the description.

[GitHub] [spark] sarutak commented on pull request #28355: [SPARK-31565][WEBUI][FOLLOWUP] Add font color setting of DAG-viz for query plan.

2020-04-27 Thread GitBox
sarutak commented on pull request #28355: URL: https://github.com/apache/spark/pull/28355#issuecomment-619759908 @dongjoon-hyun Thanks for checking. The behavior you mention is intentional so I've updated the description.

[GitHub] [spark] yaooqinn edited a comment on pull request #28055: [SPARK-31289][TEST][test-hive1.2] Eliminate org.apache.spark.sql.hive.thriftserver.CliSuite flakiness

2020-04-27 Thread GitBox
yaooqinn edited a comment on pull request #28055: URL: https://github.com/apache/spark/pull/28055#issuecomment-619757377 The results only indicate that a shared metastore environment can speed up the test about 30 seconds when there is no error to block each test process to shutdown

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28358: [WIP][SPARK-31567][R][TESTS] Update AppVeyor R version to 4.0.0

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28358: URL: https://github.com/apache/spark/pull/28358#issuecomment-619756840 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] yaooqinn commented on pull request #28055: [SPARK-31289][TEST][test-hive1.2] Eliminate org.apache.spark.sql.hive.thriftserver.CliSuite flakiness

2020-04-27 Thread GitBox
yaooqinn commented on pull request #28055: URL: https://github.com/apache/spark/pull/28055#issuecomment-619757377 The results only indicate that a shared metastore environment can speed up the test about 30 seconds when there is no error to block each test process to shutdown themselves

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28358: [WIP][SPARK-31567][R][TESTS] Update AppVeyor R version to 4.0.0

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28358: URL: https://github.com/apache/spark/pull/28358#issuecomment-619756831 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28358: [WIP][SPARK-31567][R][TESTS] Update AppVeyor R version to 4.0.0

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28358: URL: https://github.com/apache/spark/pull/28358#issuecomment-619756831 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28358: [WIP][SPARK-31567][R][TESTS] Update AppVeyor R version to 4.0.0

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28358: URL: https://github.com/apache/spark/pull/28358#issuecomment-619692058 **[Test build #121865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121865/testReport)** for PR 28358 at commit

[GitHub] [spark] SparkQA commented on pull request #28358: [WIP][SPARK-31567][R][TESTS] Update AppVeyor R version to 4.0.0

2020-04-27 Thread GitBox
SparkQA commented on pull request #28358: URL: https://github.com/apache/spark/pull/28358#issuecomment-619756199 **[Test build #121865 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121865/testReport)** for PR 28358 at commit

[GitHub] [spark] cloud-fan commented on pull request #28055: [SPARK-31289][TEST][test-hive1.2] Eliminate org.apache.spark.sql.hive.thriftserver.CliSuite flakiness

2020-04-27 Thread GitBox
cloud-fan commented on pull request #28055: URL: https://github.com/apache/spark/pull/28055#issuecomment-619755104 so you mean this PR can speed up the `CliSuite` by 30 seconds? This is an automated message from the Apache

[GitHub] [spark] cloud-fan commented on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-27 Thread GitBox
cloud-fan commented on pull request #28328: URL: https://github.com/apache/spark/pull/28328#issuecomment-619753268 cc @viirya , this is another instance that merging `InSet` and `Set` can fix the issue. This is an automated

[GitHub] [spark] huaxingao commented on pull request #28360: [SPARK-31569][SQL][DOCS] Add links to subsections in SQL Reference main page

2020-04-27 Thread GitBox
huaxingao commented on pull request #28360: URL: https://github.com/apache/spark/pull/28360#issuecomment-619752710 cc @maropu @srowen This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HeartSaVioR edited a comment on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
HeartSaVioR edited a comment on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-619751876 > Sometimes we have to, for example, a + b as c, what should be the metadata of c? The metadata of expression for `a + b` if there's no explicit set of

[GitHub] [spark] HeartSaVioR edited a comment on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
HeartSaVioR edited a comment on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-619751876 > Sometimes we have to, for example, a + b as c, what should be the metadata of c? The metadata of expression for `a + b` if there's no explicit set of

[GitHub] [spark] HeartSaVioR commented on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
HeartSaVioR commented on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-619751876 > Sometimes we have to, for example, a + b as c, what should be the metadata of c? The metadata of expression for `a + b` if there's no explicit set of metadata.

[GitHub] [spark] yaooqinn commented on pull request #28055: [SPARK-31289][TEST][test-hive1.2] Eliminate org.apache.spark.sql.hive.thriftserver.CliSuite flakiness

2020-04-27 Thread GitBox
yaooqinn commented on pull request #28055: URL: https://github.com/apache/spark/pull/28055#issuecomment-619751839 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] cloud-fan commented on pull request #26921: [SPARK-30282][SQL] Migrate SHOW TBLPROPERTIES to new framework

2020-04-27 Thread GitBox
cloud-fan commented on pull request #26921: URL: https://github.com/apache/spark/pull/26921#issuecomment-619751442 It's unfortunate that many TABLE commands in Spark support view as well. We need to be careful when we migrate commands to v2 later. @imback82 can you send a PR to make

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28360: [SPARK-31569][SQL][DOCS] Add links to subsections in SQL Reference main page

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28360: URL: https://github.com/apache/spark/pull/28360#issuecomment-619749476 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28360: [SPARK-31569][SQL][DOCS] Add links to subsections in SQL Reference main page

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28360: URL: https://github.com/apache/spark/pull/28360#issuecomment-619741862 **[Test build #121876 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121876/testReport)** for PR 28360 at commit

[GitHub] [spark] cloud-fan commented on pull request #13490: [SPARK-15722][SQL] Disallow specifying schema in CTAS statement

2020-04-27 Thread GitBox
cloud-fan commented on pull request #13490: URL: https://github.com/apache/spark/pull/13490#issuecomment-619750268 Can you point out which database supports this? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619750005 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619750005 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] dongjoon-hyun commented on pull request #28355: [SPARK-31565][WEBUI][FOLLOWUP] Add font color setting of DAG-viz for query plan.

2020-04-27 Thread GitBox
dongjoon-hyun commented on pull request #28355: URL: https://github.com/apache/spark/pull/28355#issuecomment-619749470 @sarutak . I checked the `WholeStageCodegen (1)` is changed from `#00` to `#33` correctly. In the same way, the text below `WholeStageCodegen (1)` like the

[GitHub] [spark] AmplabJenkins commented on pull request #28360: [SPARK-31569][SQL][DOCS] Add links to subsections in SQL Reference main page

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28360: URL: https://github.com/apache/spark/pull/28360#issuecomment-619749476 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-27 Thread GitBox
SparkQA commented on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619749330 **[Test build #121877 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121877/testReport)** for PR 28350 at commit

[GitHub] [spark] SparkQA commented on pull request #28360: [SPARK-31569][SQL][DOCS] Add links to subsections in SQL Reference main page

2020-04-27 Thread GitBox
SparkQA commented on pull request #28360: URL: https://github.com/apache/spark/pull/28360#issuecomment-619749296 **[Test build #121876 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121876/testReport)** for PR 28360 at commit

[GitHub] [spark] MichaelChirico commented on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-27 Thread GitBox
MichaelChirico commented on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619748071 @HyukjinKwon done This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] cloud-fan commented on pull request #28357: [SPARK-31485][CORE][2.4] Avoid application hang if only partial barrier tasks launched

2020-04-27 Thread GitBox
cloud-fan commented on pull request #28357: URL: https://github.com/apache/spark/pull/28357#issuecomment-619748333 thanks, merging to 2.4! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins commented on pull request #28357: [SPARK-31485][CORE][2.4] Avoid application hang if only partial barrier tasks launched

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28357: URL: https://github.com/apache/spark/pull/28357#issuecomment-619746909 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28357: [SPARK-31485][CORE][2.4] Avoid application hang if only partial barrier tasks launched

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28357: URL: https://github.com/apache/spark/pull/28357#issuecomment-619746909 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28357: [SPARK-31485][CORE][2.4] Avoid application hang if only partial barrier tasks launched

2020-04-27 Thread GitBox
SparkQA commented on pull request #28357: URL: https://github.com/apache/spark/pull/28357#issuecomment-619746238 **[Test build #121861 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121861/testReport)** for PR 28357 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28357: [SPARK-31485][CORE][2.4] Avoid application hang if only partial barrier tasks launched

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28357: URL: https://github.com/apache/spark/pull/28357#issuecomment-619678072 **[Test build #121861 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121861/testReport)** for PR 28357 at commit

[GitHub] [spark] HyukjinKwon edited a comment on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-27 Thread GitBox
HyukjinKwon edited a comment on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619745043 Yeah, let's just do it completely separately. Let's just go back to the original status (before 51ee77b), and the just copy and paste the changes into

[GitHub] [spark] HyukjinKwon commented on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-27 Thread GitBox
HyukjinKwon commented on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619745043 Yeah, let's just do it completely separately. Let's just go back to the original status (before 51ee77b), and the just copy and paste the changes into `gapplyCollect`.

[GitHub] [spark] cloud-fan commented on a change in pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
cloud-fan commented on a change in pull request #28326: URL: https://github.com/apache/spark/pull/28326#discussion_r415531970 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -3262,10 +3262,21 @@ object CleanupAliases

<    5   6   7   8   9   10