[GitHub] [spark] AmplabJenkins commented on pull request #28797: [SPARK-31926][SQL][TEST-HIVE1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber

2020-06-12 Thread GitBox
AmplabJenkins commented on pull request #28797: URL: https://github.com/apache/spark/pull/28797#issuecomment-643106210 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28391: [SPARK-31593][SS] Remove unnecessary streaming query progress update

2020-06-12 Thread GitBox
AmplabJenkins commented on pull request #28391: URL: https://github.com/apache/spark/pull/28391#issuecomment-643106049 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-12 Thread GitBox
SparkQA commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-643105946 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] SparkQA commented on pull request #28797: [SPARK-31926][SQL][TEST-HIVE1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber

2020-06-12 Thread GitBox
SparkQA commented on pull request #28797: URL: https://github.com/apache/spark/pull/28797#issuecomment-643105948 **[Test build #123877 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123877/testReport)** for PR 28797 at commit

[GitHub] [spark] SparkQA commented on pull request #28788: [SPARK-31960][Yarn][Build] Only populate Hadoop classpath for no-hadoop build

2020-06-12 Thread GitBox
SparkQA commented on pull request #28788: URL: https://github.com/apache/spark/pull/28788#issuecomment-643105954 **[Test build #123887 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123887/testReport)** for PR 28788 at commit

[GitHub] [spark] SparkQA commented on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for sort merge join if applicable

2020-06-12 Thread GitBox
SparkQA commented on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-643105940 **[Test build #123883 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123883/testReport)** for PR 28123 at commit

[GitHub] [spark] SparkQA commented on pull request #28807: [WIP][SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

2020-06-12 Thread GitBox
SparkQA commented on pull request #28807: URL: https://github.com/apache/spark/pull/28807#issuecomment-643105944 **[Test build #123894 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123894/testReport)** for PR 28807 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly

2020-06-12 Thread GitBox
AmplabJenkins removed a comment on pull request #28808: URL: https://github.com/apache/spark/pull/28808#issuecomment-643105384 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly

2020-06-12 Thread GitBox
AmplabJenkins commented on pull request #28808: URL: https://github.com/apache/spark/pull/28808#issuecomment-643105384 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly

2020-06-12 Thread GitBox
SparkQA commented on pull request #28808: URL: https://github.com/apache/spark/pull/28808#issuecomment-643104851 **[Test build #123895 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123895/testReport)** for PR 28808 at commit

[GitHub] [spark] ulysses-you opened a new pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly

2020-06-12 Thread GitBox
ulysses-you opened a new pull request #28808: URL: https://github.com/apache/spark/pull/28808 ### What changes were proposed in this pull request? Add WindowFunction check at `CheckAnalysis`. ### Why are the changes needed? Provide friendly error msg. ###

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-06-12 Thread GitBox
AmplabJenkins removed a comment on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-643101735 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-06-12 Thread GitBox
AmplabJenkins removed a comment on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-643101727 Build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] AmplabJenkins commented on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-06-12 Thread GitBox
AmplabJenkins commented on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-643101727 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-06-12 Thread GitBox
SparkQA removed a comment on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-643043305 **[Test build #123881 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123881/testReport)** for PR 28685 at commit

[GitHub] [spark] SparkQA commented on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-06-12 Thread GitBox
SparkQA commented on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-643100973 **[Test build #123881 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123881/testReport)** for PR 28685 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28807: [WIP][SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

2020-06-12 Thread GitBox
AmplabJenkins removed a comment on pull request #28807: URL: https://github.com/apache/spark/pull/28807#issuecomment-643099104 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28807: [WIP][SPARK-26905][SQL][TESTS] Follow the SQL:2016 reserved keywords

2020-06-12 Thread GitBox
SparkQA commented on pull request #28807: URL: https://github.com/apache/spark/pull/28807#issuecomment-643098820 **[Test build #123894 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123894/testReport)** for PR 28807 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28807: [WIP][SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

2020-06-12 Thread GitBox
AmplabJenkins commented on pull request #28807: URL: https://github.com/apache/spark/pull/28807#issuecomment-643099104 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu opened a new pull request #28807: [WIP][SPARK-26905][SQL][TESTS] Follow the SQL:2016 reserved keywords

2020-06-12 Thread GitBox
maropu opened a new pull request #28807: URL: https://github.com/apache/spark/pull/28807 ### What changes were proposed in this pull request? This PR intends to move keywords `ANTI`, `SEMI`, and `MINUS` from reserved to non-reserved. ### Why are the changes needed?

[GitHub] [spark] wangyum commented on a change in pull request #28805: [SPARK-28169][SQL] Convert scan predicate condition to CNF

2020-06-12 Thread GitBox
wangyum commented on a change in pull request #28805: URL: https://github.com/apache/spark/pull/28805#discussion_r439236301 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala ## @@ -253,6 +253,58 @@ trait PredicateHelper

[GitHub] [spark] wangyum commented on a change in pull request #28805: [SPARK-28169][SQL] Convert scan predicate condition to CNF

2020-06-12 Thread GitBox
wangyum commented on a change in pull request #28805: URL: https://github.com/apache/spark/pull/28805#discussion_r439236301 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala ## @@ -253,6 +253,58 @@ trait PredicateHelper

[GitHub] [spark] sarutak commented on pull request #28806: [SPARK-31967][UI] UI Perf regression: Loading jobs UI page takes 40 seconds

2020-06-12 Thread GitBox
sarutak commented on pull request #28806: URL: https://github.com/apache/spark/pull/28806#issuecomment-643093469 @gengliangwang I checked out the change and build but timeline-view wouldn't work.

[GitHub] [spark] zhli1142015 commented on a change in pull request #28769: [SPARK-31929][WEBUI] Close leveldbiterator when leveldb.close

2020-06-12 Thread GitBox
zhli1142015 commented on a change in pull request #28769: URL: https://github.com/apache/spark/pull/28769#discussion_r439218088 ## File path: common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDB.java ## @@ -247,17 +266,28 @@ public void close() throws

[GitHub] [spark] zhli1142015 commented on a change in pull request #28769: [SPARK-31929][WEBUI] Close leveldbiterator when leveldb.close

2020-06-12 Thread GitBox
zhli1142015 commented on a change in pull request #28769: URL: https://github.com/apache/spark/pull/28769#discussion_r439159094 ## File path: common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDBIterator.java ## @@ -189,17 +189,7 @@ public synchronized void

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28391: [SPARK-31593][SS] Remove unnecessary streaming query progress update

2020-06-12 Thread GitBox
AmplabJenkins removed a comment on pull request #28391: URL: https://github.com/apache/spark/pull/28391#issuecomment-643088381 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28391: [SPARK-31593][SS] Remove unnecessary streaming query progress update

2020-06-12 Thread GitBox
AmplabJenkins commented on pull request #28391: URL: https://github.com/apache/spark/pull/28391#issuecomment-643088381 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28391: [SPARK-31593][SS] Remove unnecessary streaming query progress update

2020-06-12 Thread GitBox
SparkQA commented on pull request #28391: URL: https://github.com/apache/spark/pull/28391#issuecomment-643087986 **[Test build #123893 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123893/testReport)** for PR 28391 at commit

[GitHub] [spark] cloud-fan edited a comment on pull request #28787: [SPARK-31959][SQL][test-java11] Fix Gregorian-Julian micros rebasing while switching standard time zone offset

2020-06-12 Thread GitBox
cloud-fan edited a comment on pull request #28787: URL: https://github.com/apache/spark/pull/28787#issuecomment-643087372 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan closed pull request #28787: [SPARK-31959][SQL][test-java11] Fix Gregorian-Julian micros rebasing while switching standard time zone offset

2020-06-12 Thread GitBox
cloud-fan closed pull request #28787: URL: https://github.com/apache/spark/pull/28787 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan edited a comment on pull request #28787: [SPARK-31959][SQL][test-java11] Fix Gregorian-Julian micros rebasing while switching standard time zone offset

2020-06-12 Thread GitBox
cloud-fan edited a comment on pull request #28787: URL: https://github.com/apache/spark/pull/28787#issuecomment-643086118 More context: To do datetime rebase more efficiently, we put the diffs between two calendars in JSON files, to avoid calculating the diffs every time. To

[GitHub] [spark] cloud-fan commented on pull request #28787: [SPARK-31959][SQL][test-java11] Fix Gregorian-Julian micros rebasing while switching standard time zone offset

2020-06-12 Thread GitBox
cloud-fan commented on pull request #28787: URL: https://github.com/apache/spark/pull/28787#issuecomment-643087372 thanks, merging to master/3.0! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan commented on pull request #28787: [SPARK-31959][SQL][test-java11] Fix Gregorian-Julian micros rebasing while switching standard time zone offset

2020-06-12 Thread GitBox
cloud-fan commented on pull request #28787: URL: https://github.com/apache/spark/pull/28787#issuecomment-643086118 More context: To do datetime rebase more efficiently, we put the diffs between two calendars in JSON files, to avoid calculating the diffs every time. We run the

[GitHub] [spark] gengliangwang commented on pull request #28806: [SPARK-31967][UI] UI Perf regression: Loading jobs UI page takes 40 seconds

2020-06-12 Thread GitBox
gengliangwang commented on pull request #28806: URL: https://github.com/apache/spark/pull/28806#issuecomment-643086125 OK, the 4.21.0 package in https://almende.github.io/vis/ should be the same This is an automated message

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28391: [SPARK-31593][SS] Remove unnecessary streaming query progress update

2020-06-12 Thread GitBox
AmplabJenkins removed a comment on pull request #28391: URL: https://github.com/apache/spark/pull/28391#issuecomment-643065281 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] uncleGen commented on pull request #28391: [SPARK-31593][SS] Remove unnecessary streaming query progress update

2020-06-12 Thread GitBox
uncleGen commented on pull request #28391: URL: https://github.com/apache/spark/pull/28391#issuecomment-643086065 retest this please. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] sarutak commented on pull request #28806: [SPARK-31967][UI] UI Perf regression: Loading jobs UI page takes 40 seconds

2020-06-12 Thread GitBox
sarutak commented on pull request #28806: URL: https://github.com/apache/spark/pull/28806#issuecomment-643085539 I can't still get from the URL but can get from https://almende.github.io/vis/ anyway. This is an automated

[GitHub] [spark] gengliangwang commented on pull request #28806: [SPARK-31967][UI] UI Perf regression: Loading jobs UI page takes 40 seconds

2020-06-12 Thread GitBox
gengliangwang commented on pull request #28806: URL: https://github.com/apache/spark/pull/28806#issuecomment-643083080 @sarutak it works fine in my side: ![image](https://user-images.githubusercontent.com/1097932/84470196-a8006b80-ac37-11ea-81be-a0f28f6c8dc3.png)

[GitHub] [spark] sarutak commented on pull request #28806: [SPARK-31967][UI] UI Perf regression: Loading jobs UI page takes 40 seconds

2020-06-12 Thread GitBox
sarutak commented on pull request #28806: URL: https://github.com/apache/spark/pull/28806#issuecomment-643082478 I can't download the downgraded version of `vis` from https://cdnjs.com/libraries/vis. Is it temporarily not available?

<    3   4   5   6   7   8