[GitHub] [spark] moomindani commented on a change in pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

moomindani commented on a change in pull request #27690: URL: https://github.com/apache/spark/pull/27690#discussion_r446516892 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala ## @@ -97,12 +99,38 @@ private[hive] trait

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28905: [SPARK-32071][SQL][TESTS] Add `make_interval` benchmark

AmplabJenkins removed a comment on pull request #28905: URL: https://github.com/apache/spark/pull/28905#issuecomment-650701364 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28905: [SPARK-32071][SQL][TESTS] Add `make_interval` benchmark

AmplabJenkins commented on pull request #28905: URL: https://github.com/apache/spark/pull/28905#issuecomment-650701364 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28905: [SPARK-32071][SQL][TESTS] Add `make_interval` benchmark

SparkQA removed a comment on pull request #28905: URL: https://github.com/apache/spark/pull/28905#issuecomment-650658676 **[Test build #124579 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124579/testReport)** for PR 28905 at commit

[GitHub] [spark] moomindani commented on a change in pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

moomindani commented on a change in pull request #27690: URL: https://github.com/apache/spark/pull/27690#discussion_r446604034 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala ## @@ -97,12 +99,38 @@ private[hive] trait

[GitHub] [spark] SparkQA commented on pull request #28905: [SPARK-32071][SQL][TESTS] Add `make_interval` benchmark

SparkQA commented on pull request #28905: URL: https://github.com/apache/spark/pull/28905#issuecomment-650701112 **[Test build #124579 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124579/testReport)** for PR 28905 at commit

[GitHub] [spark] moomindani commented on a change in pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

moomindani commented on a change in pull request #27690: URL: https://github.com/apache/spark/pull/27690#discussion_r446604034 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala ## @@ -97,12 +99,38 @@ private[hive] trait

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28901: [WIP][SPARK-32064][SQL] Supporting create temporary table

AmplabJenkins removed a comment on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-650700128 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28901: [WIP][SPARK-32064][SQL] Supporting create temporary table

AmplabJenkins commented on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-650700128 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28901: [WIP][SPARK-32064][SQL] Supporting create temporary table

SparkQA commented on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-650700037 **[Test build #124594 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124594/testReport)** for PR 28901 at commit

[GitHub] [spark] LantaoJin commented on pull request #28901: [WIP][SPARK-32064][SQL] Supporting create temporary table

LantaoJin commented on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-650698393 @gatorsmile Yes. Just like Hive temporary table or Teradata volatile table. We are migrating our Spark to v3.0. This is one of inside features which had widely used in our

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

AmplabJenkins removed a comment on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-650697849 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

AmplabJenkins removed a comment on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-650697842 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

AmplabJenkins commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-650697842 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

SparkQA removed a comment on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-650673555 **[Test build #124581 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124581/testReport)** for PR 28647 at commit

[GitHub] [spark] SparkQA commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

SparkQA commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-650697664 **[Test build #124581 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124581/testReport)** for PR 28647 at commit

[GitHub] [spark] TJX2014 edited a comment on pull request #28918: [SPARK-32068][WEBUI] Correct task lauchtime show issue due to timezone in stage tab

TJX2014 edited a comment on pull request #28918: URL: https://github.com/apache/spark/pull/28918#issuecomment-650686745 @dongjoon-hyun Thanks, I have done. :-) This is an automated message from the Apache Git Service. To

[GitHub] [spark] TJX2014 edited a comment on pull request #28918: [SPARK-32068][WEBUI] Correct task lauchtime show issue due to timezone in stage tab

TJX2014 edited a comment on pull request #28918: URL: https://github.com/apache/spark/pull/28918#issuecomment-650686745 @dongjoon-hyun Thanks, I have done. This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] AmplabJenkins commented on pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow

AmplabJenkins commented on pull request #28937: URL: https://github.com/apache/spark/pull/28937#issuecomment-650694350 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow

AmplabJenkins removed a comment on pull request #28937: URL: https://github.com/apache/spark/pull/28937#issuecomment-650694350 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HeartSaVioR edited a comment on pull request #28841: [SPARK-31962][SQL][SS] Provide option to load files after a specified date when reading from a folder path

HeartSaVioR edited a comment on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-650694094 Please take a look at how Kafka data source options apply with both batch and streaming query. The semantic of the option should be applied differently.

[GitHub] [spark] HeartSaVioR commented on pull request #28841: [SPARK-31962][SQL][SS] Provide option to load files after a specified date when reading from a folder path

HeartSaVioR commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-650694094 Please take a look at how Kafka data source options apply with both batch and streaming query. The semantic of the option should be applied differently.

[GitHub] [spark] SparkQA commented on pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow

SparkQA commented on pull request #28937: URL: https://github.com/apache/spark/pull/28937#issuecomment-650694181 **[Test build #124593 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124593/testReport)** for PR 28937 at commit

[GitHub] [spark] beliefer commented on a change in pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

beliefer commented on a change in pull request #28685: URL: https://github.com/apache/spark/pull/28685#discussion_r446590900 ## File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/window_part1.sql ## @@ -301,7 +301,7 @@ FROM tenk1 WHERE unique1 < 10; --

[GitHub] [spark] xuanyuanking opened a new pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow

xuanyuanking opened a new pull request #28937: URL: https://github.com/apache/spark/pull/28937 ### What changes were proposed in this pull request? Bug fix for overflow case in `UTF8String.substringSQL`. ### Why are the changes needed? SQL query `SELECT SUBSTRING("abc",

[GitHub] [spark] xuanyuanking commented on pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow

xuanyuanking commented on pull request #28937: URL: https://github.com/apache/spark/pull/28937#issuecomment-650693563 cc @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

AmplabJenkins removed a comment on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-650692254 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

AmplabJenkins commented on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-650692254 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

SparkQA commented on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-650692166 **[Test build #124592 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124592/testReport)** for PR 28898 at commit

[GitHub] [spark] frankyin-factual commented on a change in pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

frankyin-factual commented on a change in pull request #28898: URL: https://github.com/apache/spark/pull/28898#discussion_r446598259 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -39,6 +39,22 @@ object

[GitHub] [spark] HeartSaVioR commented on pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink to avoid memory issue

HeartSaVioR commented on pull request #28904: URL: https://github.com/apache/spark/pull/28904#issuecomment-650690135 UPDATE: now SPARK-30946 + SPARK-30462 writes 11879 which RES is still less than 2G (around 1.7G). I'll stop the sustaining test for enough heap and run the another

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28935: [SPARK-20680][SQL] Adding HiveVoidType in Spark to be compatible with Hive

AmplabJenkins removed a comment on pull request #28935: URL: https://github.com/apache/spark/pull/28935#issuecomment-650688121 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

AmplabJenkins commented on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-650688119 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

AmplabJenkins removed a comment on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-650688119 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28935: [SPARK-20680][SQL] Adding HiveVoidType in Spark to be compatible with Hive

AmplabJenkins commented on pull request #28935: URL: https://github.com/apache/spark/pull/28935#issuecomment-650688121 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28935: [SPARK-20680][SQL] Adding HiveVoidType in Spark to be compatible with Hive

SparkQA commented on pull request #28935: URL: https://github.com/apache/spark/pull/28935#issuecomment-650687920 **[Test build #124590 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124590/testReport)** for PR 28935 at commit

[GitHub] [spark] SparkQA commented on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

SparkQA commented on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-650687924 **[Test build #124591 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124591/testReport)** for PR 28685 at commit

[GitHub] [spark] maropu edited a comment on pull request #28737: [SPARK-31913][SQL] Fix StackOverflowError in FileScanRDD

maropu edited a comment on pull request #28737: URL: https://github.com/apache/spark/pull/28737#issuecomment-650686603 Yea, we need env-independent tests to reproduce this issue... This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28918: [SPARK-32068][WEBUI] Correct task lauchtime show issue due to timezone in stage tab

AmplabJenkins removed a comment on pull request #28918: URL: https://github.com/apache/spark/pull/28918#issuecomment-650687180 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28918: [SPARK-32068][WEBUI] Correct task lauchtime show issue due to timezone in stage tab

AmplabJenkins commented on pull request #28918: URL: https://github.com/apache/spark/pull/28918#issuecomment-650687180 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution

AmplabJenkins removed a comment on pull request #28936: URL: https://github.com/apache/spark/pull/28936#issuecomment-650687026 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution

AmplabJenkins commented on pull request #28936: URL: https://github.com/apache/spark/pull/28936#issuecomment-650687026 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28918: [SPARK-32068][WEBUI] Correct task lauchtime show issue due to timezone in stage tab

SparkQA removed a comment on pull request #28918: URL: https://github.com/apache/spark/pull/28918#issuecomment-650656834 **[Test build #124577 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124577/testReport)** for PR 28918 at commit

[GitHub] [spark] SparkQA commented on pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution

SparkQA commented on pull request #28936: URL: https://github.com/apache/spark/pull/28936#issuecomment-650686881 **[Test build #124589 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124589/testReport)** for PR 28936 at commit

[GitHub] [spark] SparkQA commented on pull request #28918: [SPARK-32068][WEBUI] Correct task lauchtime show issue due to timezone in stage tab

SparkQA commented on pull request #28918: URL: https://github.com/apache/spark/pull/28918#issuecomment-650686877 **[Test build #124577 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124577/testReport)** for PR 28918 at commit

[GitHub] [spark] TJX2014 commented on pull request #28918: [SPARK-32068][WEBUI] Correct task lauchtime show issue due to timezone in stage tab

TJX2014 commented on pull request #28918: URL: https://github.com/apache/spark/pull/28918#issuecomment-650686745 @dongjoon-hyun Thanks, I may have done. This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] maropu commented on pull request #28737: [SPARK-31913][SQL] Fix StackOverflowError in FileScanRDD

maropu commented on pull request #28737: URL: https://github.com/apache/spark/pull/28737#issuecomment-650686603 Yea, we need env-independent tests for this issue... This is an automated message from the Apache Git Service.

[GitHub] [spark] dongjoon-hyun commented on pull request #28935: [SPARK-20680][SQL] Adding HiveNullType in Spark to be compatible with Hive

dongjoon-hyun commented on pull request #28935: URL: https://github.com/apache/spark/pull/28935#issuecomment-650686555 Thank you for working on this, @LantaoJin ! This is an automated message from the Apache Git Service. To

[GitHub] [spark] beliefer commented on a change in pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

beliefer commented on a change in pull request #28685: URL: https://github.com/apache/spark/pull/28685#discussion_r446590900 ## File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/window_part1.sql ## @@ -301,7 +301,7 @@ FROM tenk1 WHERE unique1 < 10; --

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28935: [SPARK-20680][SQL] Adding HiveNullType in Spark to be compatible with Hive

dongjoon-hyun commented on a change in pull request #28935: URL: https://github.com/apache/spark/pull/28935#discussion_r446595871 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/HiveNullType.scala ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28935: [SPARK-20680][SQL] Adding HiveNullType in Spark to be compatible with Hive

dongjoon-hyun commented on a change in pull request #28935: URL: https://github.com/apache/spark/pull/28935#discussion_r446595757 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/HiveNullType.scala ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache

[GitHub] [spark] xuanyuanking opened a new pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution

xuanyuanking opened a new pull request #28936: URL: https://github.com/apache/spark/pull/28936 ### What changes were proposed in this pull request? The `optimizedPlan` in IncrementalExecution should also be scoped in `withActive`. ### Why are the changes needed?

[GitHub] [spark] xuanyuanking commented on pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution

xuanyuanking commented on pull request #28936: URL: https://github.com/apache/spark/pull/28936#issuecomment-650686260 cc @cloud-fan @HyukjinKwon This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] LantaoJin commented on a change in pull request #28935: [SPARK-20680][SQL] Adding HiveNullType in Spark to be compatible with Hive

LantaoJin commented on a change in pull request #28935: URL: https://github.com/apache/spark/pull/28935#discussion_r446595548 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/HiveNullType.scala ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28935: [SPARK-20680][SQL] Adding HiveNullType in Spark to be compatible with Hive

dongjoon-hyun commented on a change in pull request #28935: URL: https://github.com/apache/spark/pull/28935#discussion_r446595406 ## File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala ## @@ -132,7 +132,9 @@ class

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28935: [SPARK-20680][SQL] Adding HiveNullType in Spark to be compatible with Hive

dongjoon-hyun commented on a change in pull request #28935: URL: https://github.com/apache/spark/pull/28935#discussion_r446595364 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/HiveNullType.scala ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache

[GitHub] [spark] xuanyuanking commented on pull request #28737: [SPARK-31913][SQL] Fix StackOverflowError in FileScanRDD

xuanyuanking commented on pull request #28737: URL: https://github.com/apache/spark/pull/28737#issuecomment-650685434 Same question with Takeshi here https://github.com/apache/spark/pull/28737#discussion_r437831211 This is

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28935: [SPARK-20680][SQL] Adding HiveNullType in Spark to be compatible with Hive

dongjoon-hyun commented on a change in pull request #28935: URL: https://github.com/apache/spark/pull/28935#discussion_r446595267 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/HiveNullType.scala ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28935: [SPARK-20680][SQL] Adding HiveNullType in Spark to be compatible with Hive

dongjoon-hyun commented on a change in pull request #28935: URL: https://github.com/apache/spark/pull/28935#discussion_r446595209 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/HiveNullType.scala ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28935: [SPARK-20680][SQL] Adding HiveNullType in Spark to be compatible with Hive

dongjoon-hyun commented on a change in pull request #28935: URL: https://github.com/apache/spark/pull/28935#discussion_r446595141 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/HiveNullType.scala ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache

[GitHub] [spark] xuanyuanking commented on pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink to avoid memory issue

xuanyuanking commented on pull request #28904: URL: https://github.com/apache/spark/pull/28904#issuecomment-650684827 Very impressive! I'll review this in 2 days. This is an automated message from the Apache Git Service. To

[GitHub] [spark] LantaoJin commented on a change in pull request #28935: [SPARK-20680][SQL] Adding HiveNullType in Spark to be compatible with Hive

LantaoJin commented on a change in pull request #28935: URL: https://github.com/apache/spark/pull/28935#discussion_r446595075 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -2184,7 +2184,9 @@ class AstBuilder(conf:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28935: [SPARK-20680][SQL] Adding HiveNullType in Spark to be compatible with Hive

dongjoon-hyun commented on a change in pull request #28935: URL: https://github.com/apache/spark/pull/28935#discussion_r446594898 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -2260,7 +2263,9 @@ class AstBuilder(conf:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28935: [SPARK-20680][SQL] Adding HiveNullType in Spark to be compatible with Hive

dongjoon-hyun commented on a change in pull request #28935: URL: https://github.com/apache/spark/pull/28935#discussion_r446594858 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -2184,7 +2184,9 @@ class AstBuilder(conf:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28895: [SPARK-32055][CORE][SQL] Unify getReader and getReaderForRange in ShuffleManager

dongjoon-hyun commented on a change in pull request #28895: URL: https://github.com/apache/spark/pull/28895#discussion_r446476096 ## File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ## @@ -335,23 +335,6 @@ private[spark] abstract class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28916: [SPARK-32083][SQL] Coalesce to one partition when all partitions are empty in AQE

AmplabJenkins removed a comment on pull request #28916: URL: https://github.com/apache/spark/pull/28916#issuecomment-650683327 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28916: [SPARK-32083][SQL] Coalesce to one partition when all partitions are empty in AQE

AmplabJenkins commented on pull request #28916: URL: https://github.com/apache/spark/pull/28916#issuecomment-650683327 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28916: [SPARK-32083][SQL] Coalesce to one partition when all partitions are empty in AQE

SparkQA commented on pull request #28916: URL: https://github.com/apache/spark/pull/28916#issuecomment-650683117 **[Test build #124588 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124588/testReport)** for PR 28916 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #28916: [SPARK-32083][SQL] Coalesce to one partition when all partitions are empty in AQE

dongjoon-hyun commented on pull request #28916: URL: https://github.com/apache/spark/pull/28916#issuecomment-650682797 Retest this please. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] viirya commented on a change in pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

viirya commented on a change in pull request #27690: URL: https://github.com/apache/spark/pull/27690#discussion_r446593989 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala ## @@ -97,12 +99,38 @@ private[hive] trait SaveAsHiveFile

[GitHub] [spark] AmplabJenkins commented on pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

AmplabJenkins commented on pull request #28917: URL: https://github.com/apache/spark/pull/28917#issuecomment-650682148 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

AmplabJenkins removed a comment on pull request #28917: URL: https://github.com/apache/spark/pull/28917#issuecomment-650682148 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

SparkQA commented on pull request #28917: URL: https://github.com/apache/spark/pull/28917#issuecomment-650681799 **[Test build #124587 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124587/testReport)** for PR 28917 at commit

[GitHub] [spark] beliefer commented on a change in pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

beliefer commented on a change in pull request #28917: URL: https://github.com/apache/spark/pull/28917#discussion_r446593625 ## File path: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ## @@ -278,7 +280,26 @@ class DAGSchedulerSuite extends

[GitHub] [spark] xianyinxin commented on a change in pull request #28875: [SPARK-32030][SQL] Support unlimited MATCHED and NOT MATCHED clauses in MERGE INTO

xianyinxin commented on a change in pull request #28875: URL: https://github.com/apache/spark/pull/28875#discussion_r446593547 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -347,23 +347,23 @@ case class

[GitHub] [spark] xianyinxin commented on a change in pull request #28875: [SPARK-32030][SQL] Support unlimited MATCHED and NOT MATCHED clauses in MERGE INTO

xianyinxin commented on a change in pull request #28875: URL: https://github.com/apache/spark/pull/28875#discussion_r446593529 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -468,13 +458,25 @@ class AstBuilder(conf:

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28875: [SPARK-32030][SQL] Support unlimited MATCHED and NOT MATCHED clauses in MERGE INTO

AmplabJenkins removed a comment on pull request #28875: URL: https://github.com/apache/spark/pull/28875#issuecomment-650680512 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

AmplabJenkins removed a comment on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-650680524 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28875: [SPARK-32030][SQL] Support unlimited MATCHED and NOT MATCHED clauses in MERGE INTO

AmplabJenkins commented on pull request #28875: URL: https://github.com/apache/spark/pull/28875#issuecomment-650680512 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

AmplabJenkins commented on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-650680524 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] beliefer commented on pull request #28866: [SPARK-31845][CORE][TESTS] Refactor DAGSchedulerSuite by introducing completeAndCheckAnswer and using completeNextStageWithFetchFailure

beliefer commented on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-650680239 @dongjoon-hyun @Ngone51 Thanks for your help! This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

SparkQA commented on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-650680160 **[Test build #124586 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124586/testReport)** for PR 28685 at commit

[GitHub] [spark] SparkQA commented on pull request #28875: [SPARK-32030][SQL] Support unlimited MATCHED and NOT MATCHED clauses in MERGE INTO

SparkQA commented on pull request #28875: URL: https://github.com/apache/spark/pull/28875#issuecomment-650680152 **[Test build #124585 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124585/testReport)** for PR 28875 at commit

[GitHub] [spark] beliefer commented on a change in pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

beliefer commented on a change in pull request #28685: URL: https://github.com/apache/spark/pull/28685#discussion_r446593095 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -363,6 +363,11 @@ abstract class

[GitHub] [spark] LantaoJin commented on pull request #28935: [SPARK-20680][SQL] Adding HiveNullType in Spark to be compatible with Hive

LantaoJin commented on pull request #28935: URL: https://github.com/apache/spark/pull/28935#issuecomment-650676333 Thanks @HyukjinKwon, if this could be merged, can you help on python side? This is an automated message from

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28935: [SPARK-20680][SQL] Adding HiveNullType in Spark to be compatible with Hive

AmplabJenkins removed a comment on pull request #28935: URL: https://github.com/apache/spark/pull/28935#issuecomment-650676056 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] beliefer commented on a change in pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

beliefer commented on a change in pull request #28685: URL: https://github.com/apache/spark/pull/28685#discussion_r446591904 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala ## @@ -151,10 +168,41 @@ final class

[GitHub] [spark] AmplabJenkins commented on pull request #28935: [SPARK-20680][SQL] Adding HiveNullType in Spark to be compatible with Hive

AmplabJenkins commented on pull request #28935: URL: https://github.com/apache/spark/pull/28935#issuecomment-650676056 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

AmplabJenkins removed a comment on pull request #28913: URL: https://github.com/apache/spark/pull/28913#issuecomment-650675872 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on pull request #28935: [SPARK-20680][SQL] Adding HiveNullType in Spark to be compatible with Hive

SparkQA commented on pull request #28935: URL: https://github.com/apache/spark/pull/28935#issuecomment-650675879 **[Test build #124584 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124584/testReport)** for PR 28935 at commit

[GitHub] [spark] beliefer commented on a change in pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

beliefer commented on a change in pull request #28685: URL: https://github.com/apache/spark/pull/28685#discussion_r446591742 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala ## @@ -151,10 +168,41 @@ final class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

AmplabJenkins removed a comment on pull request #28913: URL: https://github.com/apache/spark/pull/28913#issuecomment-650675868 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

AmplabJenkins commented on pull request #28913: URL: https://github.com/apache/spark/pull/28913#issuecomment-650675868 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

SparkQA commented on pull request #28913: URL: https://github.com/apache/spark/pull/28913#issuecomment-650675689 **[Test build #124580 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124580/testReport)** for PR 28913 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

SparkQA removed a comment on pull request #28913: URL: https://github.com/apache/spark/pull/28913#issuecomment-650665077 **[Test build #124580 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124580/testReport)** for PR 28913 at commit

[GitHub] [spark] beliefer commented on a change in pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

beliefer commented on a change in pull request #28685: URL: https://github.com/apache/spark/pull/28685#discussion_r446591742 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala ## @@ -151,10 +168,41 @@ final class

[GitHub] [spark] beliefer commented on a change in pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

beliefer commented on a change in pull request #28685: URL: https://github.com/apache/spark/pull/28685#discussion_r446591681 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala ## @@ -151,10 +168,41 @@ final class

[GitHub] [spark] beliefer commented on a change in pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

beliefer commented on a change in pull request #28685: URL: https://github.com/apache/spark/pull/28685#discussion_r446591593 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -993,6 +993,30 @@ object functions { Lead(e.expr, Literal(offset),

[GitHub] [spark] LantaoJin commented on pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

LantaoJin commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-650675131 Before that, I think we still need to fix the problem describe in the description. https://github.com/apache/spark/pull/28833#pullrequestreview-435416974 is a good idea to

[GitHub] [spark] SparkQA commented on pull request #28935: [SPARK-20680][SQL] Adding HiveNullType in Spark to be compatible with Hive

SparkQA commented on pull request #28935: URL: https://github.com/apache/spark/pull/28935#issuecomment-650674973 **[Test build #124583 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124583/testReport)** for PR 28935 at commit

  1   2   3   4   >