[GitHub] [spark] SparkQA removed a comment on pull request #29078: [SPARK-29292][STREAMING][SQL][BUILD] Get streaming, catalyst, sql compiling for Scala 2.13

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #29078: URL: https://github.com/apache/spark/pull/29078#issuecomment-657790109 **[Test build #125790 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125790/testReport)** for PR 29078 at commit

[GitHub] [spark] HeartSaVioR commented on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-07-13 Thread GitBox
HeartSaVioR commented on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-657921314 @tgravescs Do you plan another round of review, or OK as it is? This is an automated message from the

[GitHub] [spark] AmplabJenkins commented on pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29002: URL: https://github.com/apache/spark/pull/29002#issuecomment-657916600 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29002: URL: https://github.com/apache/spark/pull/29002#issuecomment-657916600 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-13 Thread GitBox
SparkQA commented on pull request #29002: URL: https://github.com/apache/spark/pull/29002#issuecomment-657916150 **[Test build #125798 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125798/testReport)** for PR 29002 at commit

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29087: [SPARK-28227][SQL] Support TRANSFORM with aggregation

2020-07-13 Thread GitBox
AngersZh commented on a change in pull request #29087: URL: https://github.com/apache/spark/pull/29087#discussion_r454045113 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -496,7 +496,9 @@ fromStatementBody

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29093: [SPARK-32220][SQL][3.0][FOLLOW-UP]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29093: URL: https://github.com/apache/spark/pull/29093#issuecomment-657914669 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29093: [SPARK-32220][SQL][3.0][FOLLOW-UP]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29093: URL: https://github.com/apache/spark/pull/29093#issuecomment-657914669 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29087: [SPARK-28227][SQL] Support TRANSFORM with aggregation

2020-07-13 Thread GitBox
SparkQA commented on pull request #29087: URL: https://github.com/apache/spark/pull/29087#issuecomment-657914322 **[Test build #125797 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125797/testReport)** for PR 29087 at commit

[GitHub] [spark] SparkQA commented on pull request #29093: [SPARK-32220][SQL][3.0][FOLLOW-UP]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-13 Thread GitBox
SparkQA commented on pull request #29093: URL: https://github.com/apache/spark/pull/29093#issuecomment-657914276 **[Test build #125796 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125796/testReport)** for PR 29093 at commit

[GitHub] [spark] AngersZhuuuu opened a new pull request #29093: [SPARK-32220][SQL][3.0][FOLLOW-UP]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-13 Thread GitBox
AngersZh opened a new pull request #29093: URL: https://github.com/apache/spark/pull/29093 ### What changes were proposed in this pull request? follow comment https://github.com/apache/spark/pull/29035#discussion_r453468999 Explain for pr ### Why are the changes

[GitHub] [spark] AngersZhuuuu commented on pull request #29093: [SPARK-32220][SQL][3.0][FOLLOW-UP]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-13 Thread GitBox
AngersZh commented on pull request #29093: URL: https://github.com/apache/spark/pull/29093#issuecomment-657913561 cc @dongjoon-hyun This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29087: [SPARK-28227][SQL] Support TRANSFORM with aggregation

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29087: URL: https://github.com/apache/spark/pull/29087#issuecomment-657912666 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] sarutak commented on pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-13 Thread GitBox
sarutak commented on pull request #29002: URL: https://github.com/apache/spark/pull/29002#issuecomment-657912900 According to the log for the previous unit test, the reason why the new test failed seems not to related to heartbeat. It seems to have taken about 30 secs until Executor

[GitHub] [spark] AmplabJenkins commented on pull request #29087: [SPARK-28227][SQL] Support TRANSFORM with aggregation

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29087: URL: https://github.com/apache/spark/pull/29087#issuecomment-657912666 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29091: [SPARK-32258][SQL] Not duplicate normalization on children for float/double If/CaseWhen/Coalesce

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29091: URL: https://github.com/apache/spark/pull/29091#issuecomment-657906204 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29091: [SPARK-32258][SQL] Not duplicate normalization on children for float/double If/CaseWhen/Coalesce

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29091: URL: https://github.com/apache/spark/pull/29091#issuecomment-657906204 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29091: [SPARK-32258][SQL] Not duplicate normalization on children for float/double If/CaseWhen/Coalesce

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #29091: URL: https://github.com/apache/spark/pull/29091#issuecomment-657758173 **[Test build #125788 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125788/testReport)** for PR 29091 at commit

[GitHub] [spark] SparkQA commented on pull request #29091: [SPARK-32258][SQL] Not duplicate normalization on children for float/double If/CaseWhen/Coalesce

2020-07-13 Thread GitBox
SparkQA commented on pull request #29091: URL: https://github.com/apache/spark/pull/29091#issuecomment-657905799 **[Test build #125788 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125788/testReport)** for PR 29091 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657904952 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-657904956 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657904952 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-657904956 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
SparkQA commented on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657904577 **[Test build #125794 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125794/testReport)** for PR 29088 at commit

[GitHub] [spark] SparkQA commented on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-13 Thread GitBox
SparkQA commented on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-657904652 **[Test build #125795 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125795/testReport)** for PR 28898 at commit

[GitHub] [spark] frankyin-factual commented on a change in pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-13 Thread GitBox
frankyin-factual commented on a change in pull request #28898: URL: https://github.com/apache/spark/pull/28898#discussion_r454033847 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/SchemaPruningSuite.scala ## @@ -460,6 +460,67 @@ abstract

[GitHub] [spark] aokolnychyi commented on a change in pull request #29089: [SPARK-32276][SQL] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
aokolnychyi commented on a change in pull request #29089: URL: https://github.com/apache/spark/pull/29089#discussion_r454025327 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -981,6 +982,10 @@ object EliminateSorts

[GitHub] [spark] viirya commented on a change in pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-13 Thread GitBox
viirya commented on a change in pull request #28898: URL: https://github.com/apache/spark/pull/28898#discussion_r454025082 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/SchemaPruningSuite.scala ## @@ -460,6 +460,67 @@ abstract class

[GitHub] [spark] aokolnychyi commented on a change in pull request #29089: [SPARK-32276][SQL] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
aokolnychyi commented on a change in pull request #29089: URL: https://github.com/apache/spark/pull/29089#discussion_r454025043 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/arrow/ArrowConvertersSuite.scala ## @@ -1299,8 +1299,9 @@ class

[GitHub] [spark] aokolnychyi commented on a change in pull request #29089: [SPARK-32276][SQL] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
aokolnychyi commented on a change in pull request #29089: URL: https://github.com/apache/spark/pull/29089#discussion_r454024892 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -981,6 +982,10 @@ object EliminateSorts

[GitHub] [spark] frankyin-factual commented on a change in pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-13 Thread GitBox
frankyin-factual commented on a change in pull request #28898: URL: https://github.com/apache/spark/pull/28898#discussion_r454021579 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/SchemaPruningSuite.scala ## @@ -460,6 +460,67 @@ abstract

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28840: URL: https://github.com/apache/spark/pull/28840#issuecomment-657893712 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28840: URL: https://github.com/apache/spark/pull/28840#issuecomment-657893712 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-07-13 Thread GitBox
SparkQA commented on pull request #28840: URL: https://github.com/apache/spark/pull/28840#issuecomment-657893231 **[Test build #125793 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125793/testReport)** for PR 28840 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29077: [SPARK-31985][SS] Remove incomplete/undocumented stateful aggregation in continuous mode

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29077: URL: https://github.com/apache/spark/pull/29077#issuecomment-657891740 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29077: [SPARK-31985][SS] Remove incomplete/undocumented stateful aggregation in continuous mode

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29077: URL: https://github.com/apache/spark/pull/29077#issuecomment-657891740 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] ulysses-you commented on a change in pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-07-13 Thread GitBox
ulysses-you commented on a change in pull request #28840: URL: https://github.com/apache/spark/pull/28840#discussion_r454018778 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala ## @@ -236,6 +236,45 @@ case class

[GitHub] [spark] SparkQA commented on pull request #29077: [SPARK-31985][SS] Remove incomplete/undocumented stateful aggregation in continuous mode

2020-07-13 Thread GitBox
SparkQA commented on pull request #29077: URL: https://github.com/apache/spark/pull/29077#issuecomment-657891341 **[Test build #125792 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125792/testReport)** for PR 29077 at commit

[GitHub] [spark] ulysses-you commented on a change in pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-07-13 Thread GitBox
ulysses-you commented on a change in pull request #28840: URL: https://github.com/apache/spark/pull/28840#discussion_r454017632 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala ## @@ -236,6 +236,45 @@ case class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-657890024 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-657890024 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] HeartSaVioR commented on a change in pull request #29077: [SPARK-31985][SS] Remove incomplete/undocumented stateful aggregation in continuous mode

2020-07-13 Thread GitBox
HeartSaVioR commented on a change in pull request #29077: URL: https://github.com/apache/spark/pull/29077#discussion_r454016261 ## File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala ## @@ -286,9 +286,7 @@ class StreamingQueryManager

[GitHub] [spark] rdblue commented on a change in pull request #29089: [SPARK-32276][SQL] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
rdblue commented on a change in pull request #29089: URL: https://github.com/apache/spark/pull/29089#discussion_r454015855 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -981,6 +982,10 @@ object EliminateSorts extends

[GitHub] [spark] viirya commented on a change in pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-13 Thread GitBox
viirya commented on a change in pull request #28898: URL: https://github.com/apache/spark/pull/28898#discussion_r454013544 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/SchemaPruningSuite.scala ## @@ -460,6 +460,67 @@ abstract class

[GitHub] [spark] viirya commented on a change in pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-13 Thread GitBox
viirya commented on a change in pull request #28898: URL: https://github.com/apache/spark/pull/28898#discussion_r454012695 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/SchemaPruningSuite.scala ## @@ -460,6 +460,67 @@ abstract class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28957: [SPARK-32138] Drop Python 2.7, 3.4 and 3.5

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28957: URL: https://github.com/apache/spark/pull/28957#issuecomment-657878181 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28957: [SPARK-32138] Drop Python 2.7, 3.4 and 3.5

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28957: URL: https://github.com/apache/spark/pull/28957#issuecomment-657878181 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29002: URL: https://github.com/apache/spark/pull/29002#issuecomment-657877404 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #28957: [SPARK-32138] Drop Python 2.7, 3.4 and 3.5

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #28957: URL: https://github.com/apache/spark/pull/28957#issuecomment-657735646 **[Test build #125786 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125786/testReport)** for PR 28957 at commit

[GitHub] [spark] SparkQA commented on pull request #28957: [SPARK-32138] Drop Python 2.7, 3.4 and 3.5

2020-07-13 Thread GitBox
SparkQA commented on pull request #28957: URL: https://github.com/apache/spark/pull/28957#issuecomment-657877541 **[Test build #125786 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125786/testReport)** for PR 28957 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29002: URL: https://github.com/apache/spark/pull/29002#issuecomment-657877402 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29002: URL: https://github.com/apache/spark/pull/29002#issuecomment-657877402 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #29002: URL: https://github.com/apache/spark/pull/29002#issuecomment-657761388 **[Test build #125789 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125789/testReport)** for PR 29002 at commit

[GitHub] [spark] viirya commented on a change in pull request #29089: [SPARK-32276][SQL] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
viirya commented on a change in pull request #29089: URL: https://github.com/apache/spark/pull/29089#discussion_r454009047 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -981,6 +982,10 @@ object EliminateSorts extends

[GitHub] [spark] AmplabJenkins commented on pull request #29064: [SPARK-32272][SQL] Add SQL standard command SET TIME ZONE

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29064: URL: https://github.com/apache/spark/pull/29064#issuecomment-657877022 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29064: [SPARK-32272][SQL] Add SQL standard command SET TIME ZONE

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29064: URL: https://github.com/apache/spark/pull/29064#issuecomment-657877022 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-13 Thread GitBox
SparkQA commented on pull request #29002: URL: https://github.com/apache/spark/pull/29002#issuecomment-657876826 **[Test build #125789 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125789/testReport)** for PR 29002 at commit

[GitHub] [spark] SparkQA commented on pull request #29064: [SPARK-32272][SQL] Add SQL standard command SET TIME ZONE

2020-07-13 Thread GitBox
SparkQA commented on pull request #29064: URL: https://github.com/apache/spark/pull/29064#issuecomment-657876739 **[Test build #125791 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125791/testReport)** for PR 29064 at commit

[GitHub] [spark] maropu commented on pull request #29064: [SPARK-32272][SQL] Add SQL standard command SET TIME ZONE

2020-07-13 Thread GitBox
maropu commented on pull request #29064: URL: https://github.com/apache/spark/pull/29064#issuecomment-657876166 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AngersZhuuuu commented on pull request #29084: [SPARK-32220][SQL][FOLLOW-UP]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-13 Thread GitBox
AngersZh commented on pull request #29084: URL: https://github.com/apache/spark/pull/29084#issuecomment-657875575 > Could you make a backporting PR to branch-3.0, @AngersZh ? Sure, This is an automated message

[GitHub] [spark] maropu commented on pull request #7324: [SPARK-8955][SQL] Replace a duplicated initialize() in HiveGenericUDTF with new one

2020-07-13 Thread GitBox
maropu commented on pull request #7324: URL: https://github.com/apache/spark/pull/7324#issuecomment-657873841 Please use the new one. Any issue there? This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] maropu commented on a change in pull request #29075: [SPARK-32284][SQL] Avoid expanding too many CNF predicates in partition pruning

2020-07-13 Thread GitBox
maropu commented on a change in pull request #29075: URL: https://github.com/apache/spark/pull/29075#discussion_r454001849 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala ## @@ -207,13 +207,15 @@ trait PredicateHelper

[GitHub] [spark] maropu commented on a change in pull request #29075: [SPARK-32284][SQL] Avoid expanding too many CNF predicates in partition pruning

2020-07-13 Thread GitBox
maropu commented on a change in pull request #29075: URL: https://github.com/apache/spark/pull/29075#discussion_r454001849 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala ## @@ -207,13 +207,15 @@ trait PredicateHelper

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is l

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-65789 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-65789 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-657728722 **[Test build #125785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125785/testReport)** for PR 28848 at commit

[GitHub] [spark] maropu commented on a change in pull request #29075: [SPARK-32284][SQL] Avoid expanding too many CNF predicates in partition pruning

2020-07-13 Thread GitBox
maropu commented on a change in pull request #29075: URL: https://github.com/apache/spark/pull/29075#discussion_r45340 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PruneFileSourcePartitions.scala ## @@ -53,11 +53,17 @@ private[sql]

[GitHub] [spark] SparkQA commented on pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-13 Thread GitBox
SparkQA commented on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-657864098 **[Test build #125785 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125785/testReport)** for PR 28848 at commit

[GitHub] [spark] maropu commented on a change in pull request #29087: [SPARK-28227][SQL] Support TRANSFORM with aggregation

2020-07-13 Thread GitBox
maropu commented on a change in pull request #29087: URL: https://github.com/apache/spark/pull/29087#discussion_r453999594 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala ## @@ -2558,6 +2558,131 @@ abstract class SQLQuerySuiteBase

[GitHub] [spark] maropu commented on a change in pull request #29087: [SPARK-28227][SQL] Support TRANSFORM with aggregation

2020-07-13 Thread GitBox
maropu commented on a change in pull request #29087: URL: https://github.com/apache/spark/pull/29087#discussion_r453999107 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -496,7 +496,9 @@ fromStatementBody querySpecification

[GitHub] [spark] venkata91 commented on pull request #28287: [SPARK-31418][SCHEDULER] Request more executors in case of dynamic allocation is enabled and a task becomes unschedulable due to spark's bl

2020-07-13 Thread GitBox
venkata91 commented on pull request #28287: URL: https://github.com/apache/spark/pull/28287#issuecomment-657860016 > **[Test build #125783 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125783/testReport)** for PR 28287 at commit

[GitHub] [spark] rdblue commented on a change in pull request #29089: [SPARK-32276][SQL] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
rdblue commented on a change in pull request #29089: URL: https://github.com/apache/spark/pull/29089#discussion_r453998376 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/EliminateSortsSuite.scala ## @@ -310,4 +310,109 @@ class

[GitHub] [spark] agrawaldevesh commented on a change in pull request #28864: [SPARK-32004][ALL] Drop references to slave

2020-07-13 Thread GitBox
agrawaldevesh commented on a change in pull request #28864: URL: https://github.com/apache/spark/pull/28864#discussion_r453996944 ## File path: core/src/main/scala/org/apache/spark/scheduler/ExecutorLossReason.scala ## @@ -56,7 +56,7 @@ private [spark] object

[GitHub] [spark] rdblue commented on a change in pull request #29089: [SPARK-32276][SQL] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
rdblue commented on a change in pull request #29089: URL: https://github.com/apache/spark/pull/29089#discussion_r453994340 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -981,6 +982,10 @@ object EliminateSorts extends

[GitHub] [spark] rdblue commented on a change in pull request #29089: [SPARK-32276][SQL] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
rdblue commented on a change in pull request #29089: URL: https://github.com/apache/spark/pull/29089#discussion_r453993686 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -981,6 +982,10 @@ object EliminateSorts extends

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29089: [SPARK-32276][SQL] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29089: URL: https://github.com/apache/spark/pull/29089#issuecomment-657836318 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] rdblue commented on a change in pull request #29089: [SPARK-32276][SQL] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
rdblue commented on a change in pull request #29089: URL: https://github.com/apache/spark/pull/29089#discussion_r453990069 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/arrow/ArrowConvertersSuite.scala ## @@ -1299,8 +1299,9 @@ class ArrowConvertersSuite

[GitHub] [spark] AmplabJenkins commented on pull request #29089: [SPARK-32276][SQL] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29089: URL: https://github.com/apache/spark/pull/29089#issuecomment-657836318 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29089: [SPARK-32276][SQL] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #29089: URL: https://github.com/apache/spark/pull/29089#issuecomment-657679330 **[Test build #125781 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125781/testReport)** for PR 29089 at commit

[GitHub] [spark] SparkQA commented on pull request #29089: [SPARK-32276][SQL] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
SparkQA commented on pull request #29089: URL: https://github.com/apache/spark/pull/29089#issuecomment-657835007 **[Test build #125781 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125781/testReport)** for PR 29089 at commit

[GitHub] [spark] Sudhar287 commented on pull request #29008: [SPARK-31579][SQL] replaced floorDiv to Div

2020-07-13 Thread GitBox
Sudhar287 commented on pull request #29008: URL: https://github.com/apache/spark/pull/29008#issuecomment-657830524 PTAL @MaxGekk :) This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29090: [WIP][SPARK-32293] Fix inconsistency between Spark memory configs and JVM option

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29090: URL: https://github.com/apache/spark/pull/29090#issuecomment-657820532 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #29090: [WIP][SPARK-32293] Fix inconsistency between Spark memory configs and JVM option

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29090: URL: https://github.com/apache/spark/pull/29090#issuecomment-657820520 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29090: [WIP][SPARK-32293] Fix inconsistency between Spark memory configs and JVM option

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29090: URL: https://github.com/apache/spark/pull/29090#issuecomment-657820520 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #29090: [WIP][SPARK-32293] Fix inconsistency between Spark memory configs and JVM option

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #29090: URL: https://github.com/apache/spark/pull/29090#issuecomment-657738943 **[Test build #125787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125787/testReport)** for PR 29090 at commit

[GitHub] [spark] SparkQA commented on pull request #29090: [WIP][SPARK-32293] Fix inconsistency between Spark memory configs and JVM option

2020-07-13 Thread GitBox
SparkQA commented on pull request #29090: URL: https://github.com/apache/spark/pull/29090#issuecomment-657819973 **[Test build #125787 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125787/testReport)** for PR 29090 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-657812860 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is l

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-657812860 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-657717862 **[Test build #125784 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125784/testReport)** for PR 28848 at commit

[GitHub] [spark] SparkQA commented on pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-13 Thread GitBox
SparkQA commented on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-657812167 **[Test build #125784 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125784/testReport)** for PR 28848 at commit

[GitHub] [spark] warrenzhu25 commented on pull request #28972: [SPARK-30794][CORE] Stage Level scheduling: Add ability to set off heap memory

2020-07-13 Thread GitBox
warrenzhu25 commented on pull request #28972: URL: https://github.com/apache/spark/pull/28972#issuecomment-657803725 > @warrenzhu25 can you look t the test failures - one might be related: > org.apache.spark.deploy.yarn.YarnSparkHadoopUtilSuite.executorMemoryOverhead when

[GitHub] [spark] rdblue commented on pull request #28864: [SPARK-32004][ALL] Drop references to slave

2020-07-13 Thread GitBox
rdblue commented on pull request #28864: URL: https://github.com/apache/spark/pull/28864#issuecomment-657803294 Thank you for making this happen, @holdenk! This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] warrenzhu25 commented on pull request #29082: [SPARK-32288][UI] Add exception summary for failed tasks in stage page

2020-07-13 Thread GitBox
warrenzhu25 commented on pull request #29082: URL: https://github.com/apache/spark/pull/29082#issuecomment-657800015 > Great improvement > > Would be nice to aggregate across similar exceptions that are only different in terms of literal values. E.g. in your screenshot, two

[GitHub] [spark] tianczha commented on a change in pull request #25342: [SPARK-28571][CORE][SHUFFLE] Use the shuffle writer plugin for the SortShuffleWriter

2020-07-13 Thread GitBox
tianczha commented on a change in pull request #25342: URL: https://github.com/apache/spark/pull/25342#discussion_r453939996 ## File path: core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleManager.scala ## @@ -157,7 +157,8 @@ private[spark] class

[GitHub] [spark] holdenk edited a comment on pull request #28864: [SPARK-32004][ALL] Drop references to slave

2020-07-13 Thread GitBox
holdenk edited a comment on pull request #28864: URL: https://github.com/apache/spark/pull/28864#issuecomment-657794256 Merged to primary branch. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] holdenk commented on pull request #28864: [SPARK-32004][ALL] Drop references to slave

2020-07-13 Thread GitBox
holdenk commented on pull request #28864: URL: https://github.com/apache/spark/pull/28864#issuecomment-657794256 Merged to master This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] asfgit closed pull request #28864: [SPARK-32004][ALL] Drop references to slave

2020-07-13 Thread GitBox
asfgit closed pull request #28864: URL: https://github.com/apache/spark/pull/28864 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29092: [SPARK-32295][SQL] Add not null and size > 0 filters before inner explode to benefit from predicate pushdown

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29092: URL: https://github.com/apache/spark/pull/29092#issuecomment-657793101 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins commented on pull request #29092: [SPARK-32295][SQL] Add not null and size > 0 filters before inner explode to benefit from predicate pushdown

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29092: URL: https://github.com/apache/spark/pull/29092#issuecomment-657793610 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #29092: [SPARK-32295][SQL] Add not null and size > 0 filters before inner explode to benefit from predicate pushdown

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29092: URL: https://github.com/apache/spark/pull/29092#issuecomment-657793101 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

<    1   2   3   4   5   6   7   >