[GitHub] spark pull request: [SPARK-15297] [SQL] Fix Set -V Command

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13081#issuecomment-219268076 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15297] [SQL] Fix Set -V Command

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13081#issuecomment-219268075 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15297] [SQL] Fix Set -V Command

2016-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13081#issuecomment-219268048 **[Test build #58610 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58610/consoleFull)** for PR 13081 at commit

[GitHub] spark pull request: [SPARK-15330] [SQL] Implement Reset Command

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13121#issuecomment-219265969 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15330] [SQL] Implement Reset Command

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13121#issuecomment-219265968 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15330] [SQL] Implement Reset Command

2016-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13121#issuecomment-219265948 **[Test build #58609 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58609/consoleFull)** for PR 13121 at commit

[GitHub] spark pull request: [SPARK-15297] [SQL] Fix Set -V Command

2016-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13081#issuecomment-219265793 **[Test build #58610 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58610/consoleFull)** for PR 13081 at commit

[GitHub] spark pull request: [SPARK-14130] [SQL] Throw exceptions for ALTER...

2016-05-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12714#discussion_r63285806 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -179,6 +173,11 @@ unsupportedHiveNativeCommands |

[GitHub] spark pull request: [SPARK-15330] [SQL] Implement Reset Command

2016-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13121#issuecomment-219263713 **[Test build #58609 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58609/consoleFull)** for PR 13121 at commit

[GitHub] spark pull request: [SPARK-15330] [SQL] Implement Reset Command

2016-05-14 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/13121 [SPARK-15330] [SQL] Implement Reset Command What changes were proposed in this pull request? Like `Set` Command in Hive, `Reset` is also supported by Hive. See the link:

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

2016-05-14 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/10125#discussion_r63284859 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala --- @@ -129,6 +129,23 @@ final class Decimal extends Ordered[Decimal] with

[GitHub] spark pull request: [SPARK-15318][ML][Example]:spark.ml Collaborat...

2016-05-14 Thread wangmiao1981
Github user wangmiao1981 commented on a diff in the pull request: https://github.com/apache/spark/pull/13110#discussion_r63284035 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/ALSExample.scala --- @@ -28,7 +28,7 @@ object ALSExample { // $example on$

[GitHub] spark pull request: [SPARK-15269][SQL] Set provided path to Catalo...

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13120#issuecomment-219253785 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15269][SQL] Set provided path to Catalo...

2016-05-14 Thread xwu0226
Github user xwu0226 commented on the pull request: https://github.com/apache/spark/pull/13120#issuecomment-219253654 cc @liancheng @yhuai @gatorsmile Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15269][SQL] Set provided path to Catalo...

2016-05-14 Thread xwu0226
GitHub user xwu0226 opened a pull request: https://github.com/apache/spark/pull/13120 [SPARK-15269][SQL] Set provided path to CatalogTable.storage.locationURI when creating external non-hive compatible table ## What changes were proposed in this pull request? ### Symptom

[GitHub] spark pull request: [SPARK-15328][MLLIB][ML] Word2Vec import for o...

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13119#issuecomment-219237391 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15328][MLLIB][ML] Word2Vec import for o...

2016-05-14 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/13119 [SPARK-15328][MLLIB][ML] Word2Vec import for original binary format ## What changes were proposed in this pull request? Add `loadGoogleModel()` function to import original wor2vec binary

[GitHub] spark pull request: [SPARK-12972] [CORE] Update org.apache.httpcom...

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13117#issuecomment-219230521 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12972] [CORE] Update org.apache.httpcom...

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13117#issuecomment-219230523 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12972] [CORE] Update org.apache.httpcom...

2016-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13117#issuecomment-219230470 **[Test build #58608 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58608/consoleFull)** for PR 13117 at commit

[GitHub] spark pull request: [SPARK-15304] [SPARK-15305] [SPARK-15306] [SQL...

2016-05-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12812#discussion_r63278723 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -64,6 +65,19 @@ class SparkSession private( | Session-related

[GitHub] spark pull request: [SPARK-15304] [SPARK-15305] [SPARK-15306] [SQL...

2016-05-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12812#discussion_r63277350 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -64,6 +65,19 @@ class SparkSession private( | Session-related

[GitHub] spark pull request: [SPARK-12972] [CORE] Update org.apache.httpcom...

2016-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13117#issuecomment-219224748 **[Test build #58608 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58608/consoleFull)** for PR 13117 at commit

[GitHub] spark pull request: update from orign

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13118#issuecomment-219223888 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: update from orign

2016-05-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/13118#issuecomment-219223860 @zhaorongsheng it seems it is open mistakenly. I guess this might have to be closed. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: update from orign

2016-05-14 Thread zhaorongsheng
GitHub user zhaorongsheng opened a pull request: https://github.com/apache/spark/pull/13118 update from orign ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch tested? (Please

[GitHub] spark pull request: [SPARK-12972] [CORE] Update org.apache.httpcom...

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13117#issuecomment-219223504 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12972] [CORE] Update org.apache.httpcom...

2016-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13117#issuecomment-219223502 **[Test build #58607 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58607/consoleFull)** for PR 13117 at commit

[GitHub] spark pull request: [SPARK-12972] [CORE] Update org.apache.httpcom...

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13117#issuecomment-219223505 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12972] [CORE] Update org.apache.httpcom...

2016-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13117#issuecomment-219223421 **[Test build #58607 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58607/consoleFull)** for PR 13117 at commit

[GitHub] spark pull request: [SPARK-12972] [CORE] Update org.apache.httpcom...

2016-05-14 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/13117#discussion_r63276920 --- Diff: sql/hive-thriftserver/pom.xml --- @@ -106,12 +111,6 @@ - --- End diff --

[GitHub] spark pull request: [SPARK-12972] [CORE] Update org.apache.httpcom...

2016-05-14 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/13117 [SPARK-12972] [CORE] Update org.apache.httpcomponents.httpclient ## What changes were proposed in this pull request? (Retry of https://github.com/apache/spark/pull/13049) - update

[GitHub] spark pull request: [SPARK-15319][SPARKR][DOCS] Fix SparkR doc lay...

2016-05-14 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/13109#issuecomment-219222873 This looks better. but the roxygen style is a little bit deviated. The previous is like: #' function name #' description Current is like: #'

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

2016-05-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10125#discussion_r63276327 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala --- @@ -321,11 +323,13 @@ object CatalystTypeConverters

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

2016-05-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10125#discussion_r63276311 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala --- @@ -129,6 +129,23 @@ final class Decimal extends Ordered[Decimal] with

[GitHub] spark pull request: [SPARK-15325][SQL] Replace the usage of deprec...

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13113#issuecomment-219216499 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15325][SQL] Replace the usage of deprec...

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13113#issuecomment-219216498 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15325][SQL] Replace the usage of deprec...

2016-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13113#issuecomment-219216467 **[Test build #58606 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58606/consoleFull)** for PR 13113 at commit

[GitHub] spark pull request: [SPARK-12492] Using spark-sql commond to run q...

2016-05-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/13115#issuecomment-219213787 (I think it would be nicer if the PR description is fill up.) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-15324] [SQL] Add the takeSample functio...

2016-05-14 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13116#discussion_r63274249 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -402,6 +402,76 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-15324] [SQL] Add the takeSample functio...

2016-05-14 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13116#discussion_r63274238 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -402,6 +402,76 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-15324] [SQL] Add the takeSample functio...

2016-05-14 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13116#discussion_r63274228 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -18,6 +18,9 @@ package org.apache.spark.sql import

[GitHub] spark pull request: [SPARK-15324] [SQL] Add the takeSample functio...

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13116#issuecomment-219213307 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15315][SQL] Adding error check to the C...

2016-05-14 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13105#discussion_r63274194 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/DefaultSource.scala --- @@ -172,4 +173,13 @@ class DefaultSource

[GitHub] spark pull request: [SPARK-15324] [SQL] Add the takeSample functio...

2016-05-14 Thread burness
GitHub user burness opened a pull request: https://github.com/apache/spark/pull/13116 [SPARK-15324] [SQL] Add the takeSample function to the Dataset ## What changes were proposed in this pull request? In this pr, I add the takeSample function with the Dataset which is to

[GitHub] spark pull request: [SPARK-12492] Using spark-sql commond to run q...

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13115#issuecomment-219213070 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12492] Using spark-sql commond to run q...

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13115#issuecomment-219213071 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12492] Using spark-sql commond to run q...

2016-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13115#issuecomment-219213068 **[Test build #58605 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58605/consoleFull)** for PR 13115 at commit

[GitHub] spark pull request: [SPARK-12492] Using spark-sql commond to run q...

2016-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13115#issuecomment-219212931 **[Test build #58605 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58605/consoleFull)** for PR 13115 at commit

[GitHub] spark pull request: [SPARK-15325][SQL] Replace the usage of deprec...

2016-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13113#issuecomment-219212927 **[Test build #58606 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58606/consoleFull)** for PR 13113 at commit

[GitHub] spark pull request: [SPARK-12492] Using spark-sql commond to run q...

2016-05-14 Thread KaiXinXiaoLei
Github user KaiXinXiaoLei commented on the pull request: https://github.com/apache/spark/pull/10900#issuecomment-219212923 @andrewor14 See https://github.com/apache/spark/pull/13115, --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-12492] Using spark-sql commond to run q...

2016-05-14 Thread KaiXinXiaoLei
Github user KaiXinXiaoLei closed the pull request at: https://github.com/apache/spark/pull/10900 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request: [SPARK-12492] Using spark-sql commond to run q...

2016-05-14 Thread KaiXinXiaoLei
GitHub user KaiXinXiaoLei opened a pull request: https://github.com/apache/spark/pull/13115 [SPARK-12492] Using spark-sql commond to run query, write the event of SparkListenerJobStart See https://github.com/apache/spark/pull/10900 ## What changes were proposed in this pull

[GitHub] spark pull request: Branch 1.4

2016-05-14 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/13114#issuecomment-219212846 Close this PR @GuoNing89 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Branch 1.4

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13114#issuecomment-219212714 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Branch 1.4

2016-05-14 Thread GuoNing89
GitHub user GuoNing89 opened a pull request: https://github.com/apache/spark/pull/13114 Branch 1.4 ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch tested? (Please explain how this

[GitHub] spark pull request: [SPARK-15325][SQL] Replace the usage of deprec...

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13113#issuecomment-219212380 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15325][SQL] Replace the usage of deprec...

2016-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13113#issuecomment-219212377 **[Test build #58604 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58604/consoleFull)** for PR 13113 at commit

[GitHub] spark pull request: [SPARK-15325][SQL] Replace the usage of deprec...

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13113#issuecomment-219212381 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15325][SQL] Replace the usage of deprec...

2016-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13113#issuecomment-219212325 **[Test build #58604 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58604/consoleFull)** for PR 13113 at commit

[GitHub] spark pull request: [SPARK-15325][SQL] Replace the usage of deprec...

2016-05-14 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/13113 [SPARK-15325][SQL] Replace the usage of deprecated DataSet API in tests (Scala/Java) ## What changes were proposed in this pull request? It seems `unionAll(other: Dataset[T])` and

[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

2016-05-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12969 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15197][Docs] Added Scaladoc for countAp...

2016-05-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12955 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

2016-05-14 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12969#issuecomment-219208737 Merged to master/2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15197][Docs] Added Scaladoc for countAp...

2016-05-14 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12955#issuecomment-219208684 Merged to master/2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15263][Core] Make shuffle service dir c...

2016-05-14 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/13042#issuecomment-219208629 This seems OK to me. There is actually another delete-recursively method in TestShuffleDataContext in network-shuffle which should be able to use this method rather

[GitHub] spark pull request: [SPARK-15318][ML][Example]:spark.ml Collaborat...

2016-05-14 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/13110#discussion_r63273137 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/ALSExample.scala --- @@ -28,7 +28,7 @@ object ALSExample { // $example on$

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-14 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219208034 Rather than change this in just a couple places, can you update all internal usages of the old accumulator API? --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-15323] Fix reading of partitioned forma...

2016-05-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/13104#issuecomment-219207979 Let me cc @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-14 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13112#discussion_r63272945 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/stopwatches.scala --- @@ -19,7 +19,8 @@ package org.apache.spark.ml.util import

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219207501 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219207485 **[Test build #58603 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58603/consoleFull)** for PR 13112 at commit

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219207500 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Fix reading of partitioned format=text dataset...

2016-05-14 Thread jurriaan
Github user jurriaan commented on the pull request: https://github.com/apache/spark/pull/13104#issuecomment-219207482 I'll create a JIRA just to be sure, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Fix reading of partitioned format=text dataset...

2016-05-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/13104#issuecomment-219207342 Oh, I just meant it changes codes to support partitioned table for text data source which seems disabled in Spark 2.0. It seems the guide says it does not a JIRA

[GitHub] spark pull request: Fix reading of partitioned format=text dataset...

2016-05-14 Thread jurriaan
Github user jurriaan commented on the pull request: https://github.com/apache/spark/pull/13104#issuecomment-219207031 @HyukjinKwon It's related to https://issues.apache.org/jira/browse/SPARK-14463. Or should I create a new JIRA? And how is this changing existing behaviour?

[GitHub] spark pull request: [SPARK-15222] [SparkR] [ML] SparkR ML examples...

2016-05-14 Thread JeremyNixon
Github user JeremyNixon commented on the pull request: https://github.com/apache/spark/pull/13000#issuecomment-219206838 As SparkR grows at some point it will make sense to split the docs into different files to separate out different parts of the library - do you think that it's

[GitHub] spark pull request: [SPARK-15222] [SparkR] [ML] SparkR ML examples...

2016-05-14 Thread JeremyNixon
Github user JeremyNixon commented on a diff in the pull request: https://github.com/apache/spark/pull/13000#discussion_r63272747 --- Diff: examples/src/main/r/ml.R --- @@ -25,30 +25,102 @@ library(SparkR) sc <- sparkR.init(appName="SparkR-ML-example") sqlContext <-

[GitHub] spark pull request: [SPARK-15222] [SparkR] [ML] SparkR ML examples...

2016-05-14 Thread JeremyNixon
Github user JeremyNixon commented on a diff in the pull request: https://github.com/apache/spark/pull/13000#discussion_r63272738 --- Diff: examples/src/main/r/ml.R --- @@ -25,30 +25,102 @@ library(SparkR) sc <- sparkR.init(appName="SparkR-ML-example") sqlContext <-

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219206065 **[Test build #58603 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58603/consoleFull)** for PR 13112 at commit

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-14 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219206010 Jenkins add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-14 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219204283 This looks good. ping @mengxr @jkbradley @MLnick Could you help to add @WeichenXu123 to whitelist? Thanks. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-15320] [SQL] Spark-SQL Cli Ignores Para...

2016-05-14 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13111#issuecomment-219204110 In the PR https://github.com/apache/spark/pull/12812, we mention we will not use `hive.metastore.warehouse.dir` to set the location. Thus, I think we should issue

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219204019 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-14 Thread WeichenXu123
GitHub user WeichenXu123 opened a pull request: https://github.com/apache/spark/pull/13112 [SPARK-15322][mllib]update deprecate accumulator usage into accumulatorV2 in mllib ## What changes were proposed in this pull request? MLlib code has two position use sc.accumulator

[GitHub] spark pull request: [SPARK-14979] [ML] [PySpark] Add examples for ...

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12754#issuecomment-219203483 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14979] [ML] [PySpark] Add examples for ...

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12754#issuecomment-219203482 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14979] [ML] [PySpark] Add examples for ...

2016-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12754#issuecomment-219203467 **[Test build #58602 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58602/consoleFull)** for PR 12754 at commit

[GitHub] spark pull request: [SPARK-15320] [SQL] Spark-SQL Cli Ignores Para...

2016-05-14 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13111#issuecomment-219203243 @yhuai @andrewor14 @rxin @liancheng **Question**: This PR is to set `spark.sql.warehouse.dir` by using the user-specified value of

[GitHub] spark pull request: [SPARK-14979] [ML] [PySpark] Add examples for ...

2016-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12754#issuecomment-219203197 **[Test build #58602 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58602/consoleFull)** for PR 12754 at commit