[GitHub] spark pull request #14109: [SPARK-16404][ML] LeastSquaresAggregators seriali...

2016-08-04 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/14109#discussion_r73644694 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -862,27 +873,30 @@ class LinearRegressionSummary

[GitHub] spark issue #14482: [SPARK-16879][SQL] unify logical plans for CREATE TABLE ...

2016-08-04 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14482 @cloud-fan Sure, will do. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73644536 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -374,20 +373,7 @@ private[hive] class HiveClientImpl(

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73644517 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -70,64 +69,16 @@ private[hive] class

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73644322 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -506,76 +495,16 @@ object DDLUtils { } /**

[GitHub] spark issue #14155: [SPARK-16498][SQL] move hive hack for data source table ...

2016-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14155 **[Test build #63257 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63257/consoleFull)** for PR 14155 at commit

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73644259 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -275,238 +269,21 @@ case class

[GitHub] spark issue #14109: [SPARK-16404][ML] LeastSquaresAggregators serializes unn...

2016-08-04 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/14109 @sethah In my opinion, I think using `@transient lazy val` is okay since there are only two places dereferencing the `lazy val`, and we don't use it in the tight loop. LGTM except one small

[GitHub] spark issue #14482: [SPARK-16879][SQL] unify logical plans for CREATE TABLE ...

2016-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14482 **[Test build #63256 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63256/consoleFull)** for PR 14482 at commit

[GitHub] spark pull request #14482: [SPARK-16879][SQL] unify logical plans for CREATE...

2016-08-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14482#discussion_r73643735 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -420,45 +420,40 @@ private[sql] abstract class

[GitHub] spark issue #14482: [SPARK-16879][SQL] unify logical plans for CREATE TABLE ...

2016-08-04 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14482 @gatorsmile how about keep working on them after this PR is merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #14109: [SPARK-16404][ML] LeastSquaresAggregators seriali...

2016-08-04 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/14109#discussion_r73643402 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -862,27 +873,30 @@ class LinearRegressionSummary

[GitHub] spark issue #13701: [SPARK-15639][SPARK-16321][SQL] Push down filter at RowG...

2016-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13701 **[Test build #63255 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63255/consoleFull)** for PR 13701 at commit

[GitHub] spark issue #13701: [SPARK-15639][SPARK-16321][SQL] Push down filter at RowG...

2016-08-04 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/13701 @davies I improved the test case by adding a SQL metrics. Please take a look. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #14503: [#SPARK-16911] Fix the links in the programming guide

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14503 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #14503: [#SPARK-16911] Fix the links in the programming g...

2016-08-04 Thread shiv4nsh
GitHub user shiv4nsh opened a pull request: https://github.com/apache/spark/pull/14503 [#SPARK-16911] Fix the links in the programming guide ## What changes were proposed in this pull request? Fix the broken links in the programming guide of the Graphx Migration and

[GitHub] spark issue #13701: [SPARK-15639][SPARK-16321][SQL] Push down filter at RowG...

2016-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13701 **[Test build #63254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63254/consoleFull)** for PR 13701 at commit

[GitHub] spark issue #12819: [SPARK-14077][ML] Refactor NaiveBayes to support weighte...

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12819 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63252/ Test PASSed. ---

[GitHub] spark issue #12819: [SPARK-14077][ML] Refactor NaiveBayes to support weighte...

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12819 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #12819: [SPARK-14077][ML] Refactor NaiveBayes to support weighte...

2016-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12819 **[Test build #63252 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63252/consoleFull)** for PR 12819 at commit

[GitHub] spark issue #13459: [SPARK-15726] [SQL] Make DatasetBenchmark fairer among D...

2016-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13459 **[Test build #63253 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63253/consoleFull)** for PR 13459 at commit

[GitHub] spark issue #14473: [SPARK-16495] [MLlib]Add ADMM optimizer in mllib package

2016-08-04 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/14473 @ZunwenYou Would you mind addressing the comments in the JIRA first? Adding a new optimization algorithm to an API that is now deprecated definitely warrants more high level discussion before code

[GitHub] spark issue #13459: [SPARK-15726] [SQL] Make DatasetBenchmark fairer among D...

2016-08-04 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13459 I'm not sure how to trigger a test manually, will check with my colleague later --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #13459: [SPARK-15726] [SQL] Make DatasetBenchmark fairer among D...

2016-08-04 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13459 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #14444: [SPARK-16839] [SQL] redundant aliases after cleanupAlias...

2016-08-04 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/1 Why? I think we only need to touch `Analyzer` and remove the execution logic from `CreateStruct`. Wherever we create `CreateStruct`, we just keep it, but replace(or resolve) it in Analyzer. ---

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73639529 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -301,9 +298,6 @@ case class AlterTableSerDePropertiesCommand(

[GitHub] spark issue #12819: [SPARK-14077][ML] Refactor NaiveBayes to support weighte...

2016-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12819 **[Test build #63252 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63252/consoleFull)** for PR 12819 at commit

[GitHub] spark issue #12819: [SPARK-14077][ML] Refactor NaiveBayes to support weighte...

2016-08-04 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/12819 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #14482: [SPARK-16879][SQL] unify logical plans for CREATE...

2016-08-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14482#discussion_r73638320 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala --- @@ -272,18 +259,15 @@ class CatalogImpl(sparkSession: SparkSession)

[GitHub] spark pull request #13680: [SPARK-15962][SQL] Introduce implementation with ...

2016-08-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13680#discussion_r73638020 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java --- @@ -25,30 +25,36 @@ import

[GitHub] spark issue #14502: [SPARK-16909][Spark Core] - Streaming for postgreSQL JDB...

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14502 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #13459: [SPARK-15726] [SQL] Make DatasetBenchmark fairer among D...

2016-08-04 Thread inouehrs
Github user inouehrs commented on the issue: https://github.com/apache/spark/pull/13459 From the participants list, it looks like @SparkQA is not checking this PR. Is there anyway to call attention of the jenkins system? --- If your project is set up for it, you can reply to this

[GitHub] spark pull request #14502: [SPARK-16909][Spark Core] - Streaming for postgre...

2016-08-04 Thread princejwesley
GitHub user princejwesley opened a pull request: https://github.com/apache/spark/pull/14502 [SPARK-16909][Spark Core] - Streaming for postgreSQL JDBC driver As per the postgreSQL JDBC driver

[GitHub] spark issue #12819: [SPARK-14077][ML] Refactor NaiveBayes to support weighte...

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12819 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63250/ Test FAILed. ---

[GitHub] spark issue #12819: [SPARK-14077][ML] Refactor NaiveBayes to support weighte...

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12819 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #12819: [SPARK-14077][ML] Refactor NaiveBayes to support weighte...

2016-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12819 **[Test build #63250 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63250/consoleFull)** for PR 12819 at commit

[GitHub] spark issue #14445: [SPARK-16907] [SQL] Fix performance regression for parqu...

2016-08-04 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14445 thanks. merging to master and 2.0! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14445: [SPARK-16907] [SQL] Fix performance regression fo...

2016-08-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14445 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14396: [SPARK-16787] SparkContext.addFile() should not throw if...

2016-08-04 Thread NYcleaner
Github user NYcleaner commented on the issue: https://github.com/apache/spark/pull/14396 Oh. sorry. I am a newer , thank you for your patience and help --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...

2016-08-04 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/13428 Two suggestions, otherwise I'm not familiar enough with Ivy - I'll trust you guys to know what you're doing. :-) --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request #13428: [SPARK-12666][CORE] SparkSubmit packages fix for ...

2016-08-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/13428#discussion_r73636009 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -891,10 +891,12 @@ private[spark] object SparkSubmitUtils { val

[GitHub] spark pull request #13428: [SPARK-12666][CORE] SparkSubmit packages fix for ...

2016-08-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/13428#discussion_r73636023 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -891,10 +891,12 @@ private[spark] object SparkSubmitUtils { val

[GitHub] spark issue #12694: [SPARK-14914] Fix Command too long for windows. Especial...

2016-08-04 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/12694 I'm not a fan of this approach. This means that every invocation of the launcher code will create temp files and have to deal with cleaning it up; except the launcher cannot do it, because the jvm

[GitHub] spark issue #12819: [SPARK-14077][ML] Refactor NaiveBayes to support weighte...

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12819 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #12819: [SPARK-14077][ML] Refactor NaiveBayes to support weighte...

2016-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12819 **[Test build #63251 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63251/consoleFull)** for PR 12819 at commit

[GitHub] spark issue #12819: [SPARK-14077][ML] Refactor NaiveBayes to support weighte...

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12819 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63251/ Test PASSed. ---

[GitHub] spark issue #12800: [SPARK-15024] NoClassDefFoundError in spark-examples due...

2016-08-04 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/12800 @atokhy that's a little weird. The examples module should be inheriting the guava shading from the parent pom. I have a 1.6 build locally (with patches, so I'll check the official package tomorrow)

[GitHub] spark issue #14491: [SPARK-16886] [EXAMPLES][SQL] structured streaming netwo...

2016-08-04 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14491 Oh, this is only about streaming examples. I can look at those in a separate PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #14491: [SPARK-16886] [EXAMPLES][SQL] structured streaming netwo...

2016-08-04 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14491 Could you look through these as below? at least I found one more. ``` src/main/java/org/apache/spark/examples/ml/JavaDecisionTreeClassificationExample.java: // Load the data

[GitHub] spark pull request #14156: [SPARK-16499][ML][MLLib] improve ApplyInPlace fun...

2016-08-04 Thread WeichenXu123
Github user WeichenXu123 closed the pull request at: https://github.com/apache/spark/pull/14156 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #14156: [SPARK-16499][ML][MLLib] improve ApplyInPlace function i...

2016-08-04 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/14156 @srowen OK I close the pr for now if I found better way to optimize it I will reopen it, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73633166 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -275,238 +269,21 @@ case class

[GitHub] spark issue #12819: [SPARK-14077][ML] Refactor NaiveBayes to support weighte...

2016-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12819 **[Test build #63251 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63251/consoleFull)** for PR 12819 at commit

[GitHub] spark pull request #14450: [SPARK-16847][SQL] Prevent to potentially read co...

2016-08-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14450#discussion_r73632453 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java --- @@ -204,7 +205,8 @@

[GitHub] spark issue #12819: [SPARK-14077][ML] Refactor NaiveBayes to support weighte...

2016-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12819 **[Test build #63250 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63250/consoleFull)** for PR 12819 at commit

[GitHub] spark issue #14467: [SPARK-16861][PYSPARK][CORE] Refactor PySpark accumulato...

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14467 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14467: [SPARK-16861][PYSPARK][CORE] Refactor PySpark accumulato...

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14467 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63248/ Test PASSed. ---

[GitHub] spark issue #14501: [SPARK-16906][SQL] Adds auxiliary info like input class ...

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14501 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63245/ Test PASSed. ---

[GitHub] spark issue #14501: [SPARK-16906][SQL] Adds auxiliary info like input class ...

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14501 Build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #14467: [SPARK-16861][PYSPARK][CORE] Refactor PySpark accumulato...

2016-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14467 **[Test build #63248 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63248/consoleFull)** for PR 14467 at commit

[GitHub] spark issue #14501: [SPARK-16906][SQL] Adds auxiliary info like input class ...

2016-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14501 **[Test build #63245 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63245/consoleFull)** for PR 14501 at commit

[GitHub] spark issue #14118: [SPARK-16462][SPARK-16460][SPARK-15144][SQL] Make CSV ca...

2016-08-04 Thread falaki
Github user falaki commented on the issue: https://github.com/apache/spark/pull/14118 @lw-lin thanks a lot for the clear summary. After seeing some use cases, I think it is better to apply nullValue to all types, including `StringType`. `treatEmptyValuesAsNulls` seems a special

[GitHub] spark issue #14501: [SPARK-16906][SQL] Adds auxiliary info like input class ...

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14501 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14501: [SPARK-16906][SQL] Adds auxiliary info like input class ...

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14501 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63249/ Test PASSed. ---

[GitHub] spark issue #14501: [SPARK-16906][SQL] Adds auxiliary info like input class ...

2016-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14501 **[Test build #63249 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63249/consoleFull)** for PR 14501 at commit

[GitHub] spark pull request #13680: [SPARK-15962][SQL] Introduce implementation with ...

2016-08-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13680#discussion_r73627677 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java --- @@ -25,30 +25,36 @@ import

[GitHub] spark issue #14500: [SPARK-] SQL DDL: MSCK REPAIR TABLE

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14500 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14500: [SPARK-] SQL DDL: MSCK REPAIR TABLE

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14500 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63246/ Test FAILed. ---

[GitHub] spark issue #14500: [SPARK-] SQL DDL: MSCK REPAIR TABLE

2016-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14500 **[Test build #63246 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63246/consoleFull)** for PR 14500 at commit

[GitHub] spark issue #14497: [SPARK-16901] Hive settings in hive-site.xml may be over...

2016-08-04 Thread clockfly
Github user clockfly commented on the issue: https://github.com/apache/spark/pull/14497 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #14498: [SPARK-16904] [SQL] Removal of Hive Built-in Hash Functi...

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14498 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63247/ Test PASSed. ---

[GitHub] spark issue #14498: [SPARK-16904] [SQL] Removal of Hive Built-in Hash Functi...

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14498 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14498: [SPARK-16904] [SQL] Removal of Hive Built-in Hash Functi...

2016-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14498 **[Test build #63247 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63247/consoleFull)** for PR 14498 at commit

[GitHub] spark issue #14499: [HOTFIX] Remove unnecessary imports from #12944 that bro...

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14499 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63241/ Test PASSed. ---

[GitHub] spark issue #14499: [HOTFIX] Remove unnecessary imports from #12944 that bro...

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14499 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14499: [HOTFIX] Remove unnecessary imports from #12944 that bro...

2016-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14499 **[Test build #63241 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63241/consoleFull)** for PR 14499 at commit

[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...

2016-08-04 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/9571 A few minor things left. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #9571: [SPARK-11373] [CORE] Add metrics to the History Se...

2016-08-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9571#discussion_r73624479 --- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala --- @@ -204,6 +204,8 @@ private[spark] class MetricsSystem private ( }

[GitHub] spark pull request #9571: [SPARK-11373] [CORE] Add metrics to the History Se...

2016-08-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9571#discussion_r73624457 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala --- @@ -226,6 +259,135 @@ class HistoryServer( } /** + *

[GitHub] spark pull request #9571: [SPARK-11373] [CORE] Add metrics to the History Se...

2016-08-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9571#discussion_r73624345 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -667,6 +710,123 @@ private[history] class FsHistoryProvider(conf:

[GitHub] spark pull request #9571: [SPARK-11373] [CORE] Add metrics to the History Se...

2016-08-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9571#discussion_r73624337 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -667,6 +710,123 @@ private[history] class FsHistoryProvider(conf:

[GitHub] spark pull request #9571: [SPARK-11373] [CORE] Add metrics to the History Se...

2016-08-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9571#discussion_r73624122 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -667,6 +700,90 @@ private[history] class FsHistoryProvider(conf:

[GitHub] spark issue #14500: [SPARK-] SQL DDL: MSCK REPAIR TABLE

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14500 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14500: [SPARK-] SQL DDL: MSCK REPAIR TABLE

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14500 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63244/ Test FAILed. ---

[GitHub] spark issue #14500: [SPARK-] SQL DDL: MSCK REPAIR TABLE

2016-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14500 **[Test build #63244 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63244/consoleFull)** for PR 14500 at commit

[GitHub] spark pull request #9571: [SPARK-11373] [CORE] Add metrics to the History Se...

2016-08-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9571#discussion_r73623900 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala --- @@ -226,6 +259,135 @@ class HistoryServer( } /** + *

[GitHub] spark issue #14499: [HOTFIX] Remove unnecessary imports from #12944 that bro...

2016-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14499 **[Test build #3203 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3203/consoleFull)** for PR 14499 at commit

[GitHub] spark issue #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor port rest...

2016-08-04 Thread mgummelt
Github user mgummelt commented on the issue: https://github.com/apache/spark/pull/11157 > How about the rest of the ports? Unused resources in an offer are implicitly declined. > We will have only one executor per job right? if they specify a port, then one executor per

[GitHub] spark pull request #9571: [SPARK-11373] [CORE] Add metrics to the History Se...

2016-08-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9571#discussion_r73623757 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala --- @@ -226,6 +259,135 @@ class HistoryServer( } /** + *

[GitHub] spark pull request #9571: [SPARK-11373] [CORE] Add metrics to the History Se...

2016-08-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9571#discussion_r73623780 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala --- @@ -226,6 +259,135 @@ class HistoryServer( } /** + *

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73623682 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -301,9 +298,6 @@ case class AlterTableSerDePropertiesCommand(

[GitHub] spark pull request #9571: [SPARK-11373] [CORE] Add metrics to the History Se...

2016-08-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9571#discussion_r73623629 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala --- @@ -114,28 +123,45 @@ class HistoryServer( * this UI with the

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73623489 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -229,10 +230,8 @@ case class AlterTableSetPropertiesCommand(

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73623449 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -229,10 +230,8 @@ case class AlterTableSetPropertiesCommand(

[GitHub] spark pull request #9571: [SPARK-11373] [CORE] Add metrics to the History Se...

2016-08-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9571#discussion_r73623442 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -667,6 +710,123 @@ private[history] class FsHistoryProvider(conf:

[GitHub] spark issue #14500: [SPARK-] SQL DDL: MSCK REPAIR TABLE

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14500 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63243/ Test FAILed. ---

[GitHub] spark issue #14500: [SPARK-] SQL DDL: MSCK REPAIR TABLE

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14500 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14500: [SPARK-] SQL DDL: MSCK REPAIR TABLE

2016-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14500 **[Test build #63243 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63243/consoleFull)** for PR 14500 at commit

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73622711 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/HiveSerDe.scala --- @@ -42,8 +41,7 @@ object HiveSerDe { HiveSerDe(

[GitHub] spark issue #14232: [SPARK-16587] [CORE] The annotation for the abstract Cla...

2016-08-04 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/14232 @f7753 I think just listing the message types here is not super useful. Yes, new messages were added and not mentioned in the documentation, but then adding just "foo is used by bar" doesn't really

  1   2   3   4   5   >