Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18538
@mgaido91 These are my last comments, it should be ready to merge once they
are addressed. Thanks for your contribution.
---
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18538#discussion_r138255937
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -0,0 +1,438 @@
+/*
+ * Licensed to the Apache
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18538#discussion_r138256035
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -0,0 +1,438 @@
+/*
+ * Licensed to the Apache
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18538#discussion_r138255648
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -0,0 +1,438 @@
+/*
+ * Licensed to the Apache
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18538#discussion_r138255474
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -0,0 +1,438 @@
+/*
+ * Licensed to the Apache
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19110
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19110
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81653/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19110
**[Test build #81653 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81653/testReport)**
for PR 19110 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19196
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81656/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19196
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19196
**[Test build #81656 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81656/testReport)**
for PR 19196 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19196
**[Test build #81656 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81656/testReport)**
for PR 19196 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19197
**[Test build #81654 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81654/testReport)**
for PR 19197 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16422
**[Test build #81655 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81655/testReport)**
for PR 16422 at commit
GitHub user zhengruifeng opened a pull request:
https://github.com/apache/spark/pull/19197
[SPARK-18608][ML] Fix double caching
## What changes were proposed in this pull request?
`df.rdd.getStorageLevel` => `df.storageLevel`
using cmd `find . -name '*.scala' | xargs -i
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16422
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19196
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19196
**[Test build #81652 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81652/testReport)**
for PR 19196 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19196
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81652/
Test FAILed.
---
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r138249937
--- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
@@ -152,6 +152,8 @@ def get$Name(self):
("varianceCol", "column name for
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19196
**[Test build #81652 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81652/testReport)**
for PR 19196 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19110
**[Test build #81653 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81653/testReport)**
for PR 19110 at commit
GitHub user brkyvz opened a pull request:
https://github.com/apache/spark/pull/19196
[SPARK-21977] SinglePartition optimizations break certain Streaming
Stateful Aggregation requirements
## What changes were proposed in this pull request?
This is a bit hard to explain as
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19195#discussion_r138249514
--- Diff: docs/building-spark.md ---
@@ -111,7 +111,7 @@ should run continuous compilation (i.e. wait for
changes). However, this has not
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19107
OK. Thanks @zhengruifeng .I will close this PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user WeichenXu123 closed the pull request at:
https://github.com/apache/spark/pull/19107
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18317
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18317
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81649/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18317
**[Test build #81649 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81649/testReport)**
for PR 18317 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18317
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18317
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81648/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18317
**[Test build #81648 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81648/testReport)**
for PR 18317 at commit
Github user caneGuy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19132#discussion_r138243757
--- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
@@ -50,6 +50,7 @@ private[spark] class SparkUI private (
val
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/19107
I am OK to resubmit the original PR if needed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/19186#discussion_r138243247
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -444,13 +444,13 @@ class
Github user caneGuy commented on the issue:
https://github.com/apache/spark/pull/19132
Yes i have confirmed.Below is a testing job: @jerryshao
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19186
**[Test build #81651 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81651/testReport)**
for PR 19186 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19186
**[Test build #81650 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81650/testReport)**
for PR 19186 at commit
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/16422
@gatorsmile @cloud-fan Fixed comments. Do you have time to take another
look?
---
-
To unsubscribe, e-mail:
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19132
Looks like I don't have the Jenkins permission to trigger UT ð . Let me
ping @srowen to trigger the test.
---
-
To
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19132#discussion_r138240053
--- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
@@ -50,6 +50,7 @@ private[spark] class SparkUI private (
val
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19132
ok to test.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19118#discussion_r138238318
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/SparkHadoopWriter.scala ---
@@ -112,11 +112,12 @@ object SparkHadoopWriter extends Logging {
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/19186#discussion_r138237760
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -483,24 +488,17 @@ class LogisticRegression
Github user goldmedal commented on a diff in the pull request:
https://github.com/apache/spark/pull/18875#discussion_r138237482
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
@@ -193,14 +223,35 @@ private[sql] class
Github user sitalkedia commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138230590
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java
---
@@ -72,10 +72,15 @@ public
Github user sitalkedia commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138231043
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License,
Github user sitalkedia commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138230901
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License,
Github user sitalkedia commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138230596
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java
---
@@ -72,10 +72,15 @@ public
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18875
Minor comments left, otherwise LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18875#discussion_r138233095
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/json/JacksonGeneratorSuite.scala
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/18853
CC @gatorsmile, @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18875#discussion_r138232491
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
@@ -193,14 +223,35 @@ private[sql] class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18317
**[Test build #81649 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81649/testReport)**
for PR 18317 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18317
**[Test build #81648 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81648/testReport)**
for PR 18317 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19192#discussion_r138228826
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -100,7 +100,7 @@ abstract class JdbcDialect extends Serializable {
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19192
Without this PR change, can users add quotes in the JDBC option `dbtable`?
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18875#discussion_r138228117
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
@@ -193,14 +223,35 @@ private[sql] class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18875#discussion_r138228185
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
@@ -193,14 +223,35 @@ private[sql] class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18875#discussion_r138228111
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
@@ -193,14 +223,35 @@ private[sql] class
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138225592
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138201871
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138207519
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138193555
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138225438
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138198506
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138207456
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138195259
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138194732
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138204793
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,292 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138200321
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,317 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138194101
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138189593
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java
---
@@ -72,10 +72,15 @@ public
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138189733
--- Diff:
core/src/test/java/org/apache/spark/io/GenericFileInputStreamSuite.java ---
@@ -50,17 +52,16 @@ public void tearDown() {
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138201264
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138188910
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java
---
@@ -72,10 +72,15 @@ public
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138195292
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138200201
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138194341
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138208239
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138198579
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19136#discussion_r138224219
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
---
@@ -0,0 +1,95 @@
+/*
+ * Licensed
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19136#discussion_r138224082
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
---
@@ -0,0 +1,39 @@
+/*
+ * Licensed
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19185#discussion_r138220213
--- Diff: python/pyspark/ml/tests.py ---
@@ -1473,11 +1473,59 @@ def test_logistic_regression_summary(self):
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19185#discussion_r138219915
--- Diff: python/pyspark/ml/tests.py ---
@@ -1473,11 +1473,59 @@ def test_logistic_regression_summary(self):
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19185#discussion_r138220005
--- Diff: python/pyspark/ml/tests.py ---
@@ -1473,11 +1473,59 @@ def test_logistic_regression_summary(self):
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19185#discussion_r138220297
--- Diff: python/pyspark/ml/classification.py ---
@@ -528,9 +528,11 @@ def summary(self):
trained on the training set. An exception is thrown if
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19188#discussion_r138221684
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
---
@@ -113,12 +114,39 @@ object TPCDSQueryBenchmark {
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/18592#discussion_r138220942
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
---
@@ -99,6 +95,20 @@ object TPCDSQueryBenchmark {
Github user devaraj-kavali commented on a diff in the pull request:
https://github.com/apache/spark/pull/19141#discussion_r138219530
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -565,7 +565,6 @@ private[spark] class Client(
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18945
Hey @logannc, have you had some time to work on this? I want to fix this
issue asap. Ortherwise, would anyone here be interested in submitimg another PR
for the another approach?
---
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19188#discussion_r138217212
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
---
@@ -113,12 +114,39 @@ object
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/19106
I'm confused how this issue was discovered in the first place. Did someone
actually train an RF/DT and receive all zero probabilities? If so, shouldn't
there be a unit test that recreates that
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18592#discussion_r138217049
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
---
@@ -99,6 +95,20 @@ object TPCDSQueryBenchmark
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19147#discussion_r138215300
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/VectorizedPythonRunner.scala
---
@@ -0,0 +1,329 @@
+/*
+ * Licensed to
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19107
@WeichenXu123 I just commented on
https://issues.apache.org/jira/browse/SPARK-18608 to clarify our efforts here.
Can you please either retarget this for SPARK-18608 and update it, or ask
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r138191841
--- Diff: core/src/main/scala/org/apache/spark/deploy/history/config.scala
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137942598
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -229,10 +254,22 @@ private[history] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137942907
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -316,25 +353,21 @@ private[history] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137940658
--- Diff: core/src/main/scala/org/apache/spark/deploy/history/config.scala
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software
1 - 100 of 366 matches
Mail list logo
