Github user Tagar commented on the issue:
https://github.com/apache/spark/pull/21121
Would this cover https://issues.apache.org/jira/browse/SPARK-23074 as well?
Thanks.
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21031
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21031
LGTM pending Jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user Tagar commented on the issue:
https://github.com/apache/spark/pull/21187
Would be great to make `FOR` section optional.
E.g. - make `FOR year IN (2012, 2013)` optional in one of your examples.
Currently `pivot()` when called programmatically, doesn't require to have
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r185166848
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,205 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r185163397
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,205 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r185163319
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,205 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r185166899
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,205 @@ case class
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/21189#discussion_r185167182
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/memoryV2.scala
---
@@ -178,7 +179,7 @@ class
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/21189#discussion_r185167132
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/MemorySinkSuite.scala
---
@@ -220,11 +220,11 @@ class MemorySinkSuite
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21193
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21203
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21141
Thank you, @HyukjinKwon!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21185
LGTM pending Jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/17086#discussion_r185163922
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/evaluation/MulticlassMetricsSuite.scala
---
@@ -95,4 +95,95 @@ class MulticlassMetricsSuite
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/17086#discussion_r185163674
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/evaluation/MulticlassMetricsSuite.scala
---
@@ -55,44 +60,128 @@ class MulticlassMetricsSuite
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/17086#discussion_r185163483
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/evaluation/MulticlassMetricsSuite.scala
---
@@ -95,4 +95,95 @@ class MulticlassMetricsSuite
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21158
Is the default `(?i)secret|password|url|user|username".r` merged to the
released branches? If the default is not in the previously release, I am fine
to change it back.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21203
This is moved from #21153 based on @jkbradley's suggestion.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21203
cc @jkbradley @HyukjinKwon @dbtsai
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/21203
[SPARK-24131][PySpark] Add majorMinorVersion API to PySpark for determining
Spark versions
## What changes were proposed in this pull request?
We need to determine Spark major and minor
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/21136
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/21136
LGTM. Merging to master. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/20929
@maropu Any updates?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21040
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21153#discussion_r185159691
--- Diff: python/pyspark/util.py ---
@@ -61,6 +62,26 @@ def _get_argspec(f):
return argspec
+def majorMinorVersion(version):
---
Github user Ngone51 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20604#discussion_r185159109
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1643,7 +1646,10 @@ class SparkContext(config: SparkConf) extends
Logging {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21198#discussion_r185158876
--- Diff: python/pyspark/streaming/tests.py ---
@@ -1549,7 +1549,9 @@ def search_kinesis_asl_assembly_jar():
kinesis_jar_present = True
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21198#discussion_r185158778
--- Diff: python/pyspark/streaming/tests.py ---
@@ -1549,7 +1549,9 @@ def search_kinesis_asl_assembly_jar():
kinesis_jar_present = True
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21198#discussion_r185156339
--- Diff: python/pyspark/streaming/tests.py ---
@@ -1549,7 +1549,9 @@ def search_kinesis_asl_assembly_jar():
kinesis_jar_present = True
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21158
> We are making a behavior change here.
We are *not*. That's the whole reason why I'm adding the SQL-specific
option to extend the behavior of the core options.
If I just wanted to
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21185
**[Test build #4161 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4161/testReport)**
for PR 21185 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21185
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jose-torres commented on the issue:
https://github.com/apache/spark/pull/21200
@HeartSaVioR
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/21200#discussion_r185153219
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/EpochPollRunnable.scala
---
@@ -0,0 +1,61 @@
+/*
+ *
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/21200#discussion_r185153197
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousDataSourceRDD.scala
---
@@ -0,0 +1,153 @@
+/*
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21141
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20973#discussion_r185149879
--- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/PrefixSpan.scala ---
@@ -44,26 +43,37 @@ object PrefixSpan {
*
* @param dataset
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21141
Merged to master and branch-2.3.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21200#discussion_r185147205
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/EpochPollRunnable.scala
---
@@ -0,0 +1,61 @@
+/*
+ *
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21200#discussion_r185148972
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousDataSourceRDD.scala
---
@@ -0,0 +1,153 @@
+/*
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21198#discussion_r185148928
--- Diff: python/pyspark/streaming/tests.py ---
@@ -1549,7 +1549,9 @@ def search_kinesis_asl_assembly_jar():
kinesis_jar_present = True
GitHub user devaraj-kavali opened a pull request:
https://github.com/apache/spark/pull/21202
[SPARK-24129] [K8S] Add option to pass --build-arg's to docker-image-tool.sh
## What changes were proposed in this pull request?
Adding `-b arg` option to take `--build-arg`
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21187
Thank you, @aray!
Thank you, @rxin, for the nice suggestion! Changes made accordingly in my
latest commit.
---
-
To
Github user maryannxue closed the pull request at:
https://github.com/apache/spark/pull/20613
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user henryr opened a pull request:
https://github.com/apache/spark/pull/21201
[SPARK-24128][SQL] Mention configuration option in implicit CROSS JOIN error
## What changes were proposed in this pull request?
Mention `spark.sql.crossJoin.enabled` in error message when
Github user ericl commented on the issue:
https://github.com/apache/spark/pull/21185
This makes sense to me. It would be slightly to clear it where where the
session is getting leaked through threads, but if that's hard then this looks
good.
---
Github user foxish commented on the issue:
https://github.com/apache/spark/pull/21095
The testing is not a blocker for the review. When I said "tests for
non-hostpath type volumes", I meant to say that we want to cover more than just
hostpath mounts with the initial PR - because we
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21185
cc @ericl too
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21158#discussion_r185143980
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -342,7 +342,7 @@ package object config {
"a property
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21185
**[Test build #4160 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4160/testReport)**
for PR 21185 at commit
Github user aray commented on the issue:
https://github.com/apache/spark/pull/21187
LGTM thanks for doing this!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21158#discussion_r185142687
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -342,7 +342,7 @@ package object config {
"a property
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21158
The confs in the core modules are not part of the outputs of SQL statement
`SET -v`, which only outputs the confs in Spark SQL.
We are making a behavior change here. I am not confident
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21197
test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21197
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user madanadit commented on the issue:
https://github.com/apache/spark/pull/21095
Hi @foxish, I don't see why the 2 testing concerns should block reviewing
this PR.
1. This PR does not attempt to address non-hostpath volumes (both
implementation and unit tests are hence
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21122
Thanks for pointing this out, @henryr. This looks like a good change to
support multiple catalogs.
I think it looks fine, other than exposing `unwrapped` to get the Hive
client. I think
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21122#discussion_r185138677
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -31,10 +30,16 @@ import
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/21153#discussion_r185131834
--- Diff: python/pyspark/util.py ---
@@ -61,6 +62,26 @@ def _get_argspec(f):
return argspec
+def majorMinorVersion(version):
Github user zecevicp commented on the issue:
https://github.com/apache/spark/pull/21109
The code path with the optimization but without wholegen code generation
gives wrong results. And I haven't been able to figure out where is the bug. I
spent several hours at this again today.
Github user jose-torres commented on the issue:
https://github.com/apache/spark/pull/21200
@tdas
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user jose-torres opened a pull request:
https://github.com/apache/spark/pull/21200
[SPARK-24039][SS] Do continuous processing writes with multiple compute()
calls
## What changes were proposed in this pull request?
Do continuous processing writes with multiple
Github user MrBago commented on the issue:
https://github.com/apache/spark/pull/21195
Looking now.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/spark/pull/21199
[SPARK-24127][SS] Continuous text socket source
## What changes were proposed in this pull request?
Support for text socket stream in spark structured streaming "continuous"
mode.
Github user rezasafi commented on the issue:
https://github.com/apache/spark/pull/20940
This generally looks good to me. I have some concerns about piggy backing
memory info on heart-beats, since basically this will be a uniform sampling of
memory info and it may make the heart-beat
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r185111225
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/config.scala
---
@@ -328,4 +328,18 @@ package object config {
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21196#discussion_r185115238
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -45,6 +45,7 @@ object DateTimeUtils {
// it's
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21196#discussion_r185114200
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -45,6 +45,7 @@ object DateTimeUtils {
//
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r185106176
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -170,8 +170,7 @@ class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r185110988
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocatorBlacklistTracker.scala
---
@@ -0,0 +1,150 @@
+/*
+ *
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r185110389
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocatorBlacklistTracker.scala
---
@@ -0,0 +1,150 @@
+/*
+ *
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r185106301
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/FailureTracker.scala
---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r185105266
--- Diff: core/src/test/scala/org/apache/spark/HeartbeatReceiverSuite.scala
---
@@ -73,6 +73,7 @@ class HeartbeatReceiverSuite
sc = spy(new
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r185110457
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocatorBlacklistTracker.scala
---
@@ -0,0 +1,150 @@
+/*
+ *
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r18531
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocatorBlacklistTracker.scala
---
@@ -0,0 +1,150 @@
+/*
+ *
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r185106409
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/FailureTracker.scala
---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r185113461
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocatorBlacklistTracker.scala
---
@@ -0,0 +1,150 @@
+/*
+ *
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r185112100
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocatorBlacklistTracker.scala
---
@@ -0,0 +1,150 @@
+/*
+ *
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r185109185
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/FailureTracker.scala
---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r185109769
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/FailureTracker.scala
---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r185110730
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocatorBlacklistTracker.scala
---
@@ -0,0 +1,150 @@
+/*
+ *
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r185110240
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
---
@@ -204,35 +182,23 @@ private[yarn] class
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21196#discussion_r185106149
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -45,6 +45,7 @@ object DateTimeUtils {
// it's
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21196#discussion_r185104899
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -45,6 +45,7 @@ object DateTimeUtils {
//
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21088
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21088
Merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21141
Thank you, @bersprockets .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/21198
[SPARK-24126][pyspark] Use build-specific temp directory for pyspark tests.
This avoids polluting and leaving garbage behind in /tmp, and allows the
usual build tools to clean up any leftover
Github user bersprockets commented on the issue:
https://github.com/apache/spark/pull/21141
My experience here is limited. Still, it also looks good to me.
---
-
To unsubscribe, e-mail:
Github user bersprockets commented on the issue:
https://github.com/apache/spark/pull/21073
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21185
**[Test build #4160 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4160/testReport)**
for PR 21185 at commit
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/21197
[SPARK-23971] [BACKPORT-2.3] Should not leak Spark sessions across test
suites
This PR is to backport the PR https://github.com/apache/spark/pull/21058 to
Apache 2.3. This should be the cause
Github user bersprockets commented on the issue:
https://github.com/apache/spark/pull/21073
@mn-mikke @kiszk Thanks for the review. I addressed the comments. Please
take a look when you have a chance.
---
-
To
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21196
cc @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21158
Ping @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21185
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21185
Tests haven't triggered, weird. LGTM pending tests.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21187#discussion_r185084802
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/PivotSuite.scala ---
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/21196
[SPARK-24123][SQL] Fix precision issues in monthsBetween with more than 8
digits
## What changes were proposed in this pull request?
SPARK-23902 introduced the ability to retrieve more
1 - 100 of 155 matches
Mail list logo
