[GitHub] [spark] SparkQA commented on pull request #28341: [SPARK-31552][SQL][2.4] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
SparkQA commented on pull request #28341: URL: https://github.com/apache/spark/pull/28341#issuecomment-619488232 **[Test build #121832 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121832/testReport)** for PR 28341 at commit

[GitHub] [spark] venkata91 commented on a change in pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative t

2020-04-25 Thread GitBox
venkata91 commented on a change in pull request #26339: URL: https://github.com/apache/spark/pull/26339#discussion_r415224131 ## File path: core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala ## @@ -236,13 +271,35 @@ class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28322: [SPARK-31550][SQL][DOCS] Set nondeterministic configurations with general meanings in sql configuration doc

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28322: URL: https://github.com/apache/spark/pull/28322#issuecomment-619486488 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #28322: [SPARK-31550][SQL][DOCS] Set nondeterministic configurations with general meanings in sql configuration doc

2020-04-25 Thread GitBox
SparkQA removed a comment on pull request #28322: URL: https://github.com/apache/spark/pull/28322#issuecomment-619486246 **[Test build #121830 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121830/testReport)** for PR 28322 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28341: [SPARK-31552][SQL][2.4] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28341: URL: https://github.com/apache/spark/pull/28341#issuecomment-619487334 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28322: [SPARK-31550][SQL][DOCS] Set nondeterministic configurations with general meanings in sql configuration doc

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28322: URL: https://github.com/apache/spark/pull/28322#issuecomment-619486399 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28341: [SPARK-31552][SQL][2.4] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28341: URL: https://github.com/apache/spark/pull/28341#issuecomment-619486381 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28341: [SPARK-31552][SQL][2.4] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
SparkQA commented on pull request #28341: URL: https://github.com/apache/spark/pull/28341#issuecomment-619487183 **[Test build #121831 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121831/testReport)** for PR 28341 at commit

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28341: [SPARK-31552][SQL][2.4] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
dongjoon-hyun commented on a change in pull request #28341: URL: https://github.com/apache/spark/pull/28341#discussion_r415224190 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -2649,4 +2652,75 @@ class DataFrameSuite extends QueryTest

[GitHub] [spark] dongjoon-hyun commented on pull request #28215: [SPARK-31272][SQL] Support DB2 Kerberos login in JDBC connector

2020-04-25 Thread GitBox
dongjoon-hyun commented on pull request #28215: URL: https://github.com/apache/spark/pull/28215#issuecomment-619487020 Sure, no rush for this because this is an integration test we will not revert this urgently. I just wondered this IT was tested or not when this PR was merged.

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28344: [SPARK-31564][TESTS] Fix flaky AllExecutionsPageSuite for checking 1970

2020-04-25 Thread GitBox
dongjoon-hyun edited a comment on pull request #28344: URL: https://github.com/apache/spark/pull/28344#issuecomment-619413624 Thank you all. Merged to master/3.0. This is an automated message from the Apache Git Service. To

[GitHub] [spark] dongjoon-hyun commented on pull request #28344: [SPARK-31564][TESTS] Fix flaky AllExecutionsPageSuite for checking 1970

2020-04-25 Thread GitBox
dongjoon-hyun commented on pull request #28344: URL: https://github.com/apache/spark/pull/28344#issuecomment-619486728 Right. Thank you. I fixed now. This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] SparkQA commented on pull request #28322: [SPARK-31550][SQL][DOCS] Set nondeterministic configurations with general meanings in sql configuration doc

2020-04-25 Thread GitBox
SparkQA commented on pull request #28322: URL: https://github.com/apache/spark/pull/28322#issuecomment-619486471 **[Test build #121830 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121830/testReport)** for PR 28322 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28322: [SPARK-31550][SQL][DOCS] Set nondeterministic configurations with general meanings in sql configuration doc

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28322: URL: https://github.com/apache/spark/pull/28322#issuecomment-619486482 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28341: [SPARK-31552][SQL][2.4] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
dongjoon-hyun commented on a change in pull request #28341: URL: https://github.com/apache/spark/pull/28341#discussion_r415223266 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -2649,4 +2652,75 @@ class DataFrameSuite extends QueryTest

[GitHub] [spark] AmplabJenkins commented on pull request #28341: [SPARK-31552][SQL][2.4] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28341: URL: https://github.com/apache/spark/pull/28341#issuecomment-619486381 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28341: [SPARK-31552][SQL][2.4] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
dongjoon-hyun commented on a change in pull request #28341: URL: https://github.com/apache/spark/pull/28341#discussion_r415223266 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -2649,4 +2652,75 @@ class DataFrameSuite extends QueryTest

[GitHub] [spark] AmplabJenkins commented on pull request #28322: [SPARK-31550][SQL][DOCS] Set nondeterministic configurations with general meanings in sql configuration doc

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28322: URL: https://github.com/apache/spark/pull/28322#issuecomment-619486399 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28322: [SPARK-31550][SQL][DOCS] Set nondeterministic configurations with general meanings in sql configuration doc

2020-04-25 Thread GitBox
SparkQA commented on pull request #28322: URL: https://github.com/apache/spark/pull/28322#issuecomment-619486246 **[Test build #121830 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121830/testReport)** for PR 28322 at commit

[GitHub] [spark] SparkQA commented on pull request #28341: [SPARK-31552][SQL][2.4] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
SparkQA commented on pull request #28341: URL: https://github.com/apache/spark/pull/28341#issuecomment-619486247 **[Test build #121829 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121829/testReport)** for PR 28341 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-619485646 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-619485646 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-25 Thread GitBox
SparkQA commented on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-619485464 **[Test build #121823 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121823/testReport)** for PR 28109 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-25 Thread GitBox
SparkQA removed a comment on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-619463130 **[Test build #121823 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121823/testReport)** for PR 28109 at commit

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28341: [SPARK-31552][SQL][2.4] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
dongjoon-hyun commented on a change in pull request #28341: URL: https://github.com/apache/spark/pull/28341#discussion_r415221539 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -2649,4 +2652,75 @@ class DataFrameSuite extends QueryTest

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-619484443 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-619484443 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-25 Thread GitBox
SparkQA removed a comment on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-619461110 **[Test build #121822 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121822/testReport)** for PR 28330 at commit

[GitHub] [spark] SparkQA commented on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-25 Thread GitBox
SparkQA commented on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-619484237 **[Test build #121822 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121822/testReport)** for PR 28330 at commit

[GitHub] [spark] yaooqinn commented on pull request #28344: [SPARK-31564][TESTS] Fix flaky AllExecutionsPageSuite for checking 1970

2020-04-25 Thread GitBox
yaooqinn commented on pull request #28344: URL: https://github.com/apache/spark/pull/28344#issuecomment-619484217 Thanks for merging @dongjoon-hyun. BTW, 2.4 should be 3.0. This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-619483843 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-619483843 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-04-25 Thread GitBox
SparkQA removed a comment on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-619460514 **[Test build #121821 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121821/testReport)** for PR 28123 at commit

[GitHub] [spark] SparkQA commented on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-04-25 Thread GitBox
SparkQA commented on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-619483650 **[Test build #121821 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121821/testReport)** for PR 28123 at commit

[GitHub] [spark] yqwang-ms commented on pull request #28323: [SPARK-31551][CORE] Fix createSparkUser lost user's non-Hadoop credentials

2020-04-25 Thread GitBox
yqwang-ms commented on pull request #28323: URL: https://github.com/apache/spark/pull/28323#issuecomment-619483304 @tgravescs @sryza @vanzin Related Contributors, could you please take a look at this? Thanks! This is an

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28341: [SPARK-31552][SQL][2.4] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28341: URL: https://github.com/apache/spark/pull/28341#issuecomment-619483266 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28341: [SPARK-31552][SQL][2.4] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28341: URL: https://github.com/apache/spark/pull/28341#issuecomment-619483266 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28341: [SPARK-31552][SQL][2.4] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
SparkQA commented on pull request #28341: URL: https://github.com/apache/spark/pull/28341#issuecomment-619483153 **[Test build #121828 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121828/testReport)** for PR 28341 at commit

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28342: [SPARK-31562][SQL] Update ExpressionDescription for substring, current_date, and current_timestamp

2020-04-25 Thread GitBox
dongjoon-hyun commented on a change in pull request #28342: URL: https://github.com/apache/spark/pull/28342#discussion_r415218045 ## File path: sql/gen-sql-functions-docs.py ## @@ -106,7 +106,7 @@ def _make_pretty_usage(infos): for info in infos: # Extracts

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28342: [SPARK-31562][SQL] Update ExpressionDescription for substring, current_date, and current_timestamp

2020-04-25 Thread GitBox
dongjoon-hyun commented on a change in pull request #28342: URL: https://github.com/apache/spark/pull/28342#discussion_r415217525 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -83,26 +93,44 @@ case class

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28342: [SPARK-31562][SQL] Update ExpressionDescription for substring, current_date, and current_timestamp

2020-04-25 Thread GitBox
dongjoon-hyun commented on a change in pull request #28342: URL: https://github.com/apache/spark/pull/28342#discussion_r415217525 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -83,26 +93,44 @@ case class

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28342: [SPARK-31562][SQL] Update ExpressionDescription for substring, current_date, and current_timestamp

2020-04-25 Thread GitBox
dongjoon-hyun commented on a change in pull request #28342: URL: https://github.com/apache/spark/pull/28342#discussion_r415217525 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -83,26 +93,44 @@ case class

[GitHub] [spark] yaooqinn commented on a change in pull request #28341: [SPARK-31552][SQL][2.4] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
yaooqinn commented on a change in pull request #28341: URL: https://github.com/apache/spark/pull/28341#discussion_r415217182 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -2649,4 +2652,75 @@ class DataFrameSuite extends QueryTest with

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative t

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-619482110 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-619482108 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative t

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-619482108 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-25 Thread GitBox
SparkQA removed a comment on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-619473475 **[Test build #121827 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121827/testReport)** for PR 26339 at commit

[GitHub] [spark] SparkQA commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-25 Thread GitBox
SparkQA commented on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-619482041 **[Test build #121827 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121827/testReport)** for PR 26339 at commit

[GitHub] [spark] gaborgsomogyi commented on pull request #28215: [SPARK-31272][SQL] Support DB2 Kerberos login in JDBC connector

2020-04-25 Thread GitBox
gaborgsomogyi commented on pull request #28215: URL: https://github.com/apache/spark/pull/28215#issuecomment-619481721 Logs would be helpful from test side and from docker instance side to see what have gone wrong. This is

[GitHub] [spark] gaborgsomogyi commented on pull request #28215: [SPARK-31272][SQL] Support DB2 Kerberos login in JDBC connector

2020-04-25 Thread GitBox
gaborgsomogyi commented on pull request #28215: URL: https://github.com/apache/spark/pull/28215#issuecomment-619481572 Is it fine to check it on Monday as a start? This is an automated message from the Apache Git Service. To

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28342: [SPARK-31562][SQL] Update ExpressionDescription for substring, current_date, and current_timestamp

2020-04-25 Thread GitBox
dongjoon-hyun commented on a change in pull request #28342: URL: https://github.com/apache/spark/pull/28342#discussion_r415215025 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -83,26 +93,44 @@ case class

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28341: [SPARK-31552][SQL][2.4] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
dongjoon-hyun commented on a change in pull request #28341: URL: https://github.com/apache/spark/pull/28341#discussion_r415214558 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -2649,4 +2652,75 @@ class DataFrameSuite extends QueryTest

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28341: [SPARK-31552][SQL][2.4] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
dongjoon-hyun commented on a change in pull request #28341: URL: https://github.com/apache/spark/pull/28341#discussion_r415214389 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -2649,4 +2652,75 @@ class DataFrameSuite extends QueryTest

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative t

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-619479646 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-619479646 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-25 Thread GitBox
SparkQA removed a comment on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-619466261 **[Test build #121825 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121825/testReport)** for PR 26339 at commit

[GitHub] [spark] SparkQA commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-25 Thread GitBox
SparkQA commented on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-619479444 **[Test build #121825 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121825/testReport)** for PR 26339 at commit

[GitHub] [spark] huaxingao commented on pull request #28348: [MINOR][SQL][DOCS] Remove two leading spaces from sql tables

2020-04-25 Thread GitBox
huaxingao commented on pull request #28348: URL: https://github.com/apache/spark/pull/28348#issuecomment-619478408 I plan to do one more sql ref PR for 3.0: modify sql-ref.html page to add more descriptions and also add links to each subsections. Then final check and clean-up. For the

[GitHub] [spark] xubo245 commented on pull request #13490: [SPARK-15722][SQL] Disallow specifying schema in CTAS statement

2020-04-25 Thread GitBox
xubo245 commented on pull request #13490: URL: https://github.com/apache/spark/pull/13490#issuecomment-619477803 Can CTAS support create table with schema? Already support: ``` create table t1(i1 int); insert into t1 select i2 from t2; ``` but don't support this: ```

[GitHub] [spark] xubo245 commented on pull request #25536: [SPARK-28837][SQL] CTAS/RTAS should use nullable schema

2020-04-25 Thread GitBox
xubo245 commented on pull request #25536: URL: https://github.com/apache/spark/pull/25536#issuecomment-619477673 Can CTAS support create table with schema? Already support: ``` create table t1(i1 int); insert into t1 select i2 from t2; ``` but don't support this: ```

[GitHub] [spark] xubo245 edited a comment on pull request #25536: [SPARK-28837][SQL] CTAS/RTAS should use nullable schema

2020-04-25 Thread GitBox
xubo245 edited a comment on pull request #25536: URL: https://github.com/apache/spark/pull/25536#issuecomment-619477673 Can CTAS support create table with schema? Already support: ``` create table t1(i1 int); insert into t1 select i2 from t2; ``` but don't support this:

[GitHub] [spark] gatorsmile commented on a change in pull request #26921: [SPARK-30282][SQL] Migrate SHOW TBLPROPERTIES to new framework

2020-04-25 Thread GitBox
gatorsmile commented on a change in pull request #26921: URL: https://github.com/apache/spark/pull/26921#discussion_r415205733 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ## @@ -900,22 +900,15 @@ case class

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28327: [SPARK-29664][PYTHON][SQL][FOLLOW-UP] Add deprecation warnings for getItem instead

2020-04-25 Thread GitBox
HyukjinKwon commented on a change in pull request #28327: URL: https://github.com/apache/spark/pull/28327#discussion_r415204996 ## File path: python/pyspark/sql/column.py ## @@ -296,12 +299,17 @@ def getItem(self, key): ++--+ | 1| value|

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28342: [SPARK-31562][SQL] Update ExpressionDescription for substring, current_date, and current_timestamp

2020-04-25 Thread GitBox
HyukjinKwon commented on a change in pull request #28342: URL: https://github.com/apache/spark/pull/28342#discussion_r415203732 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -62,7 +61,18 @@ trait

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28324: [SPARK-31552][SQL] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
HyukjinKwon commented on a change in pull request #28324: URL: https://github.com/apache/spark/pull/28324#discussion_r415202741 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -2358,6 +2360,80 @@ class DataFrameSuite extends QueryTest

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28322: [SPARK-31550][SQL][DOCS] Set nondeterministic configurations with general meanings in sql configuration doc

2020-04-25 Thread GitBox
HyukjinKwon commented on a change in pull request #28322: URL: https://github.com/apache/spark/pull/28322#discussion_r415200619 ## File path: sql/core/src/main/scala/org/apache/spark/sql/api/python/PythonSQLUtils.scala ## @@ -40,17 +40,27 @@ private[sql] object PythonSQLUtils

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28322: [SPARK-31550][SQL][DOCS] Set nondeterministic configurations with general meanings in sql configuration doc

2020-04-25 Thread GitBox
HyukjinKwon commented on a change in pull request #28322: URL: https://github.com/apache/spark/pull/28322#discussion_r415200272 ## File path: sql/core/src/main/scala/org/apache/spark/sql/api/python/PythonSQLUtils.scala ## @@ -40,17 +40,27 @@ private[sql] object PythonSQLUtils

[GitHub] [spark] AmplabJenkins commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-619473588 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative t

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-619473588 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-25 Thread GitBox
SparkQA commented on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-619473475 **[Test build #121827 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121827/testReport)** for PR 26339 at commit

[GitHub] [spark] zhengruifeng commented on pull request #27758: [SPARK-31007][ML] KMeans optimization based on triangle-inequality

2020-04-25 Thread GitBox
zhengruifeng commented on pull request #27758: URL: https://github.com/apache/spark/pull/27758#issuecomment-619472705 Thanks for reviewing! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28328: URL: https://github.com/apache/spark/pull/28328#issuecomment-619472164 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28328: URL: https://github.com/apache/spark/pull/28328#issuecomment-619472164 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-25 Thread GitBox
SparkQA commented on pull request #28328: URL: https://github.com/apache/spark/pull/28328#issuecomment-619472020 **[Test build #121826 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121826/testReport)** for PR 28328 at commit

[GitHub] [spark] maropu commented on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-25 Thread GitBox
maropu commented on pull request #28328: URL: https://github.com/apache/spark/pull/28328#issuecomment-619471634 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] turboFei commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-25 Thread GitBox
turboFei commented on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-619471276 Will apply this solution only with both dynamic partition overwrite and speculation are enabled. This is an

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28318: [SPARK-31535][SQL] Fix nested CTE substitution

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28318: URL: https://github.com/apache/spark/pull/28318#issuecomment-619470611 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28318: [SPARK-31535][SQL] Fix nested CTE substitution

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28318: URL: https://github.com/apache/spark/pull/28318#issuecomment-619470611 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28318: [SPARK-31535][SQL] Fix nested CTE substitution

2020-04-25 Thread GitBox
SparkQA removed a comment on pull request #28318: URL: https://github.com/apache/spark/pull/28318#issuecomment-619442248 **[Test build #121817 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121817/testReport)** for PR 28318 at commit

[GitHub] [spark] SparkQA commented on pull request #28318: [SPARK-31535][SQL] Fix nested CTE substitution

2020-04-25 Thread GitBox
SparkQA commented on pull request #28318: URL: https://github.com/apache/spark/pull/28318#issuecomment-619470420 **[Test build #121817 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121817/testReport)** for PR 28318 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28328: URL: https://github.com/apache/spark/pull/28328#issuecomment-619469008 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28328: URL: https://github.com/apache/spark/pull/28328#issuecomment-619469001 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28328: URL: https://github.com/apache/spark/pull/28328#issuecomment-619469001 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on a change in pull request #28342: [SPARK-31562][SQL] Update ExpressionDescription for substring, current_date, and current_timestamp

2020-04-25 Thread GitBox
maropu commented on a change in pull request #28342: URL: https://github.com/apache/spark/pull/28342#discussion_r415192404 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala ## @@ -404,7 +404,7 @@ object FunctionRegistry {

[GitHub] [spark] maropu commented on a change in pull request #28342: [SPARK-31562][SQL] Update ExpressionDescription for substring, current_date, and current_timestamp

2020-04-25 Thread GitBox
maropu commented on a change in pull request #28342: URL: https://github.com/apache/spark/pull/28342#discussion_r415192404 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala ## @@ -404,7 +404,7 @@ object FunctionRegistry {

[GitHub] [spark] SparkQA removed a comment on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-25 Thread GitBox
SparkQA removed a comment on pull request #28328: URL: https://github.com/apache/spark/pull/28328#issuecomment-619443113 **[Test build #121818 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121818/testReport)** for PR 28328 at commit

[GitHub] [spark] SparkQA commented on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-25 Thread GitBox
SparkQA commented on pull request #28328: URL: https://github.com/apache/spark/pull/28328#issuecomment-619468831 **[Test build #121818 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121818/testReport)** for PR 28328 at commit

[GitHub] [spark] maropu commented on pull request #28348: [MINOR][SQL][DOCS] Remove two leading spaces from sql tables

2020-04-25 Thread GitBox
maropu commented on pull request #28348: URL: https://github.com/apache/spark/pull/28348#issuecomment-619468597 I think its better to fix this issue in a final clean-up with other minor issues, e.g., typo. The current open documentation PRs are last ones for the 3.0 release?

[GitHub] [spark] AmplabJenkins commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-619466408 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative t

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-619466408 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-25 Thread GitBox
SparkQA commented on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-619466261 **[Test build #121825 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121825/testReport)** for PR 26339 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28348: [MINOR][SQL][DOCS] Remove two leading spaces from sql tables

2020-04-25 Thread GitBox
SparkQA removed a comment on pull request #28348: URL: https://github.com/apache/spark/pull/28348#issuecomment-619465000 **[Test build #121824 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121824/testReport)** for PR 28348 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28345: [SPARK-31557][SQL] Legacy time parser should return Gregorian days rather than Julian days

2020-04-25 Thread GitBox
SparkQA removed a comment on pull request #28345: URL: https://github.com/apache/spark/pull/28345#issuecomment-619440546 **[Test build #121816 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121816/testReport)** for PR 28345 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28348: [MINOR][SQL][DOCS] Remove two leading spaces from sql tables

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28348: URL: https://github.com/apache/spark/pull/28348#issuecomment-619465113 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28345: [SPARK-31557][SQL] Legacy time parser should return Gregorian days rather than Julian days

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28345: URL: https://github.com/apache/spark/pull/28345#issuecomment-619466079 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28345: [SPARK-31557][SQL] Legacy time parser should return Gregorian days rather than Julian days

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28345: URL: https://github.com/apache/spark/pull/28345#issuecomment-619466079 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28348: [MINOR][SQL][DOCS] Remove two leading spaces from sql tables

2020-04-25 Thread GitBox
SparkQA commented on pull request #28348: URL: https://github.com/apache/spark/pull/28348#issuecomment-619465880 **[Test build #121824 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121824/testReport)** for PR 28348 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28348: [MINOR][SQL][DOCS] Remove two leading spaces from sql tables

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28348: URL: https://github.com/apache/spark/pull/28348#issuecomment-619465909 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28345: [SPARK-31557][SQL] Legacy time parser should return Gregorian days rather than Julian days

2020-04-25 Thread GitBox
SparkQA commented on pull request #28345: URL: https://github.com/apache/spark/pull/28345#issuecomment-619465885 **[Test build #121816 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121816/testReport)** for PR 28345 at commit

[GitHub] [spark] huaxingao commented on pull request #28348: [MINOR][SQL][DOCS] Remove two leading spaces from sql tables

2020-04-25 Thread GitBox
huaxingao commented on pull request #28348: URL: https://github.com/apache/spark/pull/28348#issuecomment-619465506 cc @HyukjinKwon @maropu This is an automated message from the Apache Git Service. To respond to the message,

  1   2   3   4   >