[GitHub] [spark] turboFei edited a comment on pull request #29000: [SPARK-27194][SPARK-29302][SQL] Fix commit collision in dynamic partition overwrite mode

2020-07-05 Thread GitBox


turboFei edited a comment on pull request #29000:
URL: https://github.com/apache/spark/pull/29000#issuecomment-653996517


   Just left some comments.
   
   This PR did resolve the issue, it also involve some costs.
   In this pr, for dynamic partition overwrite mode.
   Each task might create multi partition paths under a unique task attempt 
output path.
   In fact, Dynamic partition overwrite always cause too many small files if 
user does not repartition by dynamic partition columns.
   So, I am afraid that this pr might cause lots of directories during runtime.
   
   I prefer #28989, in this PR, I define a Spark staging output committer based 
on the current implementation of HadoopMapReduceCommitProtocol.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence

2020-07-05 Thread GitBox


HyukjinKwon commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r449997164



##
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##
@@ -2612,6 +2612,11 @@ object Sequence {
   val stepDays = step.days
   val stepMicros = step.microseconds
 
+  if (scale == MICROS_PER_DAY && stepMonths == 0 && stepDays == 0) {
+throw new IllegalArgumentException(

Review comment:
   @TJX2014 can we just use `require` instead?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29006: [SPARK-32058][BUILD][SQL][test-hive1.2][FOLLOWUP] Set hadoop 2.7.4 for hive 1.2 profile

2020-07-05 Thread GitBox


dongjoon-hyun commented on a change in pull request #29006:
URL: https://github.com/apache/spark/pull/29006#discussion_r449997058



##
File path: pom.xml
##
@@ -3084,6 +3084,9 @@
 provided
 nohive
 3.2.10
+2.7.4
+2.7.1
+2.4

Review comment:
   Ya. This looks completely wrong.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29006: [SPARK-32058][BUILD][SQL][test-hive1.2][FOLLOWUP] Set hadoop 2.7.4 for hive 1.2 profile

2020-07-05 Thread GitBox


dongjoon-hyun commented on a change in pull request #29006:
URL: https://github.com/apache/spark/pull/29006#discussion_r449996397



##
File path: dev/run-tests-jenkins.py
##
@@ -183,6 +183,7 @@ def main():
 # Switch the Hive profile based on the PR title:
 if "test-hive1.2" in ghprb_pull_title:
 os.environ["AMPLAB_JENKINS_BUILD_HIVE_PROFILE"] = "hive1.2"
+os.environ["AMPLAB_JENKINS_BUILD_PROFILE"] = "hadoop2.7"

Review comment:
   Ya. +1 for @HyukjinKwon 's advice.
   
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #29007: [SPARK-XXXXX][SQL][DOCS] consistency in argument naming for time functions

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #29007:
URL: https://github.com/apache/spark/pull/29007#issuecomment-654028379







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #29007: [SPARK-XXXXX][SQL][DOCS] consistency in argument naming for time functions

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #29007:
URL: https://github.com/apache/spark/pull/29007#issuecomment-654028379







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #29007: [SPARK-XXXXX][SQL][DOCS] consistency in argument naming for time functions

2020-07-05 Thread GitBox


SparkQA commented on pull request #29007:
URL: https://github.com/apache/spark/pull/29007#issuecomment-654028341


   **[Test build #125030 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125030/testReport)**
 for PR 29007 at commit 
[`524023b`](https://github.com/apache/spark/commit/524023bfb22fa781e3a9321f8118992bb971da76).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28987: [SPARK-32162][PYTHON][TESTS] Improve error message of Pandas grouped map test with window

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28987:
URL: https://github.com/apache/spark/pull/28987#issuecomment-654026814


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125028/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28987: [SPARK-32162][PYTHON][TESTS] Improve error message of Pandas grouped map test with window

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28987:
URL: https://github.com/apache/spark/pull/28987#issuecomment-654026808


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28987: [SPARK-32162][PYTHON][TESTS] Improve error message of Pandas grouped map test with window

2020-07-05 Thread GitBox


SparkQA removed a comment on pull request #28987:
URL: https://github.com/apache/spark/pull/28987#issuecomment-654016556


   **[Test build #125028 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125028/testReport)**
 for PR 28987 at commit 
[`70da8b5`](https://github.com/apache/spark/commit/70da8b5299096942af5926b4222990e135ceffaa).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28987: [SPARK-32162][PYTHON][TESTS] Improve error message of Pandas grouped map test with window

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #28987:
URL: https://github.com/apache/spark/pull/28987#issuecomment-654026808







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28987: [SPARK-32162][PYTHON][TESTS] Improve error message of Pandas grouped map test with window

2020-07-05 Thread GitBox


SparkQA commented on pull request #28987:
URL: https://github.com/apache/spark/pull/28987#issuecomment-654026610


   **[Test build #125028 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125028/testReport)**
 for PR 28987 at commit 
[`70da8b5`](https://github.com/apache/spark/commit/70da8b5299096942af5926b4222990e135ceffaa).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] MichaelChirico opened a new pull request #29007: [SPARK-XXXXX][SQL][DOCS] consistency in argument naming for time functions

2020-07-05 Thread GitBox


MichaelChirico opened a new pull request #29007:
URL: https://github.com/apache/spark/pull/29007


   
   
   ### What changes were proposed in this pull request?
   
   
   Rename documented argument `format` as `fmt`, to match the same argument 
name in several other SQL date/time functions, to wit, `date_format`, 
`date_trunc`, `trunc`, `to_date`, and `to_timestamp` all use `fmt`. Also 
`format_string` and `printf` use the same abbreviation in their argument 
`strfmt`.
   
   ### Why are the changes needed?
   
   
   Consistency -- I was trying to scour the documentation for functions with 
arguments using Java string formatting, it would have been nice to rely on 
searching for `fmt` instead of my more manual approach.
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   In the documentation only
   
   ### How was this patch tested?
   
   
   No tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dilipbiswal commented on a change in pull request #28953: [SPARK-32013][SQL] Support query execution before/after reading/writing DataFrame over JDBC

2020-07-05 Thread GitBox


dilipbiswal commented on a change in pull request #28953:
URL: https://github.com/apache/spark/pull/28953#discussion_r449993229



##
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##
@@ -122,6 +122,37 @@ object JdbcUtils extends Logging {
 }
   }
 
+  /**
+   * Runs a custom query against a table from the JDBC database.
+   */
+  def runQuery(conn: Connection, actions: String, options: JDBCOptions): Unit 
= {
+val autoCommit = conn.getAutoCommit
+conn.setAutoCommit(false)
+val queries = actions.split(";")
+try {
+  queries.foreach { query =>
+val queryString = query.trim()
+val statement = conn.prepareStatement(queryString)
+try {
+  statement.setQueryTimeout(options.queryTimeout)
+  val hasResultSet = statement.execute()

Review comment:
   @moomindani 
   IMHO, the best behavior would be to only allow DDL or DML 
(insert/update/delete) in pre and post actions. But if its not achievable, then 
we have to clearly document what is allowed and ramifications of users 
specifying other kind of statements. Lets please get input from @maropu and 
@HyukjinKwon to decide on the best course to move forward.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-05 Thread GitBox


SparkQA commented on pull request #28683:
URL: https://github.com/apache/spark/pull/28683#issuecomment-654024002


   **[Test build #125029 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125029/testReport)**
 for PR 28683 at commit 
[`9af1413`](https://github.com/apache/spark/commit/9af1413c72bc857c465847db483f32e87fff167b).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on a change in pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

2020-07-05 Thread GitBox


HyukjinKwon commented on a change in pull request #28856:
URL: https://github.com/apache/spark/pull/28856#discussion_r449991321



##
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##
@@ -2623,8 +2625,16 @@ object Sequence {
 // about a month length in days and a day length in microseconds
 val intervalStepInMicros =
   stepMicros + stepMonths * microsPerMonth + stepDays * microsPerDay
-val startMicros: Long = num.toLong(start) * scale
-val stopMicros: Long = num.toLong(stop) * scale
+
+// Date to timestamp is not equal from GMT and Chicago timezones

Review comment:
   Why do these codes depend on few specific timezones? Also, other 
comments look valid here. We should take the timezone into account for 
timestamps too





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28683:
URL: https://github.com/apache/spark/pull/28683#issuecomment-654022208







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #28683:
URL: https://github.com/apache/spark/pull/28683#issuecomment-654022208







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28975: [SPARK-32148][SS] Fix stream-stream join issue on missing to copy reused unsafe row

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28975:
URL: https://github.com/apache/spark/pull/28975#issuecomment-654018986


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125017/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28975: [SPARK-32148][SS] Fix stream-stream join issue on missing to copy reused unsafe row

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28975:
URL: https://github.com/apache/spark/pull/28975#issuecomment-654018983


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28975: [SPARK-32148][SS] Fix stream-stream join issue on missing to copy reused unsafe row

2020-07-05 Thread GitBox


SparkQA removed a comment on pull request #28975:
URL: https://github.com/apache/spark/pull/28975#issuecomment-653998138


   **[Test build #125017 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125017/testReport)**
 for PR 28975 at commit 
[`be34258`](https://github.com/apache/spark/commit/be342583629147c537cda14ed1708c3653000b3f).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28975: [SPARK-32148][SS] Fix stream-stream join issue on missing to copy reused unsafe row

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #28975:
URL: https://github.com/apache/spark/pull/28975#issuecomment-654018983







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28975: [SPARK-32148][SS] Fix stream-stream join issue on missing to copy reused unsafe row

2020-07-05 Thread GitBox


SparkQA commented on pull request #28975:
URL: https://github.com/apache/spark/pull/28975#issuecomment-654018682


   **[Test build #125017 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125017/testReport)**
 for PR 28975 at commit 
[`be34258`](https://github.com/apache/spark/commit/be342583629147c537cda14ed1708c3653000b3f).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28987: [SPARK-32162][PYTHON][TESTS] Improve error message of Pandas grouped map test with window

2020-07-05 Thread GitBox


SparkQA commented on pull request #28987:
URL: https://github.com/apache/spark/pull/28987#issuecomment-654016556


   **[Test build #125028 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125028/testReport)**
 for PR 28987 at commit 
[`70da8b5`](https://github.com/apache/spark/commit/70da8b5299096942af5926b4222990e135ceffaa).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28987: [SPARK-32162][PYTHON][TESTS] Improve error message of Pandas grouped map test with window

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28987:
URL: https://github.com/apache/spark/pull/28987#issuecomment-654016487







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28987: [SPARK-32162][PYTHON][TESTS] Improve error message of Pandas grouped map test with window

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #28987:
URL: https://github.com/apache/spark/pull/28987#issuecomment-654016487







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] rxin commented on a change in pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-05 Thread GitBox


rxin commented on a change in pull request #28901:
URL: https://github.com/apache/spark/pull/28901#discussion_r449984452



##
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala
##
@@ -226,4 +227,22 @@ object StaticSQLConf {
   .version("3.0.0")
   .intConf
   .createWithDefault(100)
+
+  val SPARK_SCRATCH_DIR =
+buildStaticConf("spark.scratchdir")
+  .doc("Scratch space for Spark temporary table and so on. Similar with 
hive.exec.scratchdir")

Review comment:
   let's not bring up hive here. Slowly nobody will care about Hive.
   
   Also this should be spark.sql.scratchdir? 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] BryanCutler commented on pull request #28987: [SPARK-32162][PYTHON][TESTS] Improve error message of Pandas grouped map test with window

2020-07-05 Thread GitBox


BryanCutler commented on pull request #28987:
URL: https://github.com/apache/spark/pull/28987#issuecomment-654015077


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] rxin commented on a change in pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-05 Thread GitBox


rxin commented on a change in pull request #28901:
URL: https://github.com/apache/spark/pull/28901#discussion_r449984265



##
File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
##
@@ -3030,6 +3031,215 @@ abstract class DDLSuite extends QueryTest with 
SQLTestUtils {
   }
 }
   }
+
+  test("create temporary table using data source") {

Review comment:
   maybe create a new suite for these?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] gatorsmile commented on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-05 Thread GitBox


gatorsmile commented on pull request #28901:
URL: https://github.com/apache/spark/pull/28901#issuecomment-654013787


   For a proper support, this requires more discussions about the semantics. 
   
   Also, we need to list the expected behaviors for all the statements listed 
in https://spark.apache.org/docs/latest/sql-ref-syntax.html . 
   
   So far, this PR and design doc does not have the corresponding contents. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28998: [SPARK-32173][SQL] Deduplicate code in FromUTCTimestamp and ToUTCTimestamp

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #28998:
URL: https://github.com/apache/spark/pull/28998#issuecomment-654012996







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #27366:
URL: https://github.com/apache/spark/pull/27366#issuecomment-654013004







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28998: [SPARK-32173][SQL] Deduplicate code in FromUTCTimestamp and ToUTCTimestamp

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28998:
URL: https://github.com/apache/spark/pull/28998#issuecomment-654012996







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #27366:
URL: https://github.com/apache/spark/pull/27366#issuecomment-654013004







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28998: [SPARK-32173][SQL] Deduplicate code in FromUTCTimestamp and ToUTCTimestamp

2020-07-05 Thread GitBox


SparkQA commented on pull request #28998:
URL: https://github.com/apache/spark/pull/28998#issuecomment-654012820


   **[Test build #125026 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125026/testReport)**
 for PR 28998 at commit 
[`e06fb0c`](https://github.com/apache/spark/commit/e06fb0cb1fccee2e0159dbbe5618dcf53d1a4304).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-07-05 Thread GitBox


SparkQA commented on pull request #27366:
URL: https://github.com/apache/spark/pull/27366#issuecomment-654012834


   **[Test build #125027 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125027/testReport)**
 for PR 27366 at commit 
[`0a133ad`](https://github.com/apache/spark/commit/0a133ad87a27cd53efc2f13e4cae04ec4affef94).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] MaxGekk commented on pull request #28998: [SPARK-32173][SQL] Deduplicate code in FromUTCTimestamp and ToUTCTimestamp

2020-07-05 Thread GitBox


MaxGekk commented on pull request #28998:
URL: https://github.com/apache/spark/pull/28998#issuecomment-654012550


   jenkins, retest this, please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28965: [SPARK-32124][CORE][FOLLOW-UP] Use the invalid value Int.MinValue to fill the map index when the event logs from the old Spark

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28965:
URL: https://github.com/apache/spark/pull/28965#issuecomment-654011803


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124972/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28965: [SPARK-32124][CORE][FOLLOW-UP] Use the invalid value Int.MinValue to fill the map index when the event logs from the old Spark

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28965:
URL: https://github.com/apache/spark/pull/28965#issuecomment-654011795


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28987: [SPARK-32162][PYTHON][TESTS] Improve error message of Pandas grouped map test with window

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28987:
URL: https://github.com/apache/spark/pull/28987#issuecomment-654011649


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125020/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] MaxGekk commented on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-07-05 Thread GitBox


MaxGekk commented on pull request #27366:
URL: https://github.com/apache/spark/pull/27366#issuecomment-654012258


   jenkins, retest this, please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28987: [SPARK-32162][PYTHON][TESTS] Improve error message of Pandas grouped map test with window

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28987:
URL: https://github.com/apache/spark/pull/28987#issuecomment-654011647


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28965: [SPARK-32124][CORE][FOLLOW-UP] Use the invalid value Int.MinValue to fill the map index when the event logs from the old Spark version

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #28965:
URL: https://github.com/apache/spark/pull/28965#issuecomment-654011795







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28987: [SPARK-32162][PYTHON][TESTS] Improve error message of Pandas grouped map test with window

2020-07-05 Thread GitBox


SparkQA removed a comment on pull request #28987:
URL: https://github.com/apache/spark/pull/28987#issuecomment-654002469


   **[Test build #125020 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125020/testReport)**
 for PR 28987 at commit 
[`70da8b5`](https://github.com/apache/spark/commit/70da8b5299096942af5926b4222990e135ceffaa).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28987: [SPARK-32162][PYTHON][TESTS] Improve error message of Pandas grouped map test with window

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #28987:
URL: https://github.com/apache/spark/pull/28987#issuecomment-654011647







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28987: [SPARK-32162][PYTHON][TESTS] Improve error message of Pandas grouped map test with window

2020-07-05 Thread GitBox


SparkQA commented on pull request #28987:
URL: https://github.com/apache/spark/pull/28987#issuecomment-654011509


   **[Test build #125020 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125020/testReport)**
 for PR 28987 at commit 
[`70da8b5`](https://github.com/apache/spark/commit/70da8b5299096942af5926b4222990e135ceffaa).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654010108







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28676:
URL: https://github.com/apache/spark/pull/28676#issuecomment-654010132







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28996:
URL: https://github.com/apache/spark/pull/28996#issuecomment-654010095







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #28996:
URL: https://github.com/apache/spark/pull/28996#issuecomment-654010095







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #28676:
URL: https://github.com/apache/spark/pull/28676#issuecomment-654010132







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28957: [WIP][SPARK-32138] Drop Python 2.7, 3.4 and 3.5

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28957:
URL: https://github.com/apache/spark/pull/28957#issuecomment-654010074







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654010108







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654010051







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28957: [WIP][SPARK-32138] Drop Python 2.7, 3.4 and 3.5

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #28957:
URL: https://github.com/apache/spark/pull/28957#issuecomment-654010074







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-05 Thread GitBox


SparkQA commented on pull request #28676:
URL: https://github.com/apache/spark/pull/28676#issuecomment-654010078


   **[Test build #125025 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125025/testReport)**
 for PR 28676 at commit 
[`c5f4803`](https://github.com/apache/spark/commit/c5f48032907dc5b550d410984254015e4e3ae235).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654010051







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28996:
URL: https://github.com/apache/spark/pull/28996#issuecomment-654007350


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124924/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

2020-07-05 Thread GitBox


SparkQA commented on pull request #28996:
URL: https://github.com/apache/spark/pull/28996#issuecomment-654009977


   **[Test build #125022 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125022/testReport)**
 for PR 28996 at commit 
[`5e4f670`](https://github.com/apache/spark/commit/5e4f67002955fa0536498df6657b5db5b17b0d56).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28957: [WIP][SPARK-32138] Drop Python 2.7, 3.4 and 3.5

2020-07-05 Thread GitBox


SparkQA commented on pull request #28957:
URL: https://github.com/apache/spark/pull/28957#issuecomment-654009974


   **[Test build #125023 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125023/testReport)**
 for PR 28957 at commit 
[`63c6259`](https://github.com/apache/spark/commit/63c6259e4246481932a7909ced63f6332a035195).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate

2020-07-05 Thread GitBox


SparkQA commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654009975


   **[Test build #125021 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125021/testReport)**
 for PR 28999 at commit 
[`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression

2020-07-05 Thread GitBox


SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654009976


   **[Test build #125024 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125024/testReport)**
 for PR 28808 at commit 
[`3e116f5`](https://github.com/apache/spark/commit/3e116f5f3284b22eec712990d271751b799f4ece).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28939:
URL: https://github.com/apache/spark/pull/28939#issuecomment-654009493


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #28939:
URL: https://github.com/apache/spark/pull/28939#issuecomment-654009493







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654007432


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124949/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28965: [SPARK-32124][CORE][FOLLOW-UP] Use the invalid value Int.MinValue to fill the map index when the event logs from the old Spark versio

2020-07-05 Thread GitBox


SparkQA removed a comment on pull request #28965:
URL: https://github.com/apache/spark/pull/28965#issuecomment-653946807


   **[Test build #124972 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124972/testReport)**
 for PR 28965 at commit 
[`9dfa5c0`](https://github.com/apache/spark/commit/9dfa5c0d2a5cbbaefe3f062549e69b911ee6a2ea).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28965: [SPARK-32124][CORE][FOLLOW-UP] Use the invalid value Int.MinValue to fill the map index when the event logs from the old Spark version

2020-07-05 Thread GitBox


SparkQA commented on pull request #28965:
URL: https://github.com/apache/spark/pull/28965#issuecomment-654009489


   **[Test build #124972 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124972/testReport)**
 for PR 28965 at commit 
[`9dfa5c0`](https://github.com/apache/spark/commit/9dfa5c0d2a5cbbaefe3f062549e69b911ee6a2ea).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression

2020-07-05 Thread GitBox


HyukjinKwon commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654009435


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] imback82 commented on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-05 Thread GitBox


imback82 commented on pull request #28676:
URL: https://github.com/apache/spark/pull/28676#issuecomment-654009122


   Retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #28957: [WIP][SPARK-32138] Drop Python 2.7, 3.4 and 3.5

2020-07-05 Thread GitBox


HyukjinKwon commented on pull request #28957:
URL: https://github.com/apache/spark/pull/28957#issuecomment-654008930


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28963: [SPARK-32145][SQL][test-hive1.2][test-hadoop2.7] ThriftCLIService.GetOperationStatus should include exception's stack trace to

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28963:
URL: https://github.com/apache/spark/pull/28963#issuecomment-654008449


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125008/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate

2020-07-05 Thread GitBox


HyukjinKwon commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654008663


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28963: [SPARK-32145][SQL][test-hive1.2][test-hadoop2.7] ThriftCLIService.GetOperationStatus should include exception's stack trace to the erro

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #28963:
URL: https://github.com/apache/spark/pull/28963#issuecomment-654008445







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654008050


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125014/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28963: [SPARK-32145][SQL][test-hive1.2][test-hadoop2.7] ThriftCLIService.GetOperationStatus should include exception's stack trace to

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28963:
URL: https://github.com/apache/spark/pull/28963#issuecomment-654008445


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on a change in pull request #28983: [SPARK-32159][SQL] Fix integration between Aggregator[Array[_], _, _] and UnresolvedMapObjects

2020-07-05 Thread GitBox


HyukjinKwon commented on a change in pull request #28983:
URL: https://github.com/apache/spark/pull/28983#discussion_r449977725



##
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/udaf.scala
##
@@ -27,9 +27,12 @@ import 
org.apache.spark.sql.catalyst.expressions.{AttributeReference, Expression
 import 
org.apache.spark.sql.catalyst.expressions.aggregate.{AggregateExpression, 
Complete}
 import 
org.apache.spark.sql.catalyst.expressions.aggregate.{ImperativeAggregate, 
TypedImperativeAggregate}
 import 
org.apache.spark.sql.catalyst.expressions.codegen.{GenerateMutableProjection, 
GenerateSafeProjection}
+import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
+import org.apache.spark.sql.catalyst.rules.Rule
 import org.apache.spark.sql.expressions.{Aggregator, MutableAggregationBuffer, 
UserDefinedAggregateFunction}
 import org.apache.spark.sql.types._
 
+

Review comment:
   nit: I wouldn't change these newlines to make it easier to port it back 
or revert in the future.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28986: [SPARK-32160][CORE][PYSPARK] Disallow to create SparkContext in executors.

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28986:
URL: https://github.com/apache/spark/pull/28986#issuecomment-654008225


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #29001: [SPARK-32100][CORE][TESTS][FOLLOWUP] Reduce the required test resources

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #29001:
URL: https://github.com/apache/spark/pull/29001#issuecomment-654007939


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125010/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28986: [SPARK-32160][CORE][PYSPARK] Disallow to create SparkContext in executors.

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #28986:
URL: https://github.com/apache/spark/pull/28986#issuecomment-654008225







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654008047


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28963: [SPARK-32145][SQL][test-hive1.2][test-hadoop2.7] ThriftCLIService.GetOperationStatus should include exception's stack trace to the er

2020-07-05 Thread GitBox


SparkQA removed a comment on pull request #28963:
URL: https://github.com/apache/spark/pull/28963#issuecomment-653989962


   **[Test build #125008 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125008/testReport)**
 for PR 28963 at commit 
[`d72074a`](https://github.com/apache/spark/commit/d72074aff830c670685278eb40b08df1237f7c66).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28970: [SPARK-31723][CORE][TEST] Reenable one test case in HistoryServerSuite

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28970:
URL: https://github.com/apache/spark/pull/28970#issuecomment-654007867


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28963: [SPARK-32145][SQL][test-hive1.2][test-hadoop2.7] ThriftCLIService.GetOperationStatus should include exception's stack trace to the error mess

2020-07-05 Thread GitBox


SparkQA commented on pull request #28963:
URL: https://github.com/apache/spark/pull/28963#issuecomment-654008184


   **[Test build #125008 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125008/testReport)**
 for PR 28963 at commit 
[`d72074a`](https://github.com/apache/spark/commit/d72074aff830c670685278eb40b08df1237f7c66).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #29001: [SPARK-32100][CORE][TESTS][FOLLOWUP] Reduce the required test resources

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #29001:
URL: https://github.com/apache/spark/pull/29001#issuecomment-654007935


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654008047







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #29001: [SPARK-32100][CORE][TESTS][FOLLOWUP] Reduce the required test resources

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #29001:
URL: https://github.com/apache/spark/pull/29001#issuecomment-654007935







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28970: [SPARK-31723][CORE][TEST] Reenable one test case in HistoryServerSuite

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #28970:
URL: https://github.com/apache/spark/pull/28970#issuecomment-654007867







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions Catalog APIs on DataSourceV2

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28617:
URL: https://github.com/apache/spark/pull/28617#issuecomment-654007516


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124963/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28969:
URL: https://github.com/apache/spark/pull/28969#issuecomment-654007647


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #29001: [SPARK-32100][CORE][TESTS][FOLLOWUP] Reduce the required test resources

2020-07-05 Thread GitBox


SparkQA removed a comment on pull request #29001:
URL: https://github.com/apache/spark/pull/29001#issuecomment-653992216


   **[Test build #125010 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125010/testReport)**
 for PR 29001 at commit 
[`3790334`](https://github.com/apache/spark/commit/3790334a4f46852f02ba9820fe74fed31d7a636b).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #28969:
URL: https://github.com/apache/spark/pull/28969#issuecomment-654007647







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654007425


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions Catalog APIs on DataSourceV2

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28617:
URL: https://github.com/apache/spark/pull/28617#issuecomment-654007514


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate

2020-07-05 Thread GitBox


SparkQA removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653993190


   **[Test build #125014 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125014/testReport)**
 for PR 28999 at commit 
[`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28841: [SPARK-31962][SQL] Provide option to load files after a specified date when reading from a folder path

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-654007411


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions Catalog APIs on DataSourceV2

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #28617:
URL: https://github.com/apache/spark/pull/28617#issuecomment-654007514







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654007425







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

2020-07-05 Thread GitBox


AmplabJenkins removed a comment on pull request #28996:
URL: https://github.com/apache/spark/pull/28996#issuecomment-654007344


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate

2020-07-05 Thread GitBox


SparkQA commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654007490


   **[Test build #125014 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125014/testReport)**
 for PR 28999 at commit 
[`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28841: [SPARK-31962][SQL] Provide option to load files after a specified date when reading from a folder path

2020-07-05 Thread GitBox


AmplabJenkins commented on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-654007411







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



  1   2   3   4   5   6   7   8   9   10   >