Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/13381#discussion_r65206320
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/IsotonicRegressionExample.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/13381#discussion_r65207453
--- Diff: docs/ml-classification-regression.md ---
@@ -685,6 +685,88 @@ The implementation matches the result from R's
survival function
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/13381#discussion_r65207910
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaIsotonicRegressionExample.java
---
@@ -0,0 +1,77 @@
+/*
+ * Licensed
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/13381#discussion_r65207877
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaIsotonicRegressionExample.java
---
@@ -0,0 +1,77 @@
+/*
+ * Licensed
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/13353
cc @mengxr @jkbradley
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12731
ping @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/13023
@vectorijk There is a separate PR focus on updating machine learning
section of SparkR users guide. FYI #13285. Thanks.
---
If your project is set up for it, you can reply to this email
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/13410#discussion_r65192762
--- Diff: python/pyspark/ml/feature.py ---
@@ -1481,6 +1474,10 @@ class StandardScaler(JavaEstimator, HasInputCol,
HasOutputCol, JavaMLReadable, J
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/13675
[SPARK-15957] [ML] RFormula supports forcing to index label
## What changes were proposed in this pull request?
Add param to make users can force to index label whether it is numeric
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/13662
It looks like the merge script is not happy, I will retry later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/13662
LGTM, merged into master and branch-2.0. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/13675
cc @mengxr @jkbradley
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/13381
Merged into master and branch-2.0. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/13381
Merged into master and branch-2.0. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/13731
LGTM, merged into master and branch-2.0. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/13641
@MLnick I found you did not add ```@Since``` for all params definition, is
this as expectedï¼I think we should add them.
---
If your project is set up for it, you can reply to this email
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/13641#discussion_r67245508
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/MaxAbsScaler.scala ---
@@ -88,7 +91,7 @@ class MaxAbsScaler @Since("2.0.0") (overri
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/13641#discussion_r67245105
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/MaxAbsScaler.scala ---
@@ -88,7 +91,7 @@ class MaxAbsScaler @Since("2.0.0") (overri
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/10306#issuecomment-171942083
@mengxr Thanks for the prompt. I will check my environment and re-run the
test.
---
If your project is set up for it, you can reply to this email and have your
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/10806
[SPARK-8519][SPARK-11560][SPARK-11559] [ML] [MLlib] Optimize KMeans
implementation
* Use BLAS Level 3 matrix-matrix multiplications to compute pairwise
distance in k-means.
* Remove runs
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/10306#issuecomment-172558579
@mengxr I found the misconfiguration of my test environment and updated it,
thanks!
Now ```gemm``` is about 20-30 times faster than ```axpy/dot
Github user yanboliang closed the pull request at:
https://github.com/apache/spark/pull/10306
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/10306#issuecomment-172562607
@mengxr I have a new and advanced implementation for this issue at #10806 ,
let's move the discussion there. I will close this PR now.
---
If your project is set
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/10597#issuecomment-171910873
@shivaram Just like @felixcheung commented, the ```hash``` function was
added only in 2.0.0. So revert it from branch 1.6 will fix the broken test.
---
If your
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/10830
[SPARK-12905] [ML] [PySpark] PCAModel return eigenvalues for PySpark
```PCAModel``` return eigenvalues for PySpark
You can merge this pull request into a Git repository by running:
$ git
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/10829#issuecomment-172784554
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/10829
[SPARK-12903] [SparkR] Add covar_samp and covar_pop for SparkR
Add ```covar_samp``` and ```covar_pop``` for SparkR.
You can merge this pull request into a Git repository by running:
$ git
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/13378
@MLnick I have updated the new deprecations in the [JIRA]
(https://issues.apache.org/jira/browse/SPARK-15643?focusedCommentId=15343059=com.atlassian.jira.plugin.system.issuetabpanels:comment
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/13935
[SPARK-16242] [MLlib] [PySpark] Conversion between old/new matrix columns
in a DataFrame (Python)
## What changes were proposed in this pull request?
This PR implements python wrappers
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/13935
cc @hhbyyh @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/13937
cc @hhbyyh @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/13937#discussion_r68697383
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/PCA.scala ---
@@ -206,24 +206,21 @@ object PCAModel extends MLReadable[PCAModel
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/13937
[SPARK-16245] [ML] model loading backward compatibility for ml.feature.PCA
## What changes were proposed in this pull request?
model loading backward compatibility for ml.feature.PCA
Github user yanboliang closed the pull request at:
https://github.com/apache/spark/pull/13023
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/13888#discussion_r68486013
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala ---
@@ -309,8 +309,8 @@ object MLUtils extends Logging
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11044#issuecomment-180395685
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11136#discussion_r52330009
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -0,0 +1,472 @@
+/*
+ * Licensed
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11136#discussion_r52331693
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -0,0 +1,472 @@
+/*
+ * Licensed
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/11136
[SPARK-12811] [ML] Estimator for Generalized Linear Models(GLMs)
Estimator for Generalized Linear Models(GLMs)
You can merge this pull request into a Git repository by running:
$ git pull
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/10876#issuecomment-180175154
ping @davies
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/10889#issuecomment-183240342
@mengxr Actually, I have already updated this PR after #10216 get merged.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11136#discussion_r52610253
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -0,0 +1,472 @@
+/*
+ * Licensed
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11136#discussion_r52611868
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -0,0 +1,472 @@
+/*
+ * Licensed
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11136#discussion_r52611593
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -0,0 +1,472 @@
+/*
+ * Licensed
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11136#issuecomment-182905997
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/10469#issuecomment-175472122
@jkbradley Thanks for your comments! I have made ```MLReadable``` and
```MLWritable``` more general and not specific to Java wrappers, addressed all
comments except
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10469#discussion_r50950853
--- Diff: python/pyspark/ml/wrapper.py ---
@@ -82,13 +71,16 @@ def _transfer_params_to_java(self):
pair = self._make_java_param_pair
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10469#discussion_r50948067
--- Diff: python/pyspark/ml/util.py ---
@@ -52,3 +71,141 @@ def _randomUID(cls):
concatenates the class name, "_", and 12 random
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10962#discussion_r51087340
--- Diff: python/pyspark/ml/param/__init__.py ---
@@ -152,13 +152,17 @@ def isDefined(self, param):
return self.isSet(param
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/10469#issuecomment-176070210
@jkbradley You PR looks good and get merged, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/10975#issuecomment-177743797
@mengxr I did not found other class has similar test except ```KMeans```,
is this deliberately designed or lacks of some test cases?
---
If your project is set up
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10999#discussion_r51375854
--- Diff: python/pyspark/ml/clustering.py ---
@@ -69,6 +70,25 @@ class KMeans(JavaEstimator, HasFeaturesCol,
HasPredictionCol, HasMaxIter, HasTol
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11000#discussion_r51400507
--- Diff: python/pyspark/ml/regression.py ---
@@ -447,7 +447,7 @@ def _create_model(self, java_model):
@inherit_doc
-class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11044#discussion_r51690764
--- Diff: python/pyspark/ml/recommendation.py ---
@@ -81,6 +82,23 @@ class ALS(JavaEstimator, HasCheckpointInterval,
HasMaxIter, HasPredictionCol, Ha
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11044#discussion_r51690527
--- Diff: python/pyspark/ml/recommendation.py ---
@@ -81,6 +82,23 @@ class ALS(JavaEstimator, HasCheckpointInterval,
HasMaxIter, HasPredictionCol, Ha
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/10999
[SPARK-13035] [ML] [PySpark] PySpark ml.clustering support export/import
PySpark ml.clustering support export/import.
You can merge this pull request into a Git repository by running
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-178575141
@Wenpei It looks like ```_transfer_params_from_java``` did not consider the
params which do not have default value and we should handle them. Would you
mind
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11043#discussion_r51674846
--- Diff: python/pyspark/ml/wrapper.py ---
@@ -79,8 +79,9 @@ def _transfer_params_from_java(self):
for param in self.params
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11043#issuecomment-178983977
ping @mengxr @jkbradley
Could you add @Wenpei to white list ? This is an obvious bug and we should
fix it.
---
If your project is set up for it, you can reply
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-178966434
It should not make all parameters have default value because of some params
are not setting default value on purpose. I think we should modify
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10962#discussion_r51075753
--- Diff: python/pyspark/ml/param/__init__.py ---
@@ -152,13 +152,17 @@ def isDefined(self, param):
return self.isSet(param
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10876#discussion_r51226739
--- Diff: python/pyspark/sql/functions.py ---
@@ -263,6 +263,38 @@ def corr(col1, col2):
return Column(sc._jvm.functions.corr(_to_java_column
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/10975
[Minor] [ML] [PySpark] Cleanup test cases of clustering.py
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanboliang/spark clustering
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-188217429
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11344#issuecomment-188213659
@srowen Some ScalaDoc will end with two dots if we don't fix, you can refer
[here](https://github.com/apache/spark/pull/11344/files#diff
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-188217276
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-188216762
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-188217094
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11344#issuecomment-188281271
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11136#discussion_r53911268
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -0,0 +1,499 @@
+/*
+ * Licensed
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11136#discussion_r53911596
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -0,0 +1,565 @@
+/*
+ * Licensed
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/11344
[] [] [] Clean up sharedParams
## What changes were proposed in this pull request?
Remove duplicated dot at the end of some sharedParams in ScalaDoc.
cc @mengxr @srowen
## How
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11136#discussion_r53909986
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -0,0 +1,565 @@
+/*
+ * Licensed
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11321#discussion_r53908665
--- Diff: python/pyspark/mllib/fpm.py ---
@@ -40,6 +41,11 @@ class FPGrowthModel(JavaModelWrapper):
>>> model = FPGrowth.train(rd
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11136#discussion_r53909458
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -0,0 +1,565 @@
+/*
+ * Licensed
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/11383
[SPARK-13504] [SparkR] Add approxQuantile for SparkR
## What changes were proposed in this pull request?
Add ```approxQuantile``` for SparkR.
## How was this patch tested?
unit tests
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11203#discussion_r54218770
--- Diff: python/pyspark/ml/feature.py ---
@@ -1330,6 +1448,21 @@ class StringIndexer(JavaEstimator, HasInputCol,
HasOutputCol, HasHandleInvalid
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11203#discussion_r54217956
--- Diff: python/pyspark/ml/feature.py ---
@@ -443,6 +477,12 @@ class HashingTF(JavaTransformer, HasInputCol,
HasOutputCol, HasNumFeatures
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11136#discussion_r54206474
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -157,6 +157,12 @@ private[ml] class WeightedLeastSquares
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/11424
[SPARK-13545] [MLlib] [PySpark] Make MLlib LR's default parameters
consistent in Scala and Python
## What changes were proposed in this pull request?
Make MLlib LR's default parameters
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/11365
[SPARK-13322] [ML] AFTSurvivalRegression supports feature standardization
## What changes were proposed in this pull request?
AFTSurvivalRegression should support feature
Github user yanboliang closed the pull request at:
https://github.com/apache/spark/pull/11247
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11247#issuecomment-188668664
@dbtsai I think you convinced me, and I have also checked the R glmnet
implementation. The current behavior may be more make sense, so I will close
this PR. Thanks
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11344#issuecomment-188778682
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/11367
[SPARK-13490] [ML] ML LinearRegression should cache standardization param
value
## What changes were proposed in this pull request?
Like [SPARK-13132](https://issues.apache.org/jira/browse
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10242#discussion_r54395410
--- Diff: python/pyspark/ml/clustering.py ---
@@ -291,6 +292,317 @@ def _create_model(self, java_model):
return BisectingKMeansModel
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10242#discussion_r54394942
--- Diff: python/pyspark/ml/clustering.py ---
@@ -291,6 +292,317 @@ def _create_model(self, java_model):
return BisectingKMeansModel
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10242#discussion_r54395971
--- Diff: python/pyspark/ml/clustering.py ---
@@ -291,6 +292,317 @@ def _create_model(self, java_model):
return BisectingKMeansModel
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10242#discussion_r54394622
--- Diff: python/pyspark/ml/clustering.py ---
@@ -167,6 +167,200 @@ def getInitSteps(self):
return self.getOrDefault(self.initSteps
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10242#discussion_r54394752
--- Diff: python/pyspark/ml/clustering.py ---
@@ -291,6 +292,317 @@ def _create_model(self, java_model):
return BisectingKMeansModel
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10242#discussion_r54395661
--- Diff: python/pyspark/ml/clustering.py ---
@@ -291,6 +292,317 @@ def _create_model(self, java_model):
return BisectingKMeansModel
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11387#issuecomment-189200629
LGTM cc @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11203#issuecomment-189188086
@yinxusen Looks good overall, I left some inline comments. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11000#discussion_r53635317
--- Diff: python/pyspark/ml/regression.py ---
@@ -172,6 +172,16 @@ class IsotonicRegression(JavaEstimator,
HasFeaturesCol, HasLabelCol, HasPredicti
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-187221567
Looks good except minor issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-187222806
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11000#discussion_r53635702
--- Diff: python/pyspark/ml/regression.py ---
@@ -690,6 +700,18 @@ class AFTSurvivalRegression(JavaEstimator,
HasFeaturesCol, HasLabelCol, HasPredi
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11136#discussion_r53913710
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -0,0 +1,565 @@
+/*
+ * Licensed
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11136#issuecomment-188165176
@mengxr This PR is ready for another pass. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10639#discussion_r50390322
--- Diff: mllib/src/main/scala/org/apache/spark/ml/glm/Families.scala ---
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation
601 - 700 of 2641 matches
Mail list logo
