Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20560
@rxin It seems you are talking about the followup PR:
https://github.com/apache/spark/pull/21072
I think this is the way we do back propagation in catalyst: match a
specific node,
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/20560
Just saw this - this seems like a somewhat awkward way to do it by just
matching on filter / project. Is the main thing lacking a way to do back
propagation for properties? (We can only do forward
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20560
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89330/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #89330 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89330/testReport)**
for PR 20560 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2309/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #89330 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89330/testReport)**
for PR 20560 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89257/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #89257 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89257/testReport)**
for PR 20560 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #89257 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89257/testReport)**
for PR 20560 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2255/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20560
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89249/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #89249 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89249/testReport)**
for PR 20560 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2247/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #89249 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89249/testReport)**
for PR 20560 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89197/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #89197 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89197/testReport)**
for PR 20560 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2212/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #89197 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89197/testReport)**
for PR 20560 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #89195 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89195/testReport)**
for PR 20560 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89195/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2210/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #89195 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89195/testReport)**
for PR 20560 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89135/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #89135 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89135/testReport)**
for PR 20560 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2164/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #89135 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89135/testReport)**
for PR 20560 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89118/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #89118 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89118/testReport)**
for PR 20560 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2149/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #89118 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89118/testReport)**
for PR 20560 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/8/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #8 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/8/testReport)**
for PR 20560 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1957/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #8 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/8/testReport)**
for PR 20560 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88849/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #88849 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88849/testReport)**
for PR 20560 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1923/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #88849 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88849/testReport)**
for PR 20560 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20560
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20560
cc @cloud-fan @hvanhovell @wzhfy
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20560
kindly ping @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20560
Will review this in the next few days.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20560
@gatorsmile sorry, do you have time now to take a look at this? Or may I
ping you some days later if you are busy? Thanks.
---
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20560
thank you @gatorsmile for taking a look at this. Let me know if there is
something I can/should improve. Thanks.
---
-
To
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20560
@mgaido91 Yeah, we definitely should include this rule. We just need more
careful review and comprehensive test cases. Thanks for your work!
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87288/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #87288 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87288/testReport)**
for PR 20560 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20560
@gatorsmile thanks for your comment. I moved it to a separate rule and
added more tests.
As per the added value of this rule, I see 3 main points:
1. Let's imagine that a user exposes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/774/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #87288 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87288/testReport)**
for PR 20560 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20560
Thanks! This should be added as a separate rule. It is actually to resolve
the comment in https://github.com/apache/spark/pull/11480#discussion_r54840644
I did not review it carefully,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87261/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #87261 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87261/testReport)**
for PR 20560 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20560
**[Test build #87261 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87261/testReport)**
for PR 20560 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20560
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/752/
79 matches
Mail list logo
