Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20910
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r180784491
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesSpec.scala
---
@@ -14,17 +14,18 @@
* See the
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r180782338
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesSpec.scala
---
@@ -14,17 +14,18 @@
* See the
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r180535990
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesSpec.scala
---
@@ -14,17 +14,18 @@
* See the License
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r179313348
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -0,0 +1,179 @@
Github user kimoonkim commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r179302211
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -175,49 +138,41 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r179297367
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -175,49 +138,41 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r179297415
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -175,49 +138,41 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r179296929
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -14,104 +14,66 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r179296427
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -0,0 +1,135 @@
+/*
Github user kimoonkim commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r179265065
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -0,0 +1,166 @@
+/*
+ *
Github user kimoonkim commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r179267979
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -0,0 +1,135 @@
Github user kimoonkim commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r179266001
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkPod.scala
---
@@ -14,17 +14,16 @@
* See the License
Github user kimoonkim commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r179273021
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KubernetesFeatureConfigStep.scala
---
@@ -0,0 +1,29 @@
Github user kimoonkim commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r179269454
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -14,104 +14,66 @@
Github user kimoonkim commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r179270994
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -175,49 +138,41 @@
Github user kimoonkim commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r179266562
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -0,0 +1,135 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r179242084
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -14,104 +14,66 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r179241834
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -14,104 +14,66 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r179239601
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesSpec.scala
---
@@ -14,25 +14,18 @@
* See the
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r179239212
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -0,0 +1,166 @@
+/*
+ *
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177545717
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177507771
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -0,0 +1,164 @@
+/*
+ * Licensed
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177504889
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -0,0 +1,164 @@
+/*
+ *
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177502836
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -0,0 +1,164 @@
+/*
+ * Licensed
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177293958
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -0,0 +1,164 @@
+/*
+ *
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177290859
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -0,0 +1,158 @@
+/*
+ *
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177290805
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkPod.scala
---
@@ -14,17 +14,16 @@
* See the License
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177277920
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177277876
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -0,0 +1,164 @@
+/*
+ * Licensed
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177273537
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -180,20 +167,17 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177273458
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkPod.scala
---
@@ -14,17 +14,16 @@
* See the License for
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177267646
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -0,0 +1,137 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177266945
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -0,0 +1,158 @@
+/*
+ *
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177270542
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -180,20 +167,17
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177266807
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -0,0 +1,158 @@
+/*
+ *
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177266854
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -0,0 +1,158 @@
+/*
+ *
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177267477
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesSpec.scala
---
@@ -14,25 +14,18 @@
* See the
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177269929
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
---
@@ -0,0 +1,55 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177265926
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -0,0 +1,158 @@
+/*
+ *
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177267577
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkPod.scala
---
@@ -14,17 +14,16 @@
* See the License
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177265950
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -0,0 +1,158 @@
+/*
+ *
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177265297
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesSpec.scala
---
@@ -14,25 +14,18 @@
* See the
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177264954
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -211,34 +195,34 @@
GitHub user mccheah opened a pull request:
https://github.com/apache/spark/pull/20910
[SPARK-22839] [K8s] Refactor to unify driver and executor pod builder APIs
## What changes were proposed in this pull request?
Breaks down the construction of driver pods and executor pods
45 matches
Mail list logo
