HeartSaVioR commented on a change in pull request #28831:
URL: https://github.com/apache/spark/pull/28831#discussion_r440592664
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -123,26 +123,41 @@ case class ConcatWs(children: Seq[Expression])
val idxVararg = ctx.freshName("idxInVararg")
val evals = children.map(_.genCode(ctx))
+ val supportSplitExpressions =
ctx.supportSplitExpressionsWithCurrentInputs
Review comment:
We may be able to employ some threshold of the number of children or
fallback logic if we want to also exclude the case where the number of blocks
for all three parts are all 1, but that's going to be complicated a bit, so
would like to hear others' voices before applying.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
