HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-738723621
Thanks all for reviewing and merging! As it doesn't go through the recent
reviews, I'll be open to post review and deal with further comments as
follow-up.
The
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-738594037
2901429 is the commit containing reflect of review comments. Please take a
look again. Thanks in advance.
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-738593253
Sorry I had to rebase to find the odd test failure. It's fixed.
I'll squash commits I added after the latest review comment, so that you can
look into the single
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-738475088
Tests are failing due to the last change. It affects the order of effect
between this and SPARK-31894. Probably I have to turn off SPARK-31894 for these
tests or change the
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-738266750
retest this, please
This is an automated message from the Apache Git Service.
To respond to the message,
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-737669890
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-736873364
@rdblue @zsxwing @viirya Kindly reminder.
This is an automated message from the Apache Git Service.
To
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-736086878
Kicking Github Action instead.
This is an automated message from the Apache Git Service.
To respond to the
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-736083568
retest this, please
This is an automated message from the Apache Git Service.
To respond to the message,
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-736082954
cc. @rdblue @zsxwing @viirya Kindly reminder.
This is an automated message from the Apache Git Service.
To
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-734634204
@rdblue @zsxwing @viirya
Thanks for the reviewing. Reflected review comments. Please go with next
round of reviewing. Thanks in advance!
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-731023857
retest this, please
This is an automated message from the Apache Git Service.
To respond to the message,
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-730824157
retest this, please
This is an automated message from the Apache Git Service.
To respond to the message,
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-730702638
retest this, please
This is an automated message from the Apache Git Service.
To respond to the message,
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-730114355
retest this, please
This is an automated message from the Apache Git Service.
To respond to the message,
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-730114329
This still suffers from committers' review, even though I got two
contributors' LGTM who work on SS.
@cloud-fan If I remember correctly, we agreed this is the right
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-715660935
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-692386948
retest this, please
This is an automated message from the Apache Git Service.
To respond to the message,
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-675299208
retest this, please
This is an automated message from the Apache Git Service.
To respond to the message,
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-675250585
retest this, please
This is an automated message from the Apache Git Service.
To respond to the message,
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-657271138
retest this, please
This is an automated message from the Apache Git Service.
To respond to the message,
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-643729341
retest this, please
This is an automated message from the Apache Git Service.
To respond to the message,
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-643706060
retest this, please
This is an automated message from the Apache Git Service.
To respond to the message,
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-634491577
retest this, please
This is an automated message from the Apache Git Service.
To respond to the message,
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-634421224
retest this, please
This is an automated message from the Apache Git Service.
To respond to the message,
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-634305004
retest this, please
This is an automated message from the Apache Git Service.
To respond to the message,
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-622196282
retest this, please
This is an automated message from the Apache Git Service.
To respond to the message,
HeartSaVioR commented on pull request #24173:
URL: https://github.com/apache/spark/pull/24173#issuecomment-621811200
retest this, please
This is an automated message from the Apache Git Service.
To respond to the message,
28 matches
Mail list logo
