[GitHub] [spark] MichaelChirico commented on pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-28 Thread GitBox
MichaelChirico commented on pull request #28365: URL: https://github.com/apache/spark/pull/28365#issuecomment-620960833 @HyukjinKwon have reverted all `gettextf` usage, please have another look This is an automated message

[GitHub] [spark] MichaelChirico commented on pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-28 Thread GitBox
MichaelChirico commented on pull request #28365: URL: https://github.com/apache/spark/pull/28365#issuecomment-620800199 I would leave the JVM stuff to the developers working more closely with that code base. Translations only have to be updated at release time & the marginal cost from

[GitHub] [spark] MichaelChirico commented on pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-28 Thread GitBox
MichaelChirico commented on pull request #28365: URL: https://github.com/apache/spark/pull/28365#issuecomment-620765673 > I doubt we will ever have translations. my two cents is, it's mainly a matter of volition. As of now, `SparkR` has only 200 messages to translate (my guess

[GitHub] [spark] MichaelChirico commented on pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-27 Thread GitBox
MichaelChirico commented on pull request #28365: URL: https://github.com/apache/spark/pull/28365#issuecomment-620386789 Not sure why the Documents task failed, looks like the `roxygen2` part succeeded This is an automated