[GitHub] [spark] beliefer commented on a change in pull request #35130: [SPARK-37839][SQL] DS V2 supports partial aggregate push-down `AVG`

2022-01-17 Thread GitBox
beliefer commented on a change in pull request #35130: URL: https://github.com/apache/spark/pull/35130#discussion_r786360517 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala ## @@ -88,25 +88,65 @@ object

[GitHub] [spark] beliefer commented on a change in pull request #35130: [SPARK-37839][SQL] DS V2 supports partial aggregate push-down `AVG`

2022-01-17 Thread GitBox
beliefer commented on a change in pull request #35130: URL: https://github.com/apache/spark/pull/35130#discussion_r785814514 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala ## @@ -88,25 +88,65 @@ object

[GitHub] [spark] beliefer commented on a change in pull request #35130: [SPARK-37839][SQL] DS V2 supports partial aggregate push-down `AVG`

2022-01-17 Thread GitBox
beliefer commented on a change in pull request #35130: URL: https://github.com/apache/spark/pull/35130#discussion_r785779225 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/aggregate/Avg.java ## @@ -0,0 +1,49 @@ +/* + * Licensed to the

[GitHub] [spark] beliefer commented on a change in pull request #35130: [SPARK-37839][SQL] DS V2 supports partial aggregate push-down `AVG`

2022-01-13 Thread GitBox
beliefer commented on a change in pull request #35130: URL: https://github.com/apache/spark/pull/35130#discussion_r784483389 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala ## @@ -88,25 +88,49 @@ object

[GitHub] [spark] beliefer commented on a change in pull request #35130: [SPARK-37839][SQL] DS V2 supports partial aggregate push-down `AVG`

2022-01-12 Thread GitBox
beliefer commented on a change in pull request #35130: URL: https://github.com/apache/spark/pull/35130#discussion_r783566245 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala ## @@ -88,25 +88,40 @@ object

[GitHub] [spark] beliefer commented on a change in pull request #35130: [SPARK-37839][SQL] DS V2 supports partial aggregate push-down `AVG`

2022-01-12 Thread GitBox
beliefer commented on a change in pull request #35130: URL: https://github.com/apache/spark/pull/35130#discussion_r783563380 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala ## @@ -88,25 +88,40 @@ object

[GitHub] [spark] beliefer commented on a change in pull request #35130: [SPARK-37839][SQL] DS V2 supports partial aggregate push-down `AVG`

2022-01-12 Thread GitBox
beliefer commented on a change in pull request #35130: URL: https://github.com/apache/spark/pull/35130#discussion_r783002684 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala ## @@ -87,9 +87,26 @@ object

[GitHub] [spark] beliefer commented on a change in pull request #35130: [SPARK-37839][SQL] DS V2 supports partial aggregate push-down `AVG`

2022-01-11 Thread GitBox
beliefer commented on a change in pull request #35130: URL: https://github.com/apache/spark/pull/35130#discussion_r782762975 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala ## @@ -103,10 +120,10 @@ object

[GitHub] [spark] beliefer commented on a change in pull request #35130: [SPARK-37839][SQL] DS V2 supports partial aggregate push-down `AVG`

2022-01-11 Thread GitBox
beliefer commented on a change in pull request #35130: URL: https://github.com/apache/spark/pull/35130#discussion_r782762488 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala ## @@ -87,9 +87,26 @@ object

[GitHub] [spark] beliefer commented on a change in pull request #35130: [SPARK-37839][SQL] DS V2 supports partial aggregate push-down `AVG`

2022-01-11 Thread GitBox
beliefer commented on a change in pull request #35130: URL: https://github.com/apache/spark/pull/35130#discussion_r782762488 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala ## @@ -87,9 +87,26 @@ object

[GitHub] [spark] beliefer commented on a change in pull request #35130: [SPARK-37839][SQL] DS V2 supports partial aggregate push-down `AVG`

2022-01-11 Thread GitBox
beliefer commented on a change in pull request #35130: URL: https://github.com/apache/spark/pull/35130#discussion_r782760821 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/PushDownUtils.scala ## @@ -130,8 +128,17 @@ object PushDownUtils

[GitHub] [spark] beliefer commented on a change in pull request #35130: [SPARK-37839][SQL] DS V2 supports partial aggregate push-down `AVG`

2022-01-11 Thread GitBox
beliefer commented on a change in pull request #35130: URL: https://github.com/apache/spark/pull/35130#discussion_r782760381 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/PushDownUtils.scala ## @@ -107,14 +107,12 @@ object PushDownUtils

[GitHub] [spark] beliefer commented on a change in pull request #35130: [SPARK-37839][SQL] DS V2 supports partial aggregate push-down `AVG`

2022-01-11 Thread GitBox
beliefer commented on a change in pull request #35130: URL: https://github.com/apache/spark/pull/35130#discussion_r782686444 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -220,10 +222,16 @@ abstract class JdbcDialect extends

[GitHub] [spark] beliefer commented on a change in pull request #35130: [SPARK-37839][SQL] DS V2 supports partial aggregate push-down AVG

2022-01-08 Thread GitBox
beliefer commented on a change in pull request #35130: URL: https://github.com/apache/spark/pull/35130#discussion_r780603780 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -223,7 +225,11 @@ abstract class JdbcDialect extends

[GitHub] [spark] beliefer commented on a change in pull request #35130: [SPARK-37839][SQL] DS V2 supports partial aggregate push-down AVG

2022-01-07 Thread GitBox
beliefer commented on a change in pull request #35130: URL: https://github.com/apache/spark/pull/35130#discussion_r780603780 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -223,7 +225,11 @@ abstract class JdbcDialect extends