[GitHub] [spark] beliefer edited a comment on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-07-15 Thread GitBox
beliefer edited a comment on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-657998428 ~~@maropu I'm sorry! Because the change of https://github.com/apache/spark/pull/27428, each filter clause will be converted to be normal plan. It seems we not need this

[GitHub] [spark] beliefer edited a comment on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-07-15 Thread GitBox
beliefer edited a comment on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-657998428 ~~@maropu I'm sorry! Because the change of https://github.com/apache/spark/pull/27428, each filter clause will be converted to be normal plan. It seems we not need this

[GitHub] [spark] beliefer edited a comment on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-07-14 Thread GitBox
beliefer edited a comment on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-657998428 @maropu I'm sorry! Because the change of https://github.com/apache/spark/pull/27428, each filter clause will be converted to be normal plan. It seems we not need this