[GitHub] [spark] dilipbiswal commented on pull request #28750: [SPARK-31916][SQL] StringConcat can lead to StringIndexOutOfBoundsException

2020-06-11 Thread GitBox
dilipbiswal commented on pull request #28750: URL: https://github.com/apache/spark/pull/28750#issuecomment-643019799 Hi @maropu Just checked the 2.4 codebase. We don't have this Class in 2.4. Looks like we directed appended to StringBuilder. This class was added as part of

[GitHub] [spark] dilipbiswal commented on pull request #28750: [SPARK-31916][SQL] StringConcat can lead to StringIndexOutOfBoundsException

2020-06-11 Thread GitBox
dilipbiswal commented on pull request #28750: URL: https://github.com/apache/spark/pull/28750#issuecomment-643005468 @maropu Sure. Thanks a lot for your comments on the pr. This is an automated message from the Apache Git

[GitHub] [spark] dilipbiswal commented on pull request #28750: [SPARK-31916][SQL] StringConcat can lead to StringIndexOutOfBoundsException

2020-06-11 Thread GitBox
dilipbiswal commented on pull request #28750: URL: https://github.com/apache/spark/pull/28750#issuecomment-642498763 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dilipbiswal commented on pull request #28750: [SPARK-31916][SQL] StringConcat can lead to StringIndexOutOfBoundsException

2020-06-10 Thread GitBox
dilipbiswal commented on pull request #28750: URL: https://github.com/apache/spark/pull/28750#issuecomment-641766979 @maropu > Have you checked my last comment? #28750 (comment) The PR itself looks okay. Sorry i missed that. I have added the comment now. @viirya We