[GitHub] [spark] dongjoon-hyun commented on pull request #29069: [SPARK-31831][SQL][TESTS] Use subclasses for mock in HiveSessionImplSuite

2020-07-15 Thread GitBox
dongjoon-hyun commented on pull request #29069: URL: https://github.com/apache/spark/pull/29069#issuecomment-659151759 Thank you. I'm fine for all combination (including Hive 2.3 only testing). Please feel free to choose an option. From my side, this also looks not urgent since this is

[GitHub] [spark] dongjoon-hyun commented on pull request #29069: [SPARK-31831][SQL][TESTS] Use subclasses for mock in HiveSessionImplSuite

2020-07-15 Thread GitBox
dongjoon-hyun commented on pull request #29069: URL: https://github.com/apache/spark/pull/29069#issuecomment-659114303 cc @gatorsmile since he has been interested in `Hive 1.2` profile. This is an automated message from the

[GitHub] [spark] dongjoon-hyun commented on pull request #29069: [SPARK-31831][SQL][TESTS] Use subclasses for mock in HiveSessionImplSuite

2020-07-15 Thread GitBox
dongjoon-hyun commented on pull request #29069: URL: https://github.com/apache/spark/pull/29069#issuecomment-659113405 Hi, @HeartSaVioR and @frankyin-factual . This seems to break `master` compilation on Hive 1.2 profile. Could you take a look at the failure? -

[GitHub] [spark] dongjoon-hyun commented on pull request #29069: [SPARK-31831][SQL][TESTS] Use subclasses for mock in HiveSessionImplSuite

2020-07-12 Thread GitBox
dongjoon-hyun commented on pull request #29069: URL: https://github.com/apache/spark/pull/29069#issuecomment-657240325 Thanks for working on this, @HeartSaVioR and @frankyin-factual . This is an automated message from the