[GitHub] [spark] felixcheung commented on issue #25442: [SPARK-28722][ML] Change sequential label sorting in StringIndexer fit to parallel

2019-08-15 Thread GitBox
felixcheung commented on issue #25442: [SPARK-28722][ML] Change sequential 
label sorting in StringIndexer fit to parallel
URL: https://github.com/apache/spark/pull/25442#issuecomment-521893411
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] felixcheung commented on issue #25442: [SPARK-28722][ML] Change sequential label sorting in StringIndexer fit to parallel

2019-08-14 Thread GitBox
felixcheung commented on issue #25442: [SPARK-28722][ML] Change sequential 
label sorting in StringIndexer fit to parallel
URL: https://github.com/apache/spark/pull/25442#issuecomment-521315664
 
 
   does this change the behavior described in 
https://github.com/apache/spark/commit/33107897ada29d1ed17f091f93260dfcef11c2e7#diff-502dab735c3163f43270db719c7cade2R116
   ?
   
   @srowen any thought?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org