[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r52013 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1551,30 +1555,36 @@ private[spark] class BlockManager( } /**

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r426802776 ## File path: core/src/test/scala/org/apache/spark/storage/BlockManagerDecommissionSuite.scala ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r426802163 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1901,58 @@ private[spark] class BlockManager(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r426802529 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala ## @@ -299,6 +310,39 @@ class BlockManagerMasterEndpoint(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r426800099 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1901,58 @@ private[spark] class BlockManager(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r426799920 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala ## @@ -299,6 +310,39 @@ class BlockManagerMasterEndpoint(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r426374454 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1901,58 @@ private[spark] class BlockManager(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r426373154 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1901,58 @@ private[spark] class BlockManager(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r426372989 ## File path: core/src/test/scala/org/apache/spark/storage/BlockManagerDecommissionSuite.scala ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r426372857 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala ## @@ -299,6 +310,39 @@ class BlockManagerMasterEndpoint(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r426356804 ## File path: core/src/test/scala/org/apache/spark/storage/BlockManagerDecommissionSuite.scala ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r426356123 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala ## @@ -299,6 +310,39 @@ class BlockManagerMasterEndpoint(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r426355764 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1901,58 @@ private[spark] class BlockManager(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r426355979 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1901,58 @@ private[spark] class BlockManager(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r426355574 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1901,58 @@ private[spark] class BlockManager(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r426338523 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1901,58 @@ private[spark] class BlockManager(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r426338033 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1901,58 @@ private[spark] class BlockManager(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r426335880 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1901,58 @@ private[spark] class BlockManager(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r425950757 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1901,58 @@ private[spark] class BlockManager(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r425949927 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1901,58 @@ private[spark] class BlockManager(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r425944314 ## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ## @@ -413,6 +413,34 @@ package object config { .intConf

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r425942892 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1901,58 @@ private[spark] class BlockManager(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r425941258 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1901,58 @@ private[spark] class BlockManager(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r425478729 ## File path: dev/test-dependencies.sh ## @@ -17,7 +17,7 @@ # limitations under the License. # -set -e +set -ex Review comment: Does it? Why?

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r420453079 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1894,53 @@ private[spark] class BlockManager(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r419761212 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala ## @@ -299,6 +310,39 @@ class BlockManagerMasterEndpoint(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r419760451 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala ## @@ -299,6 +310,39 @@ class BlockManagerMasterEndpoint(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r419760119 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1761,6 +1775,57 @@ private[spark] class BlockManager(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r419598466 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala ## @@ -299,6 +310,39 @@ class BlockManagerMasterEndpoint(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r419597557 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1551,30 +1555,36 @@ private[spark] class BlockManager( } /**

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r418798629 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1761,6 +1775,58 @@ private[spark] class BlockManager(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r417656267 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1895,52 @@ private[spark] class BlockManager(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r416733183 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1895,52 @@ private[spark] class BlockManager(

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r415963574 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1895,52 @@ private[spark] class BlockManager(