[GitHub] [spark] kiszk commented on a change in pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-05-27 Thread GitBox
kiszk commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r431312054 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2586,6 +2586,15 @@ object SQLConf { .checkValue(_ > 0,

[GitHub] [spark] kiszk commented on a change in pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-05-26 Thread GitBox
kiszk commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r430862928 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala ## @@ -1311,6 +1311,27 @@ class CastSuite extends

[GitHub] [spark] kiszk commented on a change in pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-05-26 Thread GitBox
kiszk commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r430861312 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala ## @@ -266,7 +266,15 @@ abstract class CastBase extends