[GitHub] [spark] maropu commented on a change in pull request #28604: [SPARK-29854][SQL][TESTS] Add tests to check lpad/rpad throw an exception for invalid length input

2020-05-21 Thread GitBox
maropu commented on a change in pull request #28604: URL: https://github.com/apache/spark/pull/28604#discussion_r429042439 ## File path: sql/core/src/test/resources/sql-tests/inputs/string-functions.sql ## @@ -48,4 +48,8 @@ SELECT trim(LEADING 'xyz' FROM 'zzzytestxyz');

[GitHub] [spark] maropu commented on a change in pull request #28604: [SPARK-29854][SQL][TESTS] Add tests to check lpad/rpad throw an exception for invalid length input

2020-05-21 Thread GitBox
maropu commented on a change in pull request #28604: URL: https://github.com/apache/spark/pull/28604#discussion_r429014787 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -49,6 +49,24 @@ class SQLQuerySuite extends QueryTest with