[GitHub] [spark] maropu commented on a change in pull request #28863: [SPARK-31336][SQL] Support Oracle Kerberos login in JDBC connector

2020-06-26 Thread GitBox
maropu commented on a change in pull request #28863: URL: https://github.com/apache/spark/pull/28863#discussion_r446438925 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/OracleConnectionProvider.scala ## @@ -0,0 +1,63 @@ +/* +

[GitHub] [spark] maropu commented on a change in pull request #28863: [SPARK-31336][SQL] Support Oracle Kerberos login in JDBC connector

2020-06-23 Thread GitBox
maropu commented on a change in pull request #28863: URL: https://github.com/apache/spark/pull/28863#discussion_r444211273 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/OracleConnectionProviderSuite.scala ## @@ -0,0 +1,28 @@

[GitHub] [spark] maropu commented on a change in pull request #28863: [SPARK-31336][SQL] Support Oracle Kerberos login in JDBC connector

2020-06-20 Thread GitBox
maropu commented on a change in pull request #28863: URL: https://github.com/apache/spark/pull/28863#discussion_r443110503 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala ## @@ -32,35 +32,29 @@ import

[GitHub] [spark] maropu commented on a change in pull request #28863: [SPARK-31336][SQL] Support Oracle Kerberos login in JDBC connector

2020-06-20 Thread GitBox
maropu commented on a change in pull request #28863: URL: https://github.com/apache/spark/pull/28863#discussion_r443110374 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/OracleConnectionProvider.scala ## @@ -0,0 +1,60 @@ +/* +

[GitHub] [spark] maropu commented on a change in pull request #28863: [SPARK-31336][SQL] Support Oracle Kerberos login in JDBC connector

2020-06-20 Thread GitBox
maropu commented on a change in pull request #28863: URL: https://github.com/apache/spark/pull/28863#discussion_r443109663 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/OracleConnectionProvider.scala ## @@ -0,0 +1,60 @@ +/* +

[GitHub] [spark] maropu commented on a change in pull request #28863: [SPARK-31336][SQL] Support Oracle Kerberos login in JDBC connector

2020-06-20 Thread GitBox
maropu commented on a change in pull request #28863: URL: https://github.com/apache/spark/pull/28863#discussion_r443106703 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/OracleConnectionProviderSuite.scala ## @@ -0,0 +1,28 @@

[GitHub] [spark] maropu commented on a change in pull request #28863: [SPARK-31336][SQL] Support Oracle Kerberos login in JDBC connector

2020-06-20 Thread GitBox
maropu commented on a change in pull request #28863: URL: https://github.com/apache/spark/pull/28863#discussion_r443106215 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala ## @@ -32,35 +32,29 @@ import

[GitHub] [spark] maropu commented on a change in pull request #28863: [SPARK-31336][SQL] Support Oracle Kerberos login in JDBC connector

2020-06-20 Thread GitBox
maropu commented on a change in pull request #28863: URL: https://github.com/apache/spark/pull/28863#discussion_r443105992 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala ## @@ -32,35 +32,29 @@ import

[GitHub] [spark] maropu commented on a change in pull request #28863: [SPARK-31336][SQL] Support Oracle Kerberos login in JDBC connector

2020-06-20 Thread GitBox
maropu commented on a change in pull request #28863: URL: https://github.com/apache/spark/pull/28863#discussion_r443105104 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala ## @@ -69,6 +63,7 @@ class

[GitHub] [spark] maropu commented on a change in pull request #28863: [SPARK-31336][SQL] Support Oracle Kerberos login in JDBC connector

2020-06-20 Thread GitBox
maropu commented on a change in pull request #28863: URL: https://github.com/apache/spark/pull/28863#discussion_r443105054 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala ## @@ -32,35 +32,29 @@ import

[GitHub] [spark] maropu commented on a change in pull request #28863: [SPARK-31336][SQL] Support Oracle Kerberos login in JDBC connector

2020-06-19 Thread GitBox
maropu commented on a change in pull request #28863: URL: https://github.com/apache/spark/pull/28863#discussion_r443104744 ## File path: external/docker-integration-tests/pom.xml ## @@ -130,15 +130,9 @@ postgresql test - - - com.oracle -