[GitHub] [spark] rednaxelafx commented on a change in pull request #25766: [SPARK-29061][SQL] Prints bytecode statistics in debugCodegen
rednaxelafx commented on a change in pull request #25766: [SPARK-29061][SQL]
Prints bytecode statistics in debugCodegen
URL: https://github.com/apache/spark/pull/25766#discussion_r323610161
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
##
@@ -1353,19 +1370,17 @@ object CodeGenerator extends Logging {
byteCodeSize
}
}
-Some(stats)
+(classCodeSize, methodCodeSizes.max, constPoolSize)
Review comment:
I find named fields much more readable than _1 _2 _3. In fact even with
tuples I may have written the code like:
```scala
ByteCodeStats(codeStats.reduce { case ((maxClassCodeSize1,
maxMethodCodeSize1, maxConstPoolSize), (maxClassCodeSize2, maxMethodCodeSize2,
maxConstPoolSize2)) =>
(Math.max(maxClassCodeSize1, maxClassCodeSize2),
Math.max(maxMethodCodeSize1, maxMethodCodeSize2),
Math.max(maxConstPoolSize1, maxConstPoolSize2))
})
```
and...I'd say the `v1.maxClassCodeSize` version looks better here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] rednaxelafx commented on a change in pull request #25766: [SPARK-29061][SQL] Prints bytecode statistics in debugCodegen
rednaxelafx commented on a change in pull request #25766: [SPARK-29061][SQL]
Prints bytecode statistics in debugCodegen
URL: https://github.com/apache/spark/pull/25766#discussion_r323573008
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
##
@@ -1353,19 +1370,17 @@ object CodeGenerator extends Logging {
byteCodeSize
}
}
-Some(stats)
+(classCodeSize, methodCodeSizes.max, constPoolSize)
Review comment:
I'm curious: now that we've got a nice new `ByteCodeStats` type, why use a
tuple here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] rednaxelafx commented on a change in pull request #25766: [SPARK-29061][SQL] Prints bytecode statistics in debugCodegen
rednaxelafx commented on a change in pull request #25766: [SPARK-29061][SQL]
Prints bytecode statistics in debugCodegen
URL: https://github.com/apache/spark/pull/25766#discussion_r323572401
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
##
@@ -1318,10 +1332,11 @@ object CodeGenerator extends Logging {
}
/**
- * Returns the max bytecode size of the generated functions by inspecting
janino private fields.
- * Also, this method updates the metrics information.
+ * Returns the bytecode statistics (max class bytecode size, max method
bytecode size, and
+ * max constant pool size) of generated classes by inspecting janino private
fields.inspecting
Review comment:
Nit: `inspecting janino private fields.inspecting janino private fields`
seems weird.
Also: could we always spell "Janino" as such?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
