[GitHub] spark issue #14629: [WIP][SPARK-17046][SQL] prevent user using dataframe.sel...

2016-08-20 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14629 I haven't changed my mind of this. Lets close this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #14629: [WIP][SPARK-17046][SQL] prevent user using dataframe.sel...

2016-08-20 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14629 @hvanhovell @rxin unless you've changed your stance a little bit on this, I think the conclusion is that this isn't worth changing this behavior and we can close this @WeichenXu123 --- If your

[GitHub] spark issue #14629: [WIP][SPARK-17046][SQL] prevent user using dataframe.sel...

2016-08-14 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14629 Interesting point, yeah, because normally in an RDBMS you have to `COUNT(*)` or `COUNT(1)` and the argument is useless anyway, so would be nice to not have to provide an argument to select in this

[GitHub] spark issue #14629: [WIP][SPARK-17046][SQL] prevent user using dataframe.sel...

2016-08-14 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14629 A `df.select()` without any columns is not useless IMO: You can still get a valid `count()` from a data frame. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #14629: [WIP][SPARK-17046][SQL] prevent user using dataframe.sel...

2016-08-14 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/14629 MySql do not allow select with 0 columns, and I think select() is useless, no one will do such operation, so, is it better to generate compiling error when detecting code use `df.select()`

[GitHub] spark issue #14629: [WIP][SPARK-17046][SQL] prevent user using dataframe.sel...

2016-08-13 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14629 Yes that's a good question. A 0-column DataFrame is valid, though that's a little different from being able to select 0 columns from a DataFrame. I don't have a database handy, but can you select no

[GitHub] spark issue #14629: [WIP][SPARK-17046][SQL] prevent user using dataframe.sel...

2016-08-13 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14629 Why do we want to enforce this? It is valid to have a DataFrame without any columns. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #14629: [WIP][SPARK-17046][SQL] prevent user using dataframe.sel...

2016-08-13 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/14629 @srowen How do you think about this problem? I found adding two method like `def select(cols: Column*)` `def select(col: Column, cols: Column*)` causing ambiguous, I

[GitHub] spark issue #14629: [WIP][SPARK-17046][SQL] prevent user using dataframe.sel...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14629 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14629: [WIP][SPARK-17046][SQL] prevent user using dataframe.sel...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14629 **[Test build #63724 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63724/consoleFull)** for PR 14629 at commit

[GitHub] spark issue #14629: [WIP][SPARK-17046][SQL] prevent user using dataframe.sel...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14629 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63724/ Test FAILed. ---

[GitHub] spark issue #14629: [WIP][SPARK-17046][SQL] prevent user using dataframe.sel...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14629 **[Test build #63724 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63724/consoleFull)** for PR 14629 at commit