Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
Thank you for review, @rxin and @cloud-fan , too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
Thank you, @gatorsmile .
I'll make a backport for 2.0, too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15546
Could you please backport it to 2.0? It sounds the JIRA opener needs it in
Spark 2.0 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15546
Thanks! Merging to master/2.1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68528/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #68528 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68528/consoleFull)**
for PR 15546 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
Thank you, @gatorsmile .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15546
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #68528 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68528/consoleFull)**
for PR 15546 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15546
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
Could you review again, @gatorsmile ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68484/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #68484 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68484/consoleFull)**
for PR 15546 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
Thank you, @gatorsmile !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68480/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #68480 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68480/consoleFull)**
for PR 15546 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15546
Will review this PR tonight. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #68484 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68484/consoleFull)**
for PR 15546 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #68480 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68480/consoleFull)**
for PR 15546 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
The three failures seems to be irrelevant.
```
[info] - randomized aggregation test - [typed, with partial + safe] - with
grouping keys - with non-empty input *** FAILED *** (1 second,
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
Retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68458/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #68458 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68458/consoleFull)**
for PR 15546 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #68458 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68458/consoleFull)**
for PR 15546 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
During updating the PR, I rebased and squashed to resolve conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
Hi, @gatorsmile .
Could you review again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68239/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #68239 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68239/consoleFull)**
for PR 15546 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #68239 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68239/consoleFull)**
for PR 15546 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
Hi, @gatorsmile . The PR is updated according to the advice.
- Remove the `goldenSQLPath` from this PR.
- Update the PR description about the target fixed cases and the detailed
plans,
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
Thank you for review, @gatorsmile . I'll add the failed plans, too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15546
@dongjoon-hyun I have a general comment about the SQL generation fixes. Not
sure how you fix the issue. Normally, when we did it, we need to see the
analyzed SQL plan. In this case, it becomes a
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15546
Will do the review soon. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15546
cc @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
@rxin .
I'll add more testcases for this and figure out the correct answer for your
question.
> is it always safe to just add limit to any plan?
---
If your project is set up for it,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67190/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #67190 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67190/consoleFull)**
for PR 15546 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67185/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #67185 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67185/consoleFull)**
for PR 15546 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #67190 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67190/consoleFull)**
for PR 15546 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
Retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
The current running build has one testcase failure, `when schema inference
is turned on, should read partition data`. It seems to be irrelevant.
---
If your project is set up for it, you
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67178/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #67178 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67178/consoleFull)**
for PR 15546 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
@rxin . I moved the test case and fixed a bug in `LogicalPlanToSQLSuite`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #67185 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67185/consoleFull)**
for PR 15546 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
Ah. I see. `( )` means parenthesis, literally. I'll replace `CREATE VIEW`
test case with SQL Generation suite. BTW, at the last commit, the PR is changed
to add parenthesis if the child of
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
Sorry, but what do you mean by `the output has ( ) no?`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15546
but you can construct a query with limit to make sure the output has ( ) no?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
Thank you for review, @rxin .
Here, `CREATE VIEW` is not supported by SQLGeneration test suite.
CREATE VIEW **v1(id2)** AS SELECT id FROM tbl **LIMIT 2**
The case is a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #67178 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67178/consoleFull)**
for PR 15546 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67172/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #67172 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67172/consoleFull)**
for PR 15546 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #67172 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67172/consoleFull)**
for PR 15546 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67165/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #67165 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67165/consoleFull)**
for PR 15546 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67166/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15546
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #67166 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67166/consoleFull)**
for PR 15546 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #67166 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67166/consoleFull)**
for PR 15546 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15546
**[Test build #67165 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67165/consoleFull)**
for PR 15546 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
Ooops. Thank you for fixing me! @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
72 matches
Mail list logo
