[GitHub] spark issue #17243: [SPARK-19901][Core]Clean up the clunky method signature ...

Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/17243 ok, I will close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17243: [SPARK-19901][Core]Clean up the clunky method signature ...

Github user srowen commented on the issue: https://github.com/apache/spark/pull/17243 I'm not sure what this refers to. Unless it's giving a clear and non-trivial improvement to the method signatures, I don't think is worth the time to discuss and review. This particular change does

[GitHub] spark issue #17243: [SPARK-19901][Core]Clean up the clunky method signature ...

Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/17243 Hi, @srowen @HyukjinKwon, thanks for the review. This patch stems from the `TODO` list, which is used to streamline the method signature, make it more readable. If you think there is no essential

[GitHub] spark issue #17243: [SPARK-19901][Core]Clean up the clunky method signature ...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17243 I don't think this is particular better too. We should avoid style changes by a personal taste. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #17243: [SPARK-19901][Core]Clean up the clunky method signature ...

Github user srowen commented on the issue: https://github.com/apache/spark/pull/17243 This doesn't look simpler to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17243: [SPARK-19901][Core]Clean up the clunky method signature ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17243 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17243: [SPARK-19901][Core]Clean up the clunky method signature ...

Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/17243 Sorry for the mistake, reopen it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17243: [SPARK-19901][Core]Clean up the clunky method signature ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17243 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this