Github user liu-zhaokun commented on the issue:
https://github.com/apache/spark/pull/18879
@jiangxb1987
BTW,how to find the release branch of Hive-0.13.1a which spark1.4.1
compiled with?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user liu-zhaokun commented on the issue:
https://github.com/apache/spark/pull/18879
Thanks for your patience.Would you @srowen agree with @jiangxb1987 .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/18879
I think @srowen means you should change the method name, not only the
comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user liu-zhaokun commented on the issue:
https://github.com/apache/spark/pull/18879
@srowen
I have modified the annotation,would you like to review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user liu-zhaokun commented on the issue:
https://github.com/apache/spark/pull/18879
@srowen @jiangxb1987
If we can't change this logic,I think we should change the
annotation,because it says "If user doesn't specify the appName, we want to get
[SparkSQL::localHostName]"
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18879
The method name is misleading internally, but we can't change this logic.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/18879
I'm not convinced this deserves a separated PR because it's neither bugfix
nor any improvement. Further more, the method `Utils.localHostName()` is used
in many other places, we can't change
Github user liu-zhaokun commented on the issue:
https://github.com/apache/spark/pull/18879
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/18879
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18879
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
10 matches
Mail list logo