Github user koeninger commented on the issue:
https://github.com/apache/spark/pull/19431
@akonopko Thanks!
Sorry, but I just noticed the title of the PR - can you adjust it to match
convention, e.g.
[SPARK-18580] [DSTREAM][KAFKA] Add
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19431
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88477/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19431
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19431
**[Test build #88477 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88477/testReport)**
for PR 19431 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19431
**[Test build #88477 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88477/testReport)**
for PR 19431 at commit
Github user koeninger commented on the issue:
https://github.com/apache/spark/pull/19431
Jenkins, ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user akonopko commented on the issue:
https://github.com/apache/spark/pull/19431
@koeninger resolved the conflict
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user koeninger commented on the issue:
https://github.com/apache/spark/pull/19431
@akonopko thanks for this, if you can resolve merge conflict I think we can
get this in
---
-
To unsubscribe, e-mail:
Github user koeninger commented on the issue:
https://github.com/apache/spark/pull/19431
Jenkins, ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user omuravskiy commented on the issue:
https://github.com/apache/spark/pull/19431
No objections
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user koeninger commented on the issue:
https://github.com/apache/spark/pull/19431
@tdas any concerns?
If @omuravskiy doesn't express any objections (since these tests are
basically taken directly from his linked PR) in the next couple of days, I'm
inclined to merge
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/19431
@tdas could you take a look at it?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/19431
I mean the difference between `test("use backpressure.initialRate with
backpressure")` and `test("backpressure.initialRate should honor
maxRatePerPartition")` are 3 numbers. Wrapping the
Github user akonopko commented on the issue:
https://github.com/apache/spark/pull/19431
> Related the doc I thought it's kafka specific but it's not so fine like
that
Yes, it was implemented only in Kafka Streams but doc doesnt limit usage of
this parameter to Kafka
>
Github user akonopko commented on the issue:
https://github.com/apache/spark/pull/19431
Latest rate means rate of previous batch. Is it possible that in alive
system 0 events were processed? Only if there is no backlog and no new events
came during last batch. Completely possible.
Github user akonopko commented on the issue:
https://github.com/apache/spark/pull/19431
@gaborgsomogyi
`spark.streaming.backpressure.initialRate` is already documented in here:
https://spark.apache.org/docs/latest/configuration.html
But was mistakenly not included to to
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19431
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19431
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/19431
Until now it was not fully clear documented in which situation does this
parameter take effect. I would personally add things into the doc to be a bit
more specific.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19431
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19431
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
21 matches
Mail list logo
