Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23239
Hi, @cloud-fan . Please make another PR for `branch-2.4`. There is a
conflict on `branch-2.4`.
---
-
To unsubscribe,
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23239
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23239
**[Test build #99819 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99819/testReport)**
for PR 23239 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99820/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23239
**[Test build #99820 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99820/testReport)**
for PR 23239 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99816/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23239
**[Test build #99816 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99816/testReport)**
for PR 23239 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23239
**[Test build #99820 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99820/testReport)**
for PR 23239 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23239
**[Test build #99819 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99819/testReport)**
for PR 23239 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23239
I checked the original PR that handles NaN:
https://github.com/apache/spark/commit/c032b0bf92130dc4facb003f0deaeb1228aefded
It didn't add end-to-end tests, so I added 2 new tests.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23239
**[Test build #99816 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99816/testReport)**
for PR 23239 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23239
The change looks fine.
Do we already have tests for cases 2 and 4? We know test for case 3 is
[here](https://github.com/apache/spark/pull/23043).
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99801/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23239
**[Test build #99801 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99801/testReport)**
for PR 23239 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23239
Yes it is. `UnsafeProjection` always normalize NaN and -0.0, and Spark uses
`UnsafeProjection` to produce output. So users can't distinguish them.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/23239
The migration guide has changed by another followup
https://github.com/apache/spark/pull/23141:
> In Spark version 2.4 and earlier, float/double -0.0 is semantically equal
to 0.0, but users
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23239
**[Test build #99801 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99801/testReport)**
for PR 23239 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23239
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99780/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23239
**[Test build #99780 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99780/testReport)**
for PR 23239 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23239
**[Test build #99780 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99780/testReport)**
for PR 23239 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99737/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23239
**[Test build #99737 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99737/testReport)**
for PR 23239 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99738/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23239
**[Test build #99738 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99738/testReport)**
for PR 23239 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23239
**[Test build #99738 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99738/testReport)**
for PR 23239 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23239
Yes, the 3 cases I pointed that need to handle NaN and -0.0 do not change
the value in `UnsafeRow`.
---
-
To unsubscribe,
Github user adoron commented on the issue:
https://github.com/apache/spark/pull/23239
@cloud-fan what about UnsafeRow::setDouble/Float? It doesn't go through the
same flow. Is it not used?
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23239
**[Test build #99737 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99737/testReport)**
for PR 23239 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23239
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23239
cc @adoron @kiszk @viirya @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
51 matches
Mail list logo
