Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8743
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-168372683
Thanks - I've merged this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-168367522
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-168367565
**[Test build #2295 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2295/consoleFull)**
for PR 8743 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-168371292
**[Test build #2295 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2295/consoleFull)**
for PR 8743 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-168364467
**[Test build #2294 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2294/consoleFull)**
for PR 8743 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-168338761
**[Test build #2287 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2287/consoleFull)**
for PR 8743 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-168361139
**[Test build #2294 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2294/consoleFull)**
for PR 8743 at commit
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-168346039
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-168356745
**[Test build #2291 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2291/consoleFull)**
for PR 8743 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-168339975
**[Test build #2287 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2287/consoleFull)**
for PR 8743 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-168353114
**[Test build #2291 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2291/consoleFull)**
for PR 8743 at commit
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-168294581
Sorry I kept merging pull requests that made your life harder. Can you
bring it up to date again? I promise this is the last one.
---
If your project is set up for it,
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-168306690
Could anybody please type "test this please" for this PR? I can't trigger a
test for this PR.
---
If your project is set up for it, you can reply to this email and
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-168306374
@rxin Nothing is eazy and happy new year. I just resolved conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-168306376
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/8743#discussion_r48640365
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
@@ -191,6 +191,9 @@ private[sql] object JDBCRDD extends
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-168097568
I'm wondering if it's okey to add `sealed` to `Filter` and remove `case _`.
If so, the compiler can help us find such issue.
---
If your project is set up for it, you
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/8743#discussion_r48640506
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
@@ -191,6 +191,9 @@ private[sql] object JDBCRDD extends
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-168102081
@zsxwing I will anyway resolve the conflicts first
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-167968091
Hm.. actually I think adding tests more in docker is a bit over-tested. It
looks the comparison operators I used are all already being used in
`compileFilter` and i
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-168008985
Yes and you're right. We need to clearly define the rule that decides which
tests should be added in `docker-integration-tests`.
---
If your project is set up for it,
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-167943712
@zsxwing can you review this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-167948607
@HyukjinKwon +1, I think it'd better to add tests in
`MySQLIntegrationSuite` and `PostgresIntegrationSuite`.
---
If your project is set up for it, you can reply to this
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-163142135
Just a question. Now it looks the PR for the end-to-end docker tests is
merged. Do you think it needs all the tests for all the databases (namely
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-158482749
**[Test build #46425 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46425/consoleFull)**
for PR 8743 at commit
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-158479691
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-158519114
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-158519112
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-158518918
**[Test build #46425 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46425/consoleFull)**
for PR 8743 at commit
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-158330364
It looks Jenkins does not run the test for the past commits that I made as
a user not added to whitelist. Would anybody please run the test for this
please if it
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-158316387
I added a simple test for this. I wanted to add a test including `null` but
when the given value is `null`, Spark converts it to `IsNull`. To make this
worse, more
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-158316439
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-157884040
Can we add a test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-150959813
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-141679756
Should I better write some test codes for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-140919876
Should I better write a test code for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-140554041
Please update the pull request description to describe the changes in this
patch.
---
If your project is set up for it, you can reply to this email and have your
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-140554359
Will this case be covered by the end-to-end docker tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/8743
[SPARK-10180] [SQL] JDBC datasource are not processing EqualNullSafe filter
https://github.com/apache/spark/pull/8391
@rxin I apologize that I removed the forked repo by mistake with not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8743#issuecomment-140031121
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
41 matches
Mail list logo
