Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2250
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-56678722
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20752/consoleFull)
for PR 2432 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-56690206
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20752/consoleFull)
for PR 2432 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-56690217
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20752/
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-56754562
Do you mind copying some of the description from the old PR over here? The
PR description and title are incorporated into the commit message, which is why
it's
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2432#discussion_r18007213
--- Diff:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
---
@@ -144,16 +146,16 @@ private[spark] object
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2432#discussion_r18007241
--- Diff:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
---
@@ -106,7 +106,8 @@ private[spark] object
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2432#discussion_r18007450
--- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
---
@@ -95,10 +93,27 @@ private[spark] class MetricsSystem private (val
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-5676
This is awesome! Consistently naming things using the same applicationIds
will be helpful in a variety of contexts, so thanks for taking the time to work
on this
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-56756072
Actually, I have one more question / thought:
Someone has discovered a similar issue in HistoryServer where the current
code erroneously assumes that
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-56332729
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20644/consoleFull)
for PR 2432 at commit
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-56290329
In current implementation, MesosSchedulerBackend and
CoarseGrainedMesosSchedulerBackend always return None when we invoke
applicationId method. But if we apply the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-56290403
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20617/consoleFull)
for PR 2432 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-56291394
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20617/consoleFull)
for PR 2432 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-56327263
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20641/consoleFull)
for PR 2432 at commit
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-56329366
@JoshRosen I've just implement
CoarseGrainedMesosSchedulerBackend#applicationId and
MesosSchedulerBackend#applicationId, and now we can use unique ID instead of
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-56329531
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20644/consoleFull)
for PR 2432 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-56329906
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20641/consoleFull)
for PR 2432 at commit
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2250#issuecomment-56281680
I feel strongly that we should use the same application ID to refer to the
application in every context, since creating a different id based off of
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-56281694
Can you add closes #1067 to the description here, too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-56281779
Quoting @sarutak from #2250, regarding this PR:
And for problem 2, when launching ExecutorBackends, launcher pass
application id to ExecutorBackends. It
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-56207059
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20575/consoleFull)
for PR 2432 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-56216738
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20575/consoleFull)
for PR 2432 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2250#issuecomment-55934873
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20472/consoleFull)
for PR 2250 at commit
GitHub user sarutak opened a pull request:
https://github.com/apache/spark/pull/2432
[SPARK-3377] [Metrics] Metrics can be accidentally aggregated(Another
solution)
This PR is another solution for #2250
Closes #2250
You can merge this pull request into a Git repository
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-55936296
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20473/consoleFull)
for PR 2432 at commit
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2250#issuecomment-55940146
@JoshRosen Thanks for your advise. I tried to use application id for
metrics name and I found there were something difficulty.
Problem 1. We need application id
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-55943603
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20473/consoleFull)
for PR 2432 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2250#issuecomment-55944629
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20472/consoleFull)
for PR 2250 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-55945637
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20478/consoleFull)
for PR 2432 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-55951955
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20478/consoleFull)
for PR 2432 at commit
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-55953996
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-55954928
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20486/consoleFull)
for PR 2432 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-55963948
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20486/consoleFull)
for PR 2432 at commit
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2250#issuecomment-55798065
This seems like a good idea; I can see how the current behavior is
confusing, especially since I think it might be common for multiple apps to be
running with the same
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2250#issuecomment-5663
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20322/consoleFull)
for PR 2250 at commit
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2250#issuecomment-55678532
Can anyone review this if you have time?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/2250#issuecomment-2366
Could you cleanup the changes? It's confusing to see a bunch of debugging
changes were left.
---
If your project is set up for it, you can reply to this email and have
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2250#issuecomment-3308
@davies Sorry, now I've just cleaned up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2250#issuecomment-3356
Sorry, now I've just cleaned up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2250#issuecomment-55484697
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20262/consoleFull)
for PR 2250 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2250#issuecomment-55360228
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20201/consoleFull)
for PR 2250 at commit
42 matches
Mail list logo
