Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2368#issuecomment-56244170
Thanks! Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2368
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17619745
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -244,18 +244,22 @@ case class Cast(child: Expression,
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2368#issuecomment-55788087
Minor style suggestion, otherwise LGTM. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17639971
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -244,18 +244,22 @@ case class Cast(child:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2368#issuecomment-55843681
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20445/consoleFull)
for PR 2368 at commit
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2368#issuecomment-6637
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2368#issuecomment-6842
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20329/consoleFull)
for PR 2368 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2368#issuecomment-55564638
**[Tests timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20329/consoleFull)**
after a configured wait of `120m`.
---
If your project
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17562206
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -32,12 +32,12 @@ object Optimizer extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17562464
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -32,12 +32,12 @@ object Optimizer extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2368#issuecomment-55685521
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20361/consoleFull)
for PR 2368 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2368#issuecomment-55690559
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20361/consoleFull)
for PR 2368 at commit
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2368#issuecomment-55693692
You're right @marmbrus . the expression should work even without being
optimized. I've updated the no-op case in `Cast` and revert the change in the
`Optimizer`.
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17524564
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -32,12 +32,12 @@ object Optimizer extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17524775
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -32,12 +32,12 @@ object Optimizer extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2368#issuecomment-55548796
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20318/consoleFull)
for PR 2368 at commit
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17525387
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -32,12 +32,12 @@ object Optimizer extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2368#issuecomment-55549403
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20319/consoleFull)
for PR 2368 at commit
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17525906
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -32,12 +32,12 @@ object Optimizer extends
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17526186
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -32,12 +32,12 @@ object Optimizer extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2368#issuecomment-2752
**[Tests timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20318/consoleFull)**
after a configured wait of `120m`.
---
If your project
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17526456
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -32,12 +32,12 @@ object Optimizer extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2368#issuecomment-3380
**[Tests timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20319/consoleFull)**
after a configured wait of `120m`.
---
If your project
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17513558
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUdfs.scala
---
@@ -51,13 +51,13 @@ private[hive] abstract class HiveFunctionRegistry
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17513564
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -32,12 +32,12 @@ object Optimizer extends
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2368#issuecomment-55502187
Thanks for fixing this! While I think eliminating the problem is great, it
also seems like a bug to me that casting a timestamp to a timestamp throws an
exception
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2368#issuecomment-55369750
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20208/consoleFull)
for PR 2368 at commit
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2368#issuecomment-55363030
test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2368#issuecomment-55363315
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20208/consoleFull)
for PR 2368 at commit
30 matches
Mail list logo
