[GitHub] spark pull request: [SPARK-3755][Core] Do not bind port 1 - 1024 t...

2014-10-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/2623#discussion_r18326718 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -1437,7 +1437,13 @@ private[spark] object Utils extends Logging { val

[GitHub] spark pull request: [SPARK-3755][Core] Do not bind port 1 - 1024 t...

2014-10-02 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/2623#discussion_r18330540 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -1437,7 +1437,13 @@ private[spark] object Utils extends Logging { val

[GitHub] spark pull request: [SPARK-3755][Core] Do not bind port 1 - 1024 t...

2014-10-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/2623#discussion_r18332145 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -1437,7 +1437,13 @@ private[spark] object Utils extends Logging { val

[GitHub] spark pull request: [SPARK-3755][Core] Do not bind port 1 - 1024 t...

2014-10-02 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/2623#discussion_r18333694 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -1437,7 +1437,13 @@ private[spark] object Utils extends Logging { val

[GitHub] spark pull request: [SPARK-3755][Core] Do not bind port 1 - 1024 t...

2014-10-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/2623#discussion_r18334033 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -1437,7 +1437,13 @@ private[spark] object Utils extends Logging { val

[GitHub] spark pull request: [SPARK-3755][Core] Do not bind port 1 - 1024 t...

2014-10-02 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/2623#discussion_r18334553 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -1437,7 +1437,13 @@ private[spark] object Utils extends Logging { val

[GitHub] spark pull request: [SPARK-3755][Core] Do not bind port 1 - 1024 t...

2014-10-01 Thread scwf
GitHub user scwf opened a pull request: https://github.com/apache/spark/pull/2610 [SPARK-3755][Core] Do not bind port 1 - 1024 to server in spark Non-root user use port 1- 1024 to start jetty server will get the exception java.net.SocketException: Permission denied, so not use

[GitHub] spark pull request: [SPARK-3755][Core] Do not bind port 1 - 1024 t...

2014-10-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2610#issuecomment-57429408 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3755][Core] Do not bind port 1 - 1024 t...

2014-10-01 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2610#issuecomment-57488833 Jenkins, test this please. This does seem good... however, I think you'd need to fail for thousands of ports to ever hit this case in Spark :) --- If your project is

[GitHub] spark pull request: [SPARK-3755][Core] Do not bind port 1 - 1024 t...

2014-10-01 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2610#issuecomment-5746 LGTM pending tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-3755][Core] Do not bind port 1 - 1024 t...

2014-10-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2610#issuecomment-57490109 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21122/consoleFull) for PR 2610 at commit

[GitHub] spark pull request: [SPARK-3755][Core] Do not bind port 1 - 1024 t...

2014-10-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2610#issuecomment-57501301 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21122/consoleFull) for PR 2610 at commit

[GitHub] spark pull request: [SPARK-3755][Core] Do not bind port 1 - 1024 t...

2014-10-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2610#issuecomment-57501304 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3755][Core] Do not bind port 1 - 1024 t...

2014-10-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/2610#issuecomment-57512698 Thanks I'm merging this into master and 1.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3755][Core] Do not bind port 1 - 1024 t...

2014-10-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2610 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3755][Core] Do not bind port 1 - 1024 t...

2014-10-01 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2610#issuecomment-5777 This patch was actually broken - I'm going to revert it. It was causing the UI to bind to (4040 + 1024) --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-3755][Core] Do not bind port 1 - 1024 t...

2014-10-01 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/2610#issuecomment-57556337 Sorry, my mistake, the logical for port ( 1024) was not compatible with old code, i will modify this --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-3755][Core] Do not bind port 1 - 1024 t...

2014-10-01 Thread scwf
GitHub user scwf opened a pull request: https://github.com/apache/spark/pull/2623 [SPARK-3755][Core] Do not bind port 1 - 1024 to server in spark @pwendell, ```tryPort``` is not compatible with old code in last PR, this is to fix it You can merge this pull request into a Git

[GitHub] spark pull request: [SPARK-3755][Core] Do not bind port 1 - 1024 t...

2014-10-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2623#issuecomment-57558188 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3755][Core] Do not bind port 1 - 1024 t...

2014-10-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/2610#issuecomment-57567022 Oops you're right. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-3755][Core] Do not bind port 1 - 1024 t...

2014-10-01 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/2623#issuecomment-57574915 https://github.com/apache/spark/pull/2610 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project