Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3869#issuecomment-68843458
[Test build #25096 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25096/consoleFull)
for PR 3869 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/3869#discussion_r22514948
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/VectorsSuite.scala ---
@@ -175,6 +177,33 @@ class VectorsSuite extends FunSuite {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3869#issuecomment-68850284
[Test build #25096 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25096/consoleFull)
for PR 3869 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3869#issuecomment-68850290
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/3869#discussion_r22513912
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/VectorsSuite.scala ---
@@ -175,6 +177,33 @@ class VectorsSuite extends FunSuite {
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/3869#issuecomment-68942083
LGTM. Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3869
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3869#discussion_r22498301
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/VectorsSuite.scala ---
@@ -175,6 +177,33 @@ class VectorsSuite extends FunSuite {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/3869#discussion_r22477129
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/VectorsSuite.scala ---
@@ -175,6 +177,33 @@ class VectorsSuite extends FunSuite {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/3869#discussion_r22477118
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/VectorsSuite.scala ---
@@ -175,6 +177,33 @@ class VectorsSuite extends FunSuite {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/3869#discussion_r22477110
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/VectorsSuite.scala ---
@@ -175,6 +177,33 @@ class VectorsSuite extends FunSuite {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/3869#discussion_r22477114
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/VectorsSuite.scala ---
@@ -175,6 +177,33 @@ class VectorsSuite extends FunSuite {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/3869#discussion_r22477126
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/VectorsSuite.scala ---
@@ -175,6 +177,33 @@ class VectorsSuite extends FunSuite {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/3869#discussion_r22477111
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/VectorsSuite.scala ---
@@ -175,6 +177,33 @@ class VectorsSuite extends FunSuite {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/3869#discussion_r22490186
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/VectorsSuite.scala ---
@@ -175,6 +177,33 @@ class VectorsSuite extends FunSuite {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3869#issuecomment-68624964
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3869#issuecomment-68624960
[Test build #25026 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25026/consoleFull)
for PR 3869 at commit
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3869#issuecomment-68650535
@viirya LGTM Thanks!
CC: @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3869#issuecomment-68592581
[Test build #25008 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25008/consoleFull)
for PR 3869 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3869#issuecomment-68592586
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3869#issuecomment-68593232
[Test build #25009 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25009/consoleFull)
for PR 3869 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3869#issuecomment-68590798
[Test build #25009 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25009/consoleFull)
for PR 3869 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3869#issuecomment-68590631
[Test build #25008 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25008/consoleFull)
for PR 3869 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3869#issuecomment-68593235
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/3869#issuecomment-68590587
@jkbradley Thanks. I made a more proper unit test with random sparsity
pattern.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/3869#issuecomment-68592833
Please test again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3869#issuecomment-68606675
(I meant those comments for the main text but accidentally added them to
the commit instead.)
---
If your project is set up for it, you can reply to this email and
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3869#issuecomment-68606694
Other than those small comments, it looks good. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3869#issuecomment-68623272
[Test build #25026 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25026/consoleFull)
for PR 3869 at commit
29 matches
Mail list logo
