[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-04-09 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-91347701 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-04-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-91265851 [Test build #29941 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29941/consoleFull) for PR 5213 at commit

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-04-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-91348808 [Test build #29961 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29961/consoleFull) for PR 5213 at commit

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-04-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-91275448 [Test build #29945 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29945/consoleFull) for PR 5213 at commit

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-04-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-91274549 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-04-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-91363126 [Test build #29961 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29961/consoleFull) for PR 5213 at commit

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-04-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-91328549 [Test build #29952 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29952/consoleFull) for PR 5213 at commit

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-04-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-91311173 [Test build #29952 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29952/consoleFull) for PR 5213 at commit

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-04-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-91302140 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-04-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-91302117 [Test build #29945 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29945/consoleFull) for PR 5213 at commit

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-04-09 Thread shaneknapp
Github user shaneknapp commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-91274674 jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-04-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-91328594 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-04-05 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-89868426 The implementation looks good to me. There are some minor issues about the docstring style. Please fix it and it should be good to go. Thanks! --- If your project is set

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-04-05 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/5213#discussion_r27781308 --- Diff: python/pyspark/mllib/fpm.py --- @@ -0,0 +1,67 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-04-05 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/5213#discussion_r27781310 --- Diff: python/pyspark/mllib/fpm.py --- @@ -0,0 +1,67 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-04-05 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/5213#discussion_r27781306 --- Diff: python/pyspark/mllib/fpm.py --- @@ -0,0 +1,67 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-04-05 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/5213#discussion_r27781309 --- Diff: python/pyspark/mllib/fpm.py --- @@ -0,0 +1,67 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-04-05 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/5213#discussion_r27781307 --- Diff: python/pyspark/mllib/fpm.py --- @@ -0,0 +1,67 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-89633708 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-87968740 [Test build #29463 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29463/consoleFull) for PR 5213 at commit

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-87993418 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-87993400 [Test build #29463 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29463/consoleFull) for PR 5213 at commit

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/5213#discussion_r27506245 --- Diff: python/pyspark/mllib/fpm.py --- @@ -0,0 +1,81 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/5213#discussion_r27506251 --- Diff: python/pyspark/mllib/fpm.py --- @@ -0,0 +1,81 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/5213#discussion_r27506202 --- Diff: python/pyspark/mllib/fpm.py --- @@ -0,0 +1,81 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/5213#discussion_r27506158 --- Diff: python/pyspark/mllib/fpm.py --- @@ -0,0 +1,81 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/5213#discussion_r27506120 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala --- @@ -407,6 +406,35 @@ private[python] class PythonMLLibAPI extends

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/5213#discussion_r27506124 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala --- @@ -407,6 +406,35 @@ private[python] class PythonMLLibAPI extends

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/5213#discussion_r27506168 --- Diff: python/pyspark/mllib/fpm.py --- @@ -0,0 +1,81 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-30 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-87813779 @yanboliang Thanks for the updates. Can you please fix the merge issues? (Rebasing off of the current master is often easiest.) Also, can you please add

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-87372913 [Test build #29364 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29364/consoleFull) for PR 5213 at commit

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-87388652 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-87388637 [Test build #29364 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29364/consoleFull) for PR 5213 at commit

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-27 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/5213#discussion_r27331205 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala --- @@ -425,6 +426,33 @@ private[python] class PythonMLLibAPI extends

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-27 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/5213#discussion_r27331216 --- Diff: python/pyspark/mllib/fpm.py --- @@ -0,0 +1,74 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-27 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/5213#discussion_r27331201 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala --- @@ -425,6 +426,33 @@ private[python] class PythonMLLibAPI extends

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-27 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/5213#discussion_r27331208 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala --- @@ -425,6 +426,33 @@ private[python] class PythonMLLibAPI extends

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-27 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-87092628 Let's keep it Experimental for now; we can hopefully remove that tag before the 1.4 release if no issues come up before then. Also, can you please add doc to

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-86592836 [Test build #29237 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29237/consoleFull) for PR 5213 at commit

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-86644206 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-86644183 [Test build #29240 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29240/consoleFull) for PR 5213 at commit

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-86596561 [Test build #29237 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29237/consoleFull) for PR 5213 at commit

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-86596572 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5213#issuecomment-86604567 [Test build #29240 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29240/consoleFull) for PR 5213 at commit

[GitHub] spark pull request: [SPARK-6264] [MLLIB] Support FPGrowth algorith...

2015-03-26 Thread yanboliang
GitHub user yanboliang opened a pull request: https://github.com/apache/spark/pull/5213 [SPARK-6264] [MLLIB] Support FPGrowth algorithm in Python API Support FPGrowth algorithm in Python API You can merge this pull request into a Git repository by running: $ git pull