[GitHub] spark pull request: [SPARK-8664] [ML] Add PCA transformer

2015-06-30 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7065#issuecomment-117312797 Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8664] [ML] Add PCA transformer

2015-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7065 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-8664] [ML] Add PCA transformer

2015-06-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7065#issuecomment-116460292 [Test build #35962 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35962/consoleFull) for PR 7065 at commit

[GitHub] spark pull request: [SPARK-8664] [ML] Add PCA transformer

2015-06-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7065#issuecomment-116488507 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8664] [ML] Add PCA transformer

2015-06-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7065#issuecomment-116488468 [Test build #35962 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35962/console) for PR 7065 at commit

[GitHub] spark pull request: [SPARK-8664] [ML] Add PCA transformer

2015-06-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7065#issuecomment-116458114 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8664] [ML] Add PCA transformer

2015-06-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7065#issuecomment-116458262 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8664] [ML] Add PCA transformer

2015-06-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7065#issuecomment-116241394 [Test build #35929 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35929/console) for PR 7065 at commit

[GitHub] spark pull request: [SPARK-8664] [ML] Add PCA transformer

2015-06-28 Thread yanboliang
GitHub user yanboliang opened a pull request: https://github.com/apache/spark/pull/7065 [SPARK-8664] [ML] Add PCA transformer Add PCA transformer for ML pipeline You can merge this pull request into a Git repository by running: $ git pull https://github.com/yanboliang/spark

[GitHub] spark pull request: [SPARK-8664] [ML] Add PCA transformer

2015-06-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7065#issuecomment-116224957 [Test build #35929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35929/consoleFull) for PR 7065 at commit

[GitHub] spark pull request: [SPARK-8664] [ML] Add PCA transformer

2015-06-28 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7065#discussion_r33420498 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/PCA.scala --- @@ -68,7 +68,7 @@ class PCA(val k: Int) { * @param k number of principal

[GitHub] spark pull request: [SPARK-8664] [ML] Add PCA transformer

2015-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7065#issuecomment-116224612 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8664] [ML] Add PCA transformer

2015-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7065#issuecomment-116224581 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8664] [ML] Add PCA transformer

2015-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7065#issuecomment-116241503 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8664] [ML] Add PCA transformer

2015-06-28 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/7065#discussion_r33435077 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/PCA.scala --- @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-8664] [ML] Add PCA transformer

2015-06-28 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7065#issuecomment-116443860 LGTM except a minor inline comment. Please create JIRAs and submit PRs for the following: 1. Java unit test 1. Python API 1. set ML attributes in the PCA