Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/8113#discussion_r36818586
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -130,23 +138,36 @@ case class
GitHub user yhuai opened a pull request:
https://github.com/apache/spark/pull/8113
[SPARK-9740] [SQL] Change the default behavior of First/Last to RESPECT
NULLS.
I am changing behavior of `First`/`Last` to respect null values (the SQL
standard default behavior).
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/8113#issuecomment-130097666
@hvanhovell I am making the default in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8113#issuecomment-130098506
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8113#issuecomment-130098540
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8113#issuecomment-130099642
[Test build #40531 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40531/consoleFull)
for PR 8113 at commit
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/8113#discussion_r36818762
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -130,23 +138,36 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/8113#discussion_r36818719
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -130,23 +138,36 @@ case class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8113#issuecomment-130155854
[Test build #40589 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40589/consoleFull)
for PR 8113 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8113#issuecomment-130128067
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8113#issuecomment-130127953
[Test build #40531 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40531/console)
for PR 8113 at commit
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/8113#issuecomment-130128926
Besides the ```valueSet``` update/merge expressions LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/8113#issuecomment-130128822
yeah. I think that only require a small change. Let me add it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8113#discussion_r36825930
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
---
@@ -630,59 +632,114 @@ case class
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/8113#issuecomment-130155568
@hvanhovell Alright. I added the `ignoreNulls` flag.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8113#issuecomment-130155782
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8113#issuecomment-130155769
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/8113#issuecomment-130128263
LGTM. One final question, shouldn't we introduce a ```skipNulls```
parameter? Or do you want to address this in a follow-up PR?
---
If your project is set up for
18 matches
Mail list logo
