GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/2670
SPARK-3811 [CORE] More robust / standard Utils.deleteRecursively,
Utils.createTempDir
I noticed a few issues with how temp directories are created and deleted:
*Minor*
* Guava's
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2670#issuecomment-57998800
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21321/consoleFull)
for PR 2670 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2670#issuecomment-58004841
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21321/consoleFull)
for PR 2670 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2670#issuecomment-58004848
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2670#issuecomment-58059674
So, I've never been a fan of `File.deleteOnExit()`, and just to make sure
my dislike was not unfounded, I wrote the following code:
import java.io.*;
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2670#discussion_r1847
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -251,15 +265,8 @@ private[spark] object Utils extends Logging {
} catch {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2670#discussion_r18473543
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -251,15 +265,8 @@ private[spark] object Utils extends Logging {
} catch {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2670#discussion_r18473624
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -666,15 +673,27 @@ private[spark] object Utils extends Logging {
*/
def
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2670#discussion_r18473752
--- Diff:
core/src/test/scala/org/apache/spark/rdd/PairRDDFunctionsSuite.scala ---
@@ -381,14 +382,13 @@ class PairRDDFunctionsSuite extends FunSuite with
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2670#issuecomment-58062851
LGTM, just a few minor things.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2670#discussion_r18473851
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -666,15 +673,27 @@ private[spark] object Utils extends Logging {
*/
def
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2670#discussion_r18474437
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -666,15 +673,27 @@ private[spark] object Utils extends Logging {
*/
def
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2670#discussion_r18474544
--- Diff:
core/src/test/scala/org/apache/spark/rdd/PairRDDFunctionsSuite.scala ---
@@ -381,14 +382,13 @@ class PairRDDFunctionsSuite extends FunSuite with
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2670#discussion_r18474568
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -666,15 +673,27 @@ private[spark] object Utils extends Logging {
*/
def
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2670#discussion_r18474833
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -666,15 +673,27 @@ private[spark] object Utils extends Logging {
*/
def
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2670#issuecomment-58082359
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21338/consoleFull)
for PR 2670 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2670#issuecomment-58096634
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2670#issuecomment-58096619
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21338/consoleFull)
for PR 2670 at commit
18 matches
Mail list logo
