[GitHub] spark pull request #16082: [SPARK-18652][PYTHON] Include the example data an...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16082 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16082: [SPARK-18652][PYTHON] Include the example data an...
Github user lins05 commented on a diff in the pull request: https://github.com/apache/spark/pull/16082#discussion_r90774898 --- Diff: python/setup.py --- @@ -69,10 +69,13 @@ EXAMPLES_PATH = os.path.join(SPARK_HOME, "examples/src/main/python") SCRIPTS_PATH = os.path.join(SPARK_HOME, "bin") +DATA_PATH = os.path.join(SPARK_HOME, "data") SCRIPTS_TARGET = os.path.join(TEMP_PATH, "bin") JARS_TARGET = os.path.join(TEMP_PATH, "jars") EXAMPLES_TARGET = os.path.join(TEMP_PATH, "examples") - +DATA_TARGET = os.path.join(TEMP_PATH, "data") +LICENSES_PATH = os.path.join(SPARK_HOME, "licenses") --- End diff -- Done. Good catch! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16082: [SPARK-18652][PYTHON] Include the example data an...
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/16082#discussion_r90774722 --- Diff: python/setup.py --- @@ -69,10 +69,13 @@ EXAMPLES_PATH = os.path.join(SPARK_HOME, "examples/src/main/python") SCRIPTS_PATH = os.path.join(SPARK_HOME, "bin") +DATA_PATH = os.path.join(SPARK_HOME, "data") SCRIPTS_TARGET = os.path.join(TEMP_PATH, "bin") JARS_TARGET = os.path.join(TEMP_PATH, "jars") EXAMPLES_TARGET = os.path.join(TEMP_PATH, "examples") - +DATA_TARGET = os.path.join(TEMP_PATH, "data") +LICENSES_PATH = os.path.join(SPARK_HOME, "licenses") --- End diff -- Super minor, and sorry I didn't notice it earlier, but we define all of the _PATHs before the target - just for someone skimming the code would be good to keep the current flow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16082: [SPARK-18652][PYTHON] Include the example data an...
Github user lins05 commented on a diff in the pull request: https://github.com/apache/spark/pull/16082#discussion_r90774685 --- Diff: python/MANIFEST.in --- @@ -17,6 +17,8 @@ global-exclude *.py[cod] __pycache__ .DS_Store recursive-include deps/jars *.jar graft deps/bin +graft deps/data --- End diff -- On a second thought I think it would be better to keep all the packages consistent (specifying the patterns to include in both MANIFEST.in and setup.py), so I changed the `graft` to `recursive-include` with proper patters as you suggested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16082: [SPARK-18652][PYTHON] Include the example data an...
Github user lins05 commented on a diff in the pull request: https://github.com/apache/spark/pull/16082#discussion_r90774620 --- Diff: python/setup.py --- @@ -69,10 +69,15 @@ EXAMPLES_PATH = os.path.join(SPARK_HOME, "examples/src/main/python") SCRIPTS_PATH = os.path.join(SPARK_HOME, "bin") +DATA_PATH = os.path.join(SPARK_HOME, "data") SCRIPTS_TARGET = os.path.join(TEMP_PATH, "bin") JARS_TARGET = os.path.join(TEMP_PATH, "jars") EXAMPLES_TARGET = os.path.join(TEMP_PATH, "examples") +DATA_TARGET = os.path.join(TEMP_PATH, "data") +LICENSES_PATH = os.path.join(SPARK_HOME, "licenses") +LICENSES_TARGET = os.path.join(TEMP_PATH, "licenses") +data_files = glob.glob(os.path.join(LICENSES_PATH, "*")) --- End diff -- Makes sense, I'll remove the data_files related to make them consistent. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
