Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16386
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101683820
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1802,4 +1806,142 @@ class JsonSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101683991
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1802,4 +1806,142 @@ class JsonSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101684712
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -0,0 +1,216 @@
+/*
+ * Licensed to
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101683719
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -394,36 +447,30 @@ class JacksonParser(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101685228
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1802,4 +1806,142 @@ class JsonSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101683953
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1802,4 +1806,142 @@ class JsonSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101683631
--- Diff:
core/src/main/scala/org/apache/spark/input/PortableDataStream.scala ---
@@ -193,6 +196,10 @@ class PortableDataStream(
}
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101683916
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1802,4 +1806,142 @@ class JsonSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101684619
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala
---
@@ -37,29 +32,30 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101684365
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1802,4 +1806,142 @@ class JsonSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101684508
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,123 @@ class JsonSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101683666
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,110 @@ class JacksonParser(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101684686
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -0,0 +1,216 @@
+/*
+ * Licensed to
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101685374
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1802,4 +1806,142 @@ class JsonSuite extends
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101671453
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,117 @@ class JsonSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101460558
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1802,4 +1806,118 @@ class JsonSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101460391
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,117 @@ class JsonSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101453945
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala
---
@@ -151,6 +153,8 @@ final class DataStreamReader
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101453441
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -332,20 +336,21 @@ class DataFrameReader private[sql](sparkSession:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101453350
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -261,14 +261,18 @@ class DataFrameReader private[sql](sparkSession:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101451711
--- Diff: python/pyspark/sql/streaming.py ---
@@ -442,6 +444,8 @@ def json(self, path, schema=None,
primitivesAsString=None, prefersDecimal=None,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r101451677
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -159,18 +159,21 @@ def json(self, path, schema=None,
primitivesAsString=None, prefersDecimal=None,
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100687458
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,110 @@ class JacksonParser(
// A
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100679183
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,117 @@ class JsonSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100679101
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -394,36 +447,32 @@ class JacksonParser(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100678935
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,110 @@ class JacksonParser(
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100653879
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,123 @@ class JsonSuite extends
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100653835
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,123 @@ class JsonSuite extends
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100653757
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,123 @@ class JsonSuite extends
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100653580
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,123 @@ class JsonSuite extends
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100652445
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -0,0 +1,213 @@
+/*
+ * Licensed
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100652259
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,123 @@ class JsonSuite extends
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100652192
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,123 @@ class JsonSuite extends
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100651990
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,123 @@ class JsonSuite extends
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100651910
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,123 @@ class JsonSuite extends
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100651706
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonInferSchema.scala
---
@@ -79,7 +80,7 @@ private[sql] object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100651385
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,123 @@ class JsonSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100651178
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,123 @@ class JsonSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100651103
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,123 @@ class JsonSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100651055
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,123 @@ class JsonSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100650756
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,123 @@ class JsonSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100650577
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,123 @@ class JsonSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100650500
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,123 @@ class JsonSuite extends
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100650450
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -394,36 +447,32 @@ class JacksonParser(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100650024
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,123 @@ class JsonSuite extends
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100649836
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,110 @@ class JacksonParser(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100649847
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonInferSchema.scala
---
@@ -79,7 +80,7 @@ private[sql] object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100649748
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala
---
@@ -97,46 +91,13 @@ class JsonFileFormat
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100649635
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -31,10 +31,17 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100649228
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -394,36 +447,32 @@ class JacksonParser(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100649101
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -394,36 +447,32 @@ class JacksonParser(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100648863
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -394,36 +447,32 @@ class JacksonParser(
}
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100648524
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -394,36 +447,32 @@ class JacksonParser(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100648519
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -0,0 +1,213 @@
+/*
+ * Licensed to
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100648210
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -394,36 +447,32 @@ class JacksonParser(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100648139
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,102 @@ class JacksonParser(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100647494
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,110 @@ class JacksonParser(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100647047
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -31,10 +31,17 @@ import
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100646497
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,98 @@ class JacksonParser(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100644275
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,98 @@ class JacksonParser(
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100640620
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,98 @@ class JacksonParser(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100612936
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,98 @@ class JacksonParser(
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100610662
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,98 @@ class JacksonParser(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100587425
--- Diff: core/src/main/scala/org/apache/spark/util/ExecuteOnce.scala ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100586852
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,98 @@ class JacksonParser(
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100474809
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,102 @@ class JacksonParser(
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100344879
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,102 @@ class JacksonParser(
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100344282
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,102 @@ class JacksonParser(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100332529
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -298,22 +312,22 @@ class JacksonParser(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100294813
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,102 @@ class JacksonParser(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100294563
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,102 @@ class JacksonParser(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100294186
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,102 @@ class JacksonParser(
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100219153
--- Diff:
core/src/main/scala/org/apache/spark/input/PortableDataStream.scala ---
@@ -194,5 +195,8 @@ class PortableDataStream(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100217653
--- Diff:
core/src/main/scala/org/apache/spark/input/PortableDataStream.scala ---
@@ -194,5 +195,8 @@ class PortableDataStream(
}
def
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100104738
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -298,22 +312,22 @@ class JacksonParser(
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100103739
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -227,66 +267,71 @@ class JacksonParser(
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100101464
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -160,7 +164,17 @@ public void writeTo(OutputStream out)
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100100641
--- Diff:
core/src/main/scala/org/apache/spark/input/PortableDataStream.scala ---
@@ -194,5 +195,8 @@ class PortableDataStream(
}
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100099791
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -31,10 +31,17 @@ import
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100098008
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,125 @@ class JsonSuite extends
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100097749
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -0,0 +1,213 @@
+/*
+ * Licensed
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100083481
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,125 @@ class JsonSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100082372
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,125 @@ class JsonSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100081170
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -0,0 +1,213 @@
+/*
+ * Licensed to
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100064532
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -298,22 +312,22 @@ class JacksonParser(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100064266
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -227,66 +267,71 @@ class JacksonParser(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100063010
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -160,7 +164,17 @@ public void writeTo(OutputStream out) throws
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r99535380
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -31,10 +31,17 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r99534380
--- Diff:
core/src/main/scala/org/apache/spark/input/PortableDataStream.scala ---
@@ -194,5 +195,8 @@ class PortableDataStream(
}
def
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r99534181
--- Diff:
core/src/main/scala/org/apache/spark/input/PortableDataStream.scala ---
@@ -194,5 +195,8 @@ class PortableDataStream(
}
def
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r93970059
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala
---
@@ -36,29 +31,31 @@ import
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r93969732
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -0,0 +1,204 @@
+/*
+ * Licensed
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r93733483
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala
---
@@ -36,29 +31,31 @@ import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r93732800
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -0,0 +1,204 @@
+/*
+ * Licensed
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r93731259
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -155,21 +155,24 @@ def load(self, path=None, format=None, schema=None,
**options):
return
GitHub user NathanHowell opened a pull request:
https://github.com/apache/spark/pull/16386
[SPARK-18352][SQL] Support parsing multiline json files
## What changes were proposed in this pull request?
If a new option `wholeFile` is set to `true` the JSON reader will parse
97 matches
Mail list logo
