Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21291
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r189154765
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -55,7 +55,9 @@ class WholeStageCodegenSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r189151725
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -55,7 +55,9 @@ class WholeStageCodegenSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r189149095
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ConfigBehaviorSuite.scala ---
@@ -39,7 +39,9 @@ class ConfigBehaviorSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r188994080
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ConfigBehaviorSuite.scala ---
@@ -39,7 +39,9 @@ class ConfigBehaviorSuite extends QueryTest with
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r188979880
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ConfigBehaviorSuite.scala ---
@@ -39,7 +39,9 @@ class ConfigBehaviorSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r188972061
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ConfigBehaviorSuite.scala ---
@@ -39,7 +39,9 @@ class ConfigBehaviorSuite extends QueryTest with
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r188953639
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ConfigBehaviorSuite.scala ---
@@ -39,7 +39,9 @@ class ConfigBehaviorSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r188914786
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ConfigBehaviorSuite.scala ---
@@ -39,7 +39,9 @@ class ConfigBehaviorSuite extends QueryTest with
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r10937
--- Diff: python/pyspark/sql/tests.py ---
@@ -5239,8 +5239,8 @@ def test_complex_groupby(self):
expected2 = df.groupby().agg(sum(df.v))
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r188878956
--- Diff: python/pyspark/sql/tests.py ---
@@ -5239,8 +5239,8 @@ def test_complex_groupby(self):
expected2 = df.groupby().agg(sum(df.v))
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r188872101
--- Diff: python/pyspark/sql/tests.py ---
@@ -5239,8 +5239,8 @@ def test_complex_groupby(self):
expected2 = df.groupby().agg(sum(df.v))
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r188871199
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/debug/DebuggingSuite.scala
---
@@ -34,14 +34,13 @@ class DebuggingSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r188870491
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ConfigBehaviorSuite.scala ---
@@ -39,7 +39,9 @@ class ConfigBehaviorSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r188868610
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/debug/DebuggingSuite.scala
---
@@ -34,14 +34,13 @@ class DebuggingSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r188868678
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/debug/DebuggingSuite.scala
---
@@ -34,14 +34,13 @@ class DebuggingSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r188868165
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ConfigBehaviorSuite.scala ---
@@ -39,7 +39,9 @@ class ConfigBehaviorSuite extends QueryTest with
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r188659776
--- Diff: python/pyspark/sql/tests.py ---
@@ -5239,8 +5239,8 @@ def test_complex_groupby(self):
expected2 = df.groupby().agg(sum(df.v))
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r188629669
--- Diff: python/pyspark/sql/tests.py ---
@@ -5239,8 +5239,8 @@ def test_complex_groupby(self):
expected2 = df.groupby().agg(sum(df.v))
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r188131133
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ConfigBehaviorSuite.scala ---
@@ -39,7 +39,9 @@ class ConfigBehaviorSuite extends QueryTest with
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r188130563
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -621,6 +621,25 @@ class PlannerSuite extends SharedSQLContext {
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r188082738
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ConfigBehaviorSuite.scala ---
@@ -39,7 +39,9 @@ class ConfigBehaviorSuite extends QueryTest with
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r188081824
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -621,6 +621,25 @@ class PlannerSuite extends SharedSQLContext {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r187951662
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -621,6 +621,25 @@ class PlannerSuite extends SharedSQLContext {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r187900810
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -621,6 +621,25 @@ class PlannerSuite extends SharedSQLContext
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r187900467
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -621,6 +621,25 @@ class PlannerSuite extends SharedSQLContext
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r187569307
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2767,7 +2767,12 @@ class Dataset[T] private[sql](
* @since 1.6.0
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r187565401
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2767,7 +2767,12 @@ class Dataset[T] private[sql](
* @since 1.6.0
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r187529583
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2767,7 +2767,12 @@ class Dataset[T] private[sql](
* @since 1.6.0
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r187502412
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -345,6 +345,16 @@ case class RangeExec(range:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r187489196
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -345,6 +345,16 @@ case class RangeExec(range:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r187480496
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -345,6 +345,8 @@ case class RangeExec(range:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r187370831
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -345,6 +345,8 @@ case class RangeExec(range:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r187353657
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -621,6 +621,17 @@ class PlannerSuite extends SharedSQLContext {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r187350669
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -621,6 +621,17 @@ class PlannerSuite extends SharedSQLContext {
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/21291
[SPARK-24242][SQL] RangeExec should have correct outputOrdering
## What changes were proposed in this pull request?
Logical `Range` node has been added with `outputOrdering` recently. It's
36 matches
Mail list logo
