Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r196257515
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -154,6 +154,24 @@ private[spark] object Config
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r196249925
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -154,6 +154,24 @@ private[spark] object
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21366
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195569529
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
---
@@ -0,0 +1,65
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195567414
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
---
@@ -0,0
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195567079
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
---
@@ -0,0
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195566124
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsSnapshotsStoreImpl.scala
---
@@ -0,0 +1,88
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195565315
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
---
@@ -0,0 +1,65
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195561927
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
---
@@ -0,0
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195549746
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
---
@@ -0,0 +1,65
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195542619
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
---
@@ -0,0
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195535296
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
---
@@ -0,0 +1,65
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195513995
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -56,17 +58,44 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195512808
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
---
@@ -0,0
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195512430
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -0,0 +1,141 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195512219
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -56,17 +58,44 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195445788
--- Diff: pom.xml ---
@@ -760,6 +760,12 @@
1.10.19
test
+
--- End diff --
Thanx @ktoso!
---
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195401593
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
---
@@ -0,0 +1,65
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195390942
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
---
@@ -0,0 +1,65
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195382788
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsSnapshotsStoreImpl.scala
---
@@ -0,0 +1,88 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195380019
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleManager.scala
---
@@ -0,0 +1,164 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195379975
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleManager.scala
---
@@ -0,0 +1,164 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195379907
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleManager.scala
---
@@ -0,0 +1,164 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195379060
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -56,17 +58,44 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195351851
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsSnapshotsStoreImpl.scala
---
@@ -0,0 +1,88 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195350385
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -0,0 +1,141 @@
+/*
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r195040122
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
---
@@ -0,0 +1,65
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r194856403
--- Diff: pom.xml ---
@@ -760,6 +760,12 @@
1.10.19
test
+
--- End diff --
I ended up just
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r194840955
--- Diff: pom.xml ---
@@ -760,6 +760,12 @@
1.10.19
test
+
--- End diff --
These types are not
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r194839188
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
---
@@ -0,0
Github user ktoso commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r194736679
--- Diff: pom.xml ---
@@ -760,6 +760,12 @@
1.10.19
test
+
--- End diff --
Seems some confusion is
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r194670526
--- Diff: pom.xml ---
@@ -760,6 +760,12 @@
1.10.19
test
+
--- End diff --
> Does Akka streams
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r194664576
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
---
@@ -0,0 +1,65
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r194574775
--- Diff: pom.xml ---
@@ -760,6 +760,12 @@
1.10.19
test
+
--- End diff --
> One question is how
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r194572858
--- Diff: pom.xml ---
@@ -760,6 +760,12 @@
1.10.19
test
+
--- End diff --
> f not mistaken Java
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r194560151
--- Diff: pom.xml ---
@@ -760,6 +760,12 @@
1.10.19
test
+
--- End diff --
@felixcheung (sorry
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r194536061
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsSnapshotsStoreImpl.scala
---
@@ -0,0 +1,95
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r194535271
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsSnapshotsStoreImpl.scala
---
@@ -0,0 +1,95
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r194534077
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsSnapshotsStoreImpl.scala
---
@@ -0,0 +1,95 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r194184310
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsSnapshotsStoreImpl.scala
---
@@ -0,0 +1,95
Github user dvogelbacher commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r194183023
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsSnapshotsStoreImpl.scala
---
@@ -0,0
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r194181797
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsSnapshotsStoreImpl.scala
---
@@ -0,0 +1,95
Github user dvogelbacher commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r194180839
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleManager.scala
---
@@ -0,0
Github user dvogelbacher commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r194179846
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsSnapshotsStoreImpl.scala
---
@@ -0,0
Github user dvogelbacher commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r194177422
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -49,48 +54,58 @@
Github user dvogelbacher commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r194176787
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -105,14 +120,15
46 matches
Mail list logo