Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23130
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23130#discussion_r237121289
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala ---
@@ -142,4 +144,15 @@ class SaveLoadSuite extends DataSourceTest
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23130#discussion_r237085148
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala ---
@@ -142,4 +144,15 @@ class SaveLoadSuite extends DataSourceTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23130#discussion_r237062653
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala ---
@@ -142,4 +144,15 @@ class SaveLoadSuite extends DataSourceTest
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23130#discussion_r237050065
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala ---
@@ -142,4 +144,15 @@ class SaveLoadSuite extends DataSourceTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23130#discussion_r237045706
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala ---
@@ -142,4 +144,15 @@ class SaveLoadSuite extends DataSourceTest
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23130#discussion_r236721863
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala ---
@@ -142,4 +143,15 @@ class SaveLoadSuite extends DataSourceTest with
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23130#discussion_r236719477
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala ---
@@ -142,4 +143,15 @@ class SaveLoadSuite extends DataSourceTest with
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23130#discussion_r236705916
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala ---
@@ -142,4 +143,15 @@ class SaveLoadSuite extends DataSourceTest with
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23130#discussion_r236705666
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala ---
@@ -142,4 +143,15 @@ class SaveLoadSuite extends DataSourceTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23130#discussion_r236515927
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -388,7 +388,7 @@ case class FileSourceScanExec(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/23130#discussion_r236361995
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -388,7 +388,7 @@ case class FileSourceScanExec(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23130#discussion_r236233074
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -388,7 +388,7 @@ case class FileSourceScanExec(
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23130#discussion_r236226380
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -388,7 +388,7 @@ case class FileSourceScanExec(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23130#discussion_r236149203
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -388,7 +388,7 @@ case class FileSourceScanExec(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/23130#discussion_r236135787
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -388,7 +388,7 @@ case class FileSourceScanExec(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/23130#discussion_r236135647
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -388,7 +388,7 @@ case class FileSourceScanExec(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23130#discussion_r236077780
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala ---
@@ -142,4 +143,15 @@ class SaveLoadSuite extends DataSourceTest
GitHub user MaxGekk opened a pull request:
https://github.com/apache/spark/pull/23130
[SPARK-26161][SQL] Ignore empty files in load
## What changes were proposed in this pull request?
In the PR, I propose filtering out all empty files inside of
`DataSourceScanExec` and
19 matches
Mail list logo